[INFO] cloning repository https://github.com/allenz2423/rust_tictactoe [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/allenz2423/rust_tictactoe" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fallenz2423%2Frust_tictactoe", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fallenz2423%2Frust_tictactoe'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d423639492aa3de1d3c800aca70b2e2329e44583 [INFO] checking allenz2423/rust_tictactoe against master#c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2 for pr-142712 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fallenz2423%2Frust_tictactoe" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/allenz2423/rust_tictactoe [INFO] finished tweaking git repo https://github.com/allenz2423/rust_tictactoe [INFO] tweaked toml for git repo https://github.com/allenz2423/rust_tictactoe written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/allenz2423/rust_tictactoe on toolchain c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/allenz2423/rust_tictactoe already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b8a620514ce013631ecc52719ed76a313539ebe0bccbe234a9824321e9bf725 [INFO] running `Command { std: "docker" "start" "-a" "4b8a620514ce013631ecc52719ed76a313539ebe0bccbe234a9824321e9bf725", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b8a620514ce013631ecc52719ed76a313539ebe0bccbe234a9824321e9bf725", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b8a620514ce013631ecc52719ed76a313539ebe0bccbe234a9824321e9bf725", kill_on_drop: false }` [INFO] [stdout] 4b8a620514ce013631ecc52719ed76a313539ebe0bccbe234a9824321e9bf725 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 414b391ea1c9605090b7a40bfd088c68b0984704fa6b9e733af5c5cd81013d0c [INFO] running `Command { std: "docker" "start" "-a" "414b391ea1c9605090b7a40bfd088c68b0984704fa6b9e733af5c5cd81013d0c", kill_on_drop: false }` [INFO] [stderr] Checking tictactoe v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | ... if((board[i][0] == turn && board[i][0] == board[i][1] && board[i][1] == board[i][2]) || (board[0][i] == turn && board[0][i] == board[1][i] && board[0][i] == board[2][i])) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 10 - if((board[i][0] == turn && board[i][0] == board[i][1] && board[i][1] == board[i][2]) || (board[0][i] == turn && board[0][i] == board[1][i] && board[0][i] == board[2][i])) { [INFO] [stdout] 10 + if (board[i][0] == turn && board[i][0] == board[i][1] && board[i][1] == board[i][2]) || (board[0][i] == turn && board[0][i] == board[1][i] && board[0][i] == board[2][i]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | ... if((board[0][0] == turn && board[0][0] == board[1][1] && board[0][0] == board[2][2]) || (board[2][0] == turn && board[2][0] == board[1][1] && board[1][1] == board[0][2])) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 14 - if((board[0][0] == turn && board[0][0] == board[1][1] && board[0][0] == board[2][2]) || (board[2][0] == turn && board[2][0] == board[1][1] && board[1][1] == board[0][2])) { [INFO] [stdout] 14 + if (board[0][0] == turn && board[0][0] == board[1][1] && board[0][0] == board[2][2]) || (board[2][0] == turn && board[2][0] == board[1][1] && board[1][1] == board[0][2]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 17 | if(turn == "X") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - if(turn == "X") { [INFO] [stdout] 17 + if turn == "X" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | if(insert(modifier) == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 53 - if(insert(modifier) == true) { [INFO] [stdout] 53 + if insert(modifier) == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | ... if((board[i][0] == turn && board[i][0] == board[i][1] && board[i][1] == board[i][2]) || (board[0][i] == turn && board[0][i] == board[1][i] && board[0][i] == board[2][i])) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 10 - if((board[i][0] == turn && board[i][0] == board[i][1] && board[i][1] == board[i][2]) || (board[0][i] == turn && board[0][i] == board[1][i] && board[0][i] == board[2][i])) { [INFO] [stdout] 10 + if (board[i][0] == turn && board[i][0] == board[i][1] && board[i][1] == board[i][2]) || (board[0][i] == turn && board[0][i] == board[1][i] && board[0][i] == board[2][i]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | ... if((board[0][0] == turn && board[0][0] == board[1][1] && board[0][0] == board[2][2]) || (board[2][0] == turn && board[2][0] == board[1][1] && board[1][1] == board[0][2])) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 14 - if((board[0][0] == turn && board[0][0] == board[1][1] && board[0][0] == board[2][2]) || (board[2][0] == turn && board[2][0] == board[1][1] && board[1][1] == board[0][2])) { [INFO] [stdout] 14 + if (board[0][0] == turn && board[0][0] == board[1][1] && board[0][0] == board[2][2]) || (board[2][0] == turn && board[2][0] == board[1][1] && board[1][1] == board[0][2]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 17 | if(turn == "X") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - if(turn == "X") { [INFO] [stdout] 17 + if turn == "X" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | if(insert(modifier) == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 53 - if(insert(modifier) == true) { [INFO] [stdout] 53 + if insert(modifier) == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `board` should have an upper case name [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | static mut board:[[&str;3];3] = [["#","#","#"] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 2 - static mut board:[[&str;3];3] = [["#","#","#"] [INFO] [stdout] 2 + static mut BOARD:[[&str;3];3] = [["#","#","#"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `win` should have an upper case name [INFO] [stdout] --> src/main.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | static mut win:bool = false; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 5 - static mut win:bool = false; [INFO] [stdout] 5 + static mut WIN:bool = false; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `turn` should have an upper case name [INFO] [stdout] --> src/main.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | static mut turn:&str = "X"; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 6 - static mut turn:&str = "X"; [INFO] [stdout] 6 + static mut TURN:&str = "X"; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..board.len() { [INFO] [stdout] | ^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | println!("It's {}'s turn!", turn); [INFO] [stdout] | ^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | for i in 0..board.len() { [INFO] [stdout] | ^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 73 | println!("The winner is {}!", turn); [INFO] [stdout] | ^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `board` should have an upper case name [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | static mut board:[[&str;3];3] = [["#","#","#"] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 2 - static mut board:[[&str;3];3] = [["#","#","#"] [INFO] [stdout] 2 + static mut BOARD:[[&str;3];3] = [["#","#","#"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `win` should have an upper case name [INFO] [stdout] --> src/main.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | static mut win:bool = false; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 5 - static mut win:bool = false; [INFO] [stdout] 5 + static mut WIN:bool = false; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `turn` should have an upper case name [INFO] [stdout] --> src/main.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | static mut turn:&str = "X"; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 6 - static mut turn:&str = "X"; [INFO] [stdout] 6 + static mut TURN:&str = "X"; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..board.len() { [INFO] [stdout] | ^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | println!("It's {}'s turn!", turn); [INFO] [stdout] | ^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | for i in 0..board.len() { [INFO] [stdout] | ^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 73 | println!("The winner is {}!", turn); [INFO] [stdout] | ^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s [INFO] running `Command { std: "docker" "inspect" "414b391ea1c9605090b7a40bfd088c68b0984704fa6b9e733af5c5cd81013d0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "414b391ea1c9605090b7a40bfd088c68b0984704fa6b9e733af5c5cd81013d0c", kill_on_drop: false }` [INFO] [stdout] 414b391ea1c9605090b7a40bfd088c68b0984704fa6b9e733af5c5cd81013d0c