[INFO] cloning repository https://github.com/michalsrb/rapidquilt [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/michalsrb/rapidquilt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichalsrb%2Frapidquilt", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichalsrb%2Frapidquilt'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 67100d4b2336bdf24cc8c3799b0e4e159fe959b8 [INFO] building michalsrb/rapidquilt against master#44f415c1d617ebc7b931a243b7b321ef8a6ca47c for pr-142134-abi-ast-error [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichalsrb%2Frapidquilt" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/michalsrb/rapidquilt on toolchain 44f415c1d617ebc7b931a243b7b321ef8a6ca47c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/michalsrb/rapidquilt [INFO] finished tweaking git repo https://github.com/michalsrb/rapidquilt [INFO] tweaked toml for git repo https://github.com/michalsrb/rapidquilt written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/michalsrb/rapidquilt already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded darling v0.8.5 [INFO] [stderr] Downloaded darling_macro v0.8.5 [INFO] [stderr] Downloaded derive_builder v0.7.1 [INFO] [stderr] Downloaded ident_case v1.0.0 [INFO] [stderr] Downloaded jemallocator v0.1.9 [INFO] [stderr] Downloaded darling_core v0.8.5 [INFO] [stderr] Downloaded nom v4.2.2 [INFO] [stderr] Downloaded seahash v3.0.6 [INFO] [stderr] Downloaded derive_builder_core v0.4.1 [INFO] [stderr] Downloaded pathfinding v1.1.12 [INFO] [stderr] Downloaded jemalloc-sys v0.1.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eea15d5475069c3ef791f10c2c6b5af2ee421ef2da1e680ecce1cba46243983b" "/opt/rustwide/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2e2774869d190c54fa581acd4ed776824227360cd4643f91202c305803eec10 [INFO] running `Command { std: "docker" "start" "-a" "a2e2774869d190c54fa581acd4ed776824227360cd4643f91202c305803eec10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2e2774869d190c54fa581acd4ed776824227360cd4643f91202c305803eec10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2e2774869d190c54fa581acd4ed776824227360cd4643f91202c305803eec10", kill_on_drop: false }` [INFO] [stdout] a2e2774869d190c54fa581acd4ed776824227360cd4643f91202c305803eec10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eea15d5475069c3ef791f10c2c6b5af2ee421ef2da1e680ecce1cba46243983b" "/opt/rustwide/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf908f333f5de6a2ae0a4a38d74eeb1fe11b79562d197e612da8c5ae37224e50 [INFO] running `Command { std: "docker" "start" "-a" "bf908f333f5de6a2ae0a4a38d74eeb1fe11b79562d197e612da8c5ae37224e50", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.50 [INFO] [stderr] Compiling proc-macro2 v0.4.27 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling cc v1.0.30 [INFO] [stderr] Compiling cfg-if v0.1.7 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling lazy_static v1.3.0 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling nodrop v0.1.13 [INFO] [stderr] Compiling ident_case v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.2.2 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling fs_extra v1.1.0 [INFO] [stderr] Compiling memoffset v0.2.1 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling either v1.5.1 [INFO] [stderr] Compiling backtrace v0.3.14 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling derive_builder v0.7.1 [INFO] [stderr] Compiling rustc-demangle v0.1.13 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Compiling itertools v0.8.0 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling indexmap v1.0.2 [INFO] [stderr] Compiling fixedbitset v0.1.9 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Compiling num_cpus v1.10.0 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling jemalloc-sys v0.1.8 [INFO] [stderr] Compiling syn v0.15.27 [INFO] [stderr] Compiling unicode-width v0.1.5 [INFO] [stderr] Compiling getopts v0.2.18 [INFO] [stderr] Compiling nom v4.2.2 [INFO] [stderr] Compiling pathfinding v1.1.12 [INFO] [stderr] Compiling atty v0.2.11 [INFO] [stderr] Compiling colored v1.7.0 [INFO] [stderr] Compiling smallvec v0.6.9 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling seahash v3.0.6 [INFO] [stderr] Compiling darling_core v0.8.5 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling failure v0.1.5 [INFO] [stderr] Compiling darling_macro v0.8.5 [INFO] [stderr] Compiling darling v0.8.5 [INFO] [stderr] Compiling derive_builder_core v0.4.1 [INFO] [stderr] Compiling jemallocator v0.1.9 [INFO] [stderr] Compiling rapidquilt v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:162:1 [INFO] [stdout] | [INFO] [stdout] 162 | / /// Parses filename as-is included in the patch, delimited by first whitespace. Returns byte slice [INFO] [stdout] 163 | | /// of the path as-is in the input data. [INFO] [stdout] | |_---------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:168:1 [INFO] [stdout] | [INFO] [stdout] 168 | / /// Parses a quoted filename that may contain escaped characters. Returns owned buffer with the [INFO] [stdout] 169 | | /// unescaped filename. [INFO] [stdout] 170 | | /// Similar to `parse_c_string` function in patch. [INFO] [stdout] | |_-------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:213:1 [INFO] [stdout] | [INFO] [stdout] 213 | / /// Parses a filename. [INFO] [stdout] 214 | | /// [INFO] [stdout] 215 | | /// Either written directly without any whitespace or inside quotation marks. [INFO] [stdout] 216 | | /// [INFO] [stdout] 217 | | /// Similar to `parse_name` function in patch. [INFO] [stdout] | |_---------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:471:1 [INFO] [stdout] | [INFO] [stdout] 471 | /// Parses line and count like "3,4" or just "3" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:505:1 [INFO] [stdout] | [INFO] [stdout] 505 | /// Parses the line like "@@ -3,4 +5,6 @@ function\n" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/libpatch/patch/mod.rs:262:34 [INFO] [stdout] | [INFO] [stdout] 262 | HunkPosition::End => (modified_file.content.len() as isize - remove_content.len() as isize), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 262 - HunkPosition::End => (modified_file.content.len() as isize - remove_content.len() as isize), [INFO] [stdout] 262 + HunkPosition::End => modified_file.content.len() as isize - remove_content.len() as isize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:60:23 [INFO] [stdout] | [INFO] [stdout] 60 | analyses: Vec>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 60 | analyses: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/multiapply.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | fn boxed_clone(&self) -> Box { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | fn boxed_clone(&self) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:28:34 [INFO] [stdout] | [INFO] [stdout] 28 | fn boxed_clone(&self) -> Box; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | fn boxed_clone(&self) -> Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/multiapply.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | _fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 43 | _fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:52:29 [INFO] [stdout] | [INFO] [stdout] 52 | _fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 52 | _fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:618:37 [INFO] [stdout] | [INFO] [stdout] 618 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 618 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:649:42 [INFO] [stdout] | [INFO] [stdout] 649 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 649 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:754:40 [INFO] [stdout] | [INFO] [stdout] 754 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 754 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:84:28 [INFO] [stdout] | [INFO] [stdout] 84 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 84 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:112:38 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn fn_analysis_note_noop(_note: &Note, _modified_filepatch: &TextFilePatch) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 112 | pub fn fn_analysis_note_noop(_note: &dyn Note, _modified_filepatch: &TextFilePatch) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn add(&mut self, analysis: Box) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | pub fn add(&mut self, analysis: Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Fail, PartialEq)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ParseError` [INFO] [stdout] 20 | pub enum ParseError { [INFO] [stdout] | ---------- `ParseError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Fail, PartialEq)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ParseError` [INFO] [stdout] 20 | pub enum ParseError { [INFO] [stdout] | ---------- `ParseError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:580:24 [INFO] [stdout] | [INFO] [stdout] 580 | named!(parse_hunk_line, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ----- the lifetimes get resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | the lifetimes get resolved as `'_` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 580 | named!(parse_hunk_line, (HunkLineType, &[u8])>, [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:649:44 [INFO] [stdout] | [INFO] [stdout] 649 | fn parse_hunk<'a>(input: CompleteByteSlice<'a>) -> IResult> { [INFO] [stdout] | ^^ ----------------- -- the lifetimes get resolved as `'a` [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'a` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 649 | fn parse_hunk<'a>(input: CompleteByteSlice<'a>) -> IResult, TextHunk<'a>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:777:27 [INFO] [stdout] | [INFO] [stdout] 777 | fn parse_hunks(mut input: CompleteByteSlice) -> IResult> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ----------------- --------------- [INFO] [stdout] | | | | | [INFO] [stdout] | | | | the lifetimes get resolved as `'_` [INFO] [stdout] | | | the lifetimes get resolved as `'_` [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 777 | fn parse_hunks(mut input: CompleteByteSlice<'_>) -> IResult, HunksVec<'_, &[u8]>> { [INFO] [stdout] | ++++ ++++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:955:53 [INFO] [stdout] | [INFO] [stdout] 955 | fn parse_filepatch<'a>(mut input: CompleteByteSlice<'a>, mut want_header: bool) [INFO] [stdout] | ^^ this lifetime flows to the output [INFO] [stdout] 956 | -> IResult, TextFilePatch<'a>)> [INFO] [stdout] | ----------------- -- -- the lifetimes get resolved as `'a` [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'a` [INFO] [stdout] | the lifetimes get resolved as `'a` [INFO] [stdout] | [INFO] [stdout] help: one option is to consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 956 | -> IResult, (Vec<&'a [u8]>, TextFilePatch<'a>)> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:1399:27 [INFO] [stdout] | [INFO] [stdout] 1399 | pub fn parse_patch(bytes: &[u8], strip: usize, mut wants_header: bool) -> Result { [INFO] [stdout] | ^^^^^ this lifetime flows to the output --------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 1399 | pub fn parse_patch(bytes: &[u8], strip: usize, mut wants_header: bool) -> Result, Error> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/apply/common.rs:354:42 [INFO] [stdout] | [INFO] [stdout] 354 | fn_analysis_note: &'fn_analysis_note Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 354 | fn_analysis_note: &'fn_analysis_note dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/apply/diagnostics.rs:414:58 [INFO] [stdout] | [INFO] [stdout] 414 | pub fn print_analysis_note(patch_filename: &Path, note: &Note, file_patch: &TextFilePatch) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 414 | pub fn print_analysis_note(patch_filename: &Path, note: &dyn Note, file_patch: &TextFilePatch) -> Result<(), io::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/main.rs:262:39 [INFO] [stdout] | [INFO] [stdout] 262 | fn build_arena(use_mmap: bool) -> Box { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 262 | fn build_arena(use_mmap: bool) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/apply/sequential.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 58 | let fn_analysis_note = |note: &Note, file_patch: &TextFilePatch| { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | let fn_analysis_note = |note: &dyn Note, file_patch: &TextFilePatch| { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/apply/parallel.rs:212:40 [INFO] [stdout] | [INFO] [stdout] 212 | let fn_analysis_note = |note: &Note, file_patch: &TextFilePatch| { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 212 | let fn_analysis_note = |note: &dyn Note, file_patch: &TextFilePatch| { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/rapidquilt/apply/parallel.rs:236:59 [INFO] [stdout] | [INFO] [stdout] 236 | current = earliest_broken_patch_index.compare_and_swap(current, index, Ordering::AcqRel); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/rapidquilt/apply/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ApplyError` [INFO] [stdout] 75 | pub enum ApplyError { [INFO] [stdout] | ---------- `ApplyError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/rapidquilt/apply/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ApplyError` [INFO] [stdout] 75 | pub enum ApplyError { [INFO] [stdout] | ---------- `ApplyError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 19s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: fs_extra v1.1.0, nom v4.2.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "bf908f333f5de6a2ae0a4a38d74eeb1fe11b79562d197e612da8c5ae37224e50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf908f333f5de6a2ae0a4a38d74eeb1fe11b79562d197e612da8c5ae37224e50", kill_on_drop: false }` [INFO] [stdout] bf908f333f5de6a2ae0a4a38d74eeb1fe11b79562d197e612da8c5ae37224e50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eea15d5475069c3ef791f10c2c6b5af2ee421ef2da1e680ecce1cba46243983b" "/opt/rustwide/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59858634c1be42e2cb7e1335cf5b90573be58715e38062bf42aefb860c61d468 [INFO] running `Command { std: "docker" "start" "-a" "59858634c1be42e2cb7e1335cf5b90573be58715e38062bf42aefb860c61d468", kill_on_drop: false }` [INFO] [stderr] Compiling rapidquilt v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:162:1 [INFO] [stdout] | [INFO] [stdout] 162 | / /// Parses filename as-is included in the patch, delimited by first whitespace. Returns byte slice [INFO] [stdout] 163 | | /// of the path as-is in the input data. [INFO] [stdout] | |_---------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:168:1 [INFO] [stdout] | [INFO] [stdout] 168 | / /// Parses a quoted filename that may contain escaped characters. Returns owned buffer with the [INFO] [stdout] 169 | | /// unescaped filename. [INFO] [stdout] 170 | | /// Similar to `parse_c_string` function in patch. [INFO] [stdout] | |_-------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:213:1 [INFO] [stdout] | [INFO] [stdout] 213 | / /// Parses a filename. [INFO] [stdout] 214 | | /// [INFO] [stdout] 215 | | /// Either written directly without any whitespace or inside quotation marks. [INFO] [stdout] 216 | | /// [INFO] [stdout] 217 | | /// Similar to `parse_name` function in patch. [INFO] [stdout] | |_---------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:471:1 [INFO] [stdout] | [INFO] [stdout] 471 | /// Parses line and count like "3,4" or just "3" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:505:1 [INFO] [stdout] | [INFO] [stdout] 505 | /// Parses the line like "@@ -3,4 +5,6 @@ function\n" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/libpatch/patch/mod.rs:262:34 [INFO] [stdout] | [INFO] [stdout] 262 | HunkPosition::End => (modified_file.content.len() as isize - remove_content.len() as isize), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 262 - HunkPosition::End => (modified_file.content.len() as isize - remove_content.len() as isize), [INFO] [stdout] 262 + HunkPosition::End => modified_file.content.len() as isize - remove_content.len() as isize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:60:23 [INFO] [stdout] | [INFO] [stdout] 60 | analyses: Vec>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 60 | analyses: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/multiapply.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | fn boxed_clone(&self) -> Box { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | fn boxed_clone(&self) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:28:34 [INFO] [stdout] | [INFO] [stdout] 28 | fn boxed_clone(&self) -> Box; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | fn boxed_clone(&self) -> Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/multiapply.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | _fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 43 | _fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:52:29 [INFO] [stdout] | [INFO] [stdout] 52 | _fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 52 | _fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:618:37 [INFO] [stdout] | [INFO] [stdout] 618 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 618 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:649:42 [INFO] [stdout] | [INFO] [stdout] 649 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 649 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:754:40 [INFO] [stdout] | [INFO] [stdout] 754 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 754 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:84:28 [INFO] [stdout] | [INFO] [stdout] 84 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 84 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:112:38 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn fn_analysis_note_noop(_note: &Note, _modified_filepatch: &TextFilePatch) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 112 | pub fn fn_analysis_note_noop(_note: &dyn Note, _modified_filepatch: &TextFilePatch) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn add(&mut self, analysis: Box) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | pub fn add(&mut self, analysis: Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Fail, PartialEq)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ParseError` [INFO] [stdout] 20 | pub enum ParseError { [INFO] [stdout] | ---------- `ParseError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Fail, PartialEq)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ParseError` [INFO] [stdout] 20 | pub enum ParseError { [INFO] [stdout] | ---------- `ParseError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:580:24 [INFO] [stdout] | [INFO] [stdout] 580 | named!(parse_hunk_line, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ----- the lifetimes get resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | the lifetimes get resolved as `'_` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 580 | named!(parse_hunk_line, (HunkLineType, &[u8])>, [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:649:44 [INFO] [stdout] | [INFO] [stdout] 649 | fn parse_hunk<'a>(input: CompleteByteSlice<'a>) -> IResult> { [INFO] [stdout] | ^^ ----------------- -- the lifetimes get resolved as `'a` [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'a` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 649 | fn parse_hunk<'a>(input: CompleteByteSlice<'a>) -> IResult, TextHunk<'a>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:777:27 [INFO] [stdout] | [INFO] [stdout] 777 | fn parse_hunks(mut input: CompleteByteSlice) -> IResult> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ----------------- --------------- [INFO] [stdout] | | | | | [INFO] [stdout] | | | | the lifetimes get resolved as `'_` [INFO] [stdout] | | | the lifetimes get resolved as `'_` [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 777 | fn parse_hunks(mut input: CompleteByteSlice<'_>) -> IResult, HunksVec<'_, &[u8]>> { [INFO] [stdout] | ++++ ++++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:955:53 [INFO] [stdout] | [INFO] [stdout] 955 | fn parse_filepatch<'a>(mut input: CompleteByteSlice<'a>, mut want_header: bool) [INFO] [stdout] | ^^ this lifetime flows to the output [INFO] [stdout] 956 | -> IResult, TextFilePatch<'a>)> [INFO] [stdout] | ----------------- -- -- the lifetimes get resolved as `'a` [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'a` [INFO] [stdout] | the lifetimes get resolved as `'a` [INFO] [stdout] | [INFO] [stdout] help: one option is to consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 956 | -> IResult, (Vec<&'a [u8]>, TextFilePatch<'a>)> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:1399:27 [INFO] [stdout] | [INFO] [stdout] 1399 | pub fn parse_patch(bytes: &[u8], strip: usize, mut wants_header: bool) -> Result { [INFO] [stdout] | ^^^^^ this lifetime flows to the output --------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 1399 | pub fn parse_patch(bytes: &[u8], strip: usize, mut wants_header: bool) -> Result, Error> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/apply/common.rs:354:42 [INFO] [stdout] | [INFO] [stdout] 354 | fn_analysis_note: &'fn_analysis_note Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 354 | fn_analysis_note: &'fn_analysis_note dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:162:1 [INFO] [stdout] | [INFO] [stdout] 162 | / /// Parses filename as-is included in the patch, delimited by first whitespace. Returns byte slice [INFO] [stdout] 163 | | /// of the path as-is in the input data. [INFO] [stdout] | |_---------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/apply/diagnostics.rs:414:58 [INFO] [stdout] | [INFO] [stdout] 414 | pub fn print_analysis_note(patch_filename: &Path, note: &Note, file_patch: &TextFilePatch) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 414 | pub fn print_analysis_note(patch_filename: &Path, note: &dyn Note, file_patch: &TextFilePatch) -> Result<(), io::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:168:1 [INFO] [stdout] | [INFO] [stdout] 168 | / /// Parses a quoted filename that may contain escaped characters. Returns owned buffer with the [INFO] [stdout] 169 | | /// unescaped filename. [INFO] [stdout] 170 | | /// Similar to `parse_c_string` function in patch. [INFO] [stdout] | |_-------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:213:1 [INFO] [stdout] | [INFO] [stdout] 213 | / /// Parses a filename. [INFO] [stdout] 214 | | /// [INFO] [stdout] 215 | | /// Either written directly without any whitespace or inside quotation marks. [INFO] [stdout] 216 | | /// [INFO] [stdout] 217 | | /// Similar to `parse_name` function in patch. [INFO] [stdout] | |_---------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:471:1 [INFO] [stdout] | [INFO] [stdout] 471 | /// Parses line and count like "3,4" or just "3" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:505:1 [INFO] [stdout] | [INFO] [stdout] 505 | /// Parses the line like "@@ -3,4 +5,6 @@ function\n" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/libpatch/patch/mod.rs:262:34 [INFO] [stdout] | [INFO] [stdout] 262 | HunkPosition::End => (modified_file.content.len() as isize - remove_content.len() as isize), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 262 - HunkPosition::End => (modified_file.content.len() as isize - remove_content.len() as isize), [INFO] [stdout] 262 + HunkPosition::End => modified_file.content.len() as isize - remove_content.len() as isize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/main.rs:262:39 [INFO] [stdout] | [INFO] [stdout] 262 | fn build_arena(use_mmap: bool) -> Box { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 262 | fn build_arena(use_mmap: bool) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/apply/sequential.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 58 | let fn_analysis_note = |note: &Note, file_patch: &TextFilePatch| { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | let fn_analysis_note = |note: &dyn Note, file_patch: &TextFilePatch| { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rapidquilt/apply/parallel.rs:212:40 [INFO] [stdout] | [INFO] [stdout] 212 | let fn_analysis_note = |note: &Note, file_patch: &TextFilePatch| { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 212 | let fn_analysis_note = |note: &dyn Note, file_patch: &TextFilePatch| { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/rapidquilt/apply/parallel.rs:236:59 [INFO] [stdout] | [INFO] [stdout] 236 | current = earliest_broken_patch_index.compare_and_swap(current, index, Ordering::AcqRel); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:60:23 [INFO] [stdout] | [INFO] [stdout] 60 | analyses: Vec>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 60 | analyses: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/multiapply.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | fn boxed_clone(&self) -> Box { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | fn boxed_clone(&self) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:28:34 [INFO] [stdout] | [INFO] [stdout] 28 | fn boxed_clone(&self) -> Box; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | fn boxed_clone(&self) -> Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/multiapply.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | _fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 43 | _fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:52:29 [INFO] [stdout] | [INFO] [stdout] 52 | _fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 52 | _fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:618:37 [INFO] [stdout] | [INFO] [stdout] 618 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 618 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:649:42 [INFO] [stdout] | [INFO] [stdout] 649 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 649 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/patch/mod.rs:754:40 [INFO] [stdout] | [INFO] [stdout] 754 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 754 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:84:28 [INFO] [stdout] | [INFO] [stdout] 84 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 84 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | fn_analysis_note: &Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | fn_analysis_note: &dyn Fn(&dyn Note, &TextFilePatch)) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:112:38 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn fn_analysis_note_noop(_note: &Note, _modified_filepatch: &TextFilePatch) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 112 | pub fn fn_analysis_note_noop(_note: &dyn Note, _modified_filepatch: &TextFilePatch) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libpatch/analysis/mod.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn add(&mut self, analysis: Box) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | pub fn add(&mut self, analysis: Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/rapidquilt/apply/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ApplyError` [INFO] [stdout] 75 | pub enum ApplyError { [INFO] [stdout] | ---------- `ApplyError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/rapidquilt/apply/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ApplyError` [INFO] [stdout] 75 | pub enum ApplyError { [INFO] [stdout] | ---------- `ApplyError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Fail, PartialEq)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ParseError` [INFO] [stdout] 20 | pub enum ParseError { [INFO] [stdout] | ---------- `ParseError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Fail, PartialEq)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ParseError` [INFO] [stdout] 20 | pub enum ParseError { [INFO] [stdout] | ---------- `ParseError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:580:24 [INFO] [stdout] | [INFO] [stdout] 580 | named!(parse_hunk_line, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ----- the lifetimes get resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | the lifetimes get resolved as `'_` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 580 | named!(parse_hunk_line, (HunkLineType, &[u8])>, [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:649:44 [INFO] [stdout] | [INFO] [stdout] 649 | fn parse_hunk<'a>(input: CompleteByteSlice<'a>) -> IResult> { [INFO] [stdout] | ^^ ----------------- -- the lifetimes get resolved as `'a` [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'a` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 649 | fn parse_hunk<'a>(input: CompleteByteSlice<'a>) -> IResult, TextHunk<'a>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:777:27 [INFO] [stdout] | [INFO] [stdout] 777 | fn parse_hunks(mut input: CompleteByteSlice) -> IResult> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ----------------- --------------- [INFO] [stdout] | | | | | [INFO] [stdout] | | | | the lifetimes get resolved as `'_` [INFO] [stdout] | | | the lifetimes get resolved as `'_` [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 777 | fn parse_hunks(mut input: CompleteByteSlice<'_>) -> IResult, HunksVec<'_, &[u8]>> { [INFO] [stdout] | ++++ ++++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:955:53 [INFO] [stdout] | [INFO] [stdout] 955 | fn parse_filepatch<'a>(mut input: CompleteByteSlice<'a>, mut want_header: bool) [INFO] [stdout] | ^^ this lifetime flows to the output [INFO] [stdout] 956 | -> IResult, TextFilePatch<'a>)> [INFO] [stdout] | ----------------- -- -- the lifetimes get resolved as `'a` [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'a` [INFO] [stdout] | the lifetimes get resolved as `'a` [INFO] [stdout] | [INFO] [stdout] help: one option is to consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 956 | -> IResult, (Vec<&'a [u8]>, TextFilePatch<'a>)> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/libpatch/patch/unified/parser.rs:1399:27 [INFO] [stdout] | [INFO] [stdout] 1399 | pub fn parse_patch(bytes: &[u8], strip: usize, mut wants_header: bool) -> Result { [INFO] [stdout] | ^^^^^ this lifetime flows to the output --------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 1399 | pub fn parse_patch(bytes: &[u8], strip: usize, mut wants_header: bool) -> Result, Error> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 3.17s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: fs_extra v1.1.0, nom v4.2.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "59858634c1be42e2cb7e1335cf5b90573be58715e38062bf42aefb860c61d468", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59858634c1be42e2cb7e1335cf5b90573be58715e38062bf42aefb860c61d468", kill_on_drop: false }` [INFO] [stdout] 59858634c1be42e2cb7e1335cf5b90573be58715e38062bf42aefb860c61d468