[INFO] cloning repository https://github.com/d7z-project/ArgsCovert [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/d7z-project/ArgsCovert" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fd7z-project%2FArgsCovert", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fd7z-project%2FArgsCovert'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e515f9fcec2ced2bfdd3666f1e080bb3c9d79e12 [INFO] building d7z-project/ArgsCovert against master#44f415c1d617ebc7b931a243b7b321ef8a6ca47c for pr-142134-abi-ast-error [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fd7z-project%2FArgsCovert" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/d7z-project/ArgsCovert on toolchain 44f415c1d617ebc7b931a243b7b321ef8a6ca47c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/d7z-project/ArgsCovert [INFO] finished tweaking git repo https://github.com/d7z-project/ArgsCovert [INFO] tweaked toml for git repo https://github.com/d7z-project/ArgsCovert written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/d7z-project/ArgsCovert already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_yaml v0.9.11 [INFO] [stderr] Downloaded is_executable v1.0.1 [INFO] [stderr] Downloaded nonblock v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eea15d5475069c3ef791f10c2c6b5af2ee421ef2da1e680ecce1cba46243983b" "/opt/rustwide/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5a1217d750bdbb902c59125be9a05a693e5e194b531f1c315c39bc972371b6f [INFO] running `Command { std: "docker" "start" "-a" "f5a1217d750bdbb902c59125be9a05a693e5e194b531f1c315c39bc972371b6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5a1217d750bdbb902c59125be9a05a693e5e194b531f1c315c39bc972371b6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5a1217d750bdbb902c59125be9a05a693e5e194b531f1c315c39bc972371b6f", kill_on_drop: false }` [INFO] [stdout] f5a1217d750bdbb902c59125be9a05a693e5e194b531f1c315c39bc972371b6f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eea15d5475069c3ef791f10c2c6b5af2ee421ef2da1e680ecce1cba46243983b" "/opt/rustwide/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 935ddc8a2b51a1092bd3f1620ddf8cd977907cd13b57aa89a9f0a00976466117 [INFO] running `Command { std: "docker" "start" "-a" "935ddc8a2b51a1092bd3f1620ddf8cd977907cd13b57aa89a9f0a00976466117", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling os_str_bytes v6.3.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling textwrap v0.15.0 [INFO] [stderr] Compiling termcolor v1.1.3 [INFO] [stderr] Compiling iana-time-zone v0.1.47 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling clap_lex v0.2.4 [INFO] [stderr] Compiling itoa v1.0.3 [INFO] [stderr] Compiling once_cell v1.14.0 [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling unsafe-libyaml v0.2.2 [INFO] [stderr] Compiling ryu v1.0.11 [INFO] [stderr] Compiling is_executable v1.0.1 [INFO] [stderr] Compiling signal-hook v0.3.14 [INFO] [stderr] Compiling aho-corasick v0.7.19 [INFO] [stderr] Compiling signal-hook-registry v1.4.0 [INFO] [stderr] Compiling time v0.1.44 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling nonblock v0.2.0 [INFO] [stderr] Compiling chrono v0.4.22 [INFO] [stderr] Compiling regex v1.6.0 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Compiling clap v3.2.20 [INFO] [stderr] Compiling serde_yaml v0.9.11 [INFO] [stderr] Compiling args-tools v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:48:1 [INFO] [stdout] | [INFO] [stdout] 48 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:211:14 [INFO] [stdout] | [INFO] [stdout] 211 | for x in health_check { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 211 - for x in health_check { [INFO] [stdout] 211 + while let Some(x) = health_check { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 211 - for x in health_check { [INFO] [stdout] 211 + if let Some(x) = health_check { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:216:14 [INFO] [stdout] | [INFO] [stdout] 216 | for x in started_check { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 216 - for x in started_check { [INFO] [stdout] 216 + while let Some(x) = started_check { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 216 - for x in started_check { [INFO] [stdout] 216 + if let Some(x) = started_check { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/command.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | let output = Command::new(worker.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/command.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | Some(String::from_utf8_lossy(&output.stdout).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 43 - for x in [INFO] [stdout] 43 + while let Some(x) = Some(String::from_utf8_lossy(&output.stdout).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 43 - for x in [INFO] [stdout] 43 + if let Some(x) = Some(String::from_utf8_lossy(&output.stdout).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/command.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | Some(String::from_utf8_lossy(&output.stderr).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 48 - for x in [INFO] [stdout] 48 + while let Some(x) = Some(String::from_utf8_lossy(&output.stderr).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 48 - for x in [INFO] [stdout] 48 + if let Some(x) = Some(String::from_utf8_lossy(&output.stderr).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/utils/log.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 85 | if let Some(data) = &LOG_INFO { [INFO] [stdout] | ^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 85 | if let Some(data) = &raw const LOG_INFO { [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/log.rs:95:34 [INFO] [stdout] | [INFO] [stdout] 95 | for mut x in &data.error_file_path { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 95 - for mut x in &data.error_file_path { [INFO] [stdout] 95 + while let Some(mut x) = &data.error_file_path { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 95 - for mut x in &data.error_file_path { [INFO] [stdout] 95 + if let Some(mut x) = &data.error_file_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/log.rs:99:34 [INFO] [stdout] | [INFO] [stdout] 99 | for mut x in &data.file_path { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 99 - for mut x in &data.file_path { [INFO] [stdout] 99 + while let Some(mut x) = &data.file_path { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 99 - for mut x in &data.file_path { [INFO] [stdout] 99 + if let Some(mut x) = &data.file_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/log.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 127 | for x in &file_path { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 127 - for x in &file_path { [INFO] [stdout] 127 + while let Some(x) = &file_path { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 127 - for x in &file_path { [INFO] [stdout] 127 + if let Some(x) = &file_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/log.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | for x in &error_file_path { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 133 - for x in &error_file_path { [INFO] [stdout] 133 + while let Some(x) = &error_file_path { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 133 - for x in &error_file_path { [INFO] [stdout] 133 + if let Some(x) = &error_file_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/binary_worker.rs:129:30 [INFO] [stdout] | [INFO] [stdout] 129 | for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 130 | | .filter(|e| e.trim().is_empty().not()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 129 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 129 + while let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 129 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 129 + if let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/binary_worker.rs:167:30 [INFO] [stdout] | [INFO] [stdout] 167 | for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 168 | | .filter(|e| e.trim().is_empty().not()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 167 - for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] 167 + while let Some(x) = Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 167 - for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] 167 + if let Some(x) = Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/binary_worker.rs:172:30 [INFO] [stdout] | [INFO] [stdout] 172 | for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 173 | | .filter(|e| e.trim().is_empty().not()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 172 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 172 + while let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 172 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 172 + if let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/script_worker.rs:134:26 [INFO] [stdout] | [INFO] [stdout] 134 | for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | __________________________^ [INFO] [stdout] 135 | | .filter(|e| e.is_empty().not()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 134 - for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] 134 + while let Some(x) = Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 134 - for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] 134 + if let Some(x) = Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/script_worker.rs:142:26 [INFO] [stdout] | [INFO] [stdout] 142 | for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | __________________________^ [INFO] [stdout] 143 | | .filter(|e| e.is_empty().not()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 142 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 142 + while let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 142 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 142 + if let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.76s [INFO] running `Command { std: "docker" "inspect" "935ddc8a2b51a1092bd3f1620ddf8cd977907cd13b57aa89a9f0a00976466117", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "935ddc8a2b51a1092bd3f1620ddf8cd977907cd13b57aa89a9f0a00976466117", kill_on_drop: false }` [INFO] [stdout] 935ddc8a2b51a1092bd3f1620ddf8cd977907cd13b57aa89a9f0a00976466117 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eea15d5475069c3ef791f10c2c6b5af2ee421ef2da1e680ecce1cba46243983b" "/opt/rustwide/cargo-home/bin/cargo" "+44f415c1d617ebc7b931a243b7b321ef8a6ca47c" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1572ca88acec3a5a61dda365a08118e96d16c9794be89413c0605c50bd5f0962 [INFO] running `Command { std: "docker" "start" "-a" "1572ca88acec3a5a61dda365a08118e96d16c9794be89413c0605c50bd5f0962", kill_on_drop: false }` [INFO] [stderr] Compiling args-tools v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:48:1 [INFO] [stdout] | [INFO] [stdout] 48 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:211:14 [INFO] [stdout] | [INFO] [stdout] 211 | for x in health_check { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 211 - for x in health_check { [INFO] [stdout] 211 + while let Some(x) = health_check { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 211 - for x in health_check { [INFO] [stdout] 211 + if let Some(x) = health_check { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:216:14 [INFO] [stdout] | [INFO] [stdout] 216 | for x in started_check { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 216 - for x in started_check { [INFO] [stdout] 216 + while let Some(x) = started_check { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 216 - for x in started_check { [INFO] [stdout] 216 + if let Some(x) = started_check { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/command.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | let output = Command::new(worker.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/command.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | Some(String::from_utf8_lossy(&output.stdout).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 43 - for x in [INFO] [stdout] 43 + while let Some(x) = Some(String::from_utf8_lossy(&output.stdout).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 43 - for x in [INFO] [stdout] 43 + if let Some(x) = Some(String::from_utf8_lossy(&output.stdout).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/command.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | Some(String::from_utf8_lossy(&output.stderr).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 48 - for x in [INFO] [stdout] 48 + while let Some(x) = Some(String::from_utf8_lossy(&output.stderr).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 48 - for x in [INFO] [stdout] 48 + if let Some(x) = Some(String::from_utf8_lossy(&output.stderr).to_string()).filter(|e| e.is_empty().not()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/utils/log.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 85 | if let Some(data) = &LOG_INFO { [INFO] [stdout] | ^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 85 | if let Some(data) = &raw const LOG_INFO { [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/log.rs:95:34 [INFO] [stdout] | [INFO] [stdout] 95 | for mut x in &data.error_file_path { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 95 - for mut x in &data.error_file_path { [INFO] [stdout] 95 + while let Some(mut x) = &data.error_file_path { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 95 - for mut x in &data.error_file_path { [INFO] [stdout] 95 + if let Some(mut x) = &data.error_file_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/log.rs:99:34 [INFO] [stdout] | [INFO] [stdout] 99 | for mut x in &data.file_path { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 99 - for mut x in &data.file_path { [INFO] [stdout] 99 + while let Some(mut x) = &data.file_path { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 99 - for mut x in &data.file_path { [INFO] [stdout] 99 + if let Some(mut x) = &data.file_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/log.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 127 | for x in &file_path { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 127 - for x in &file_path { [INFO] [stdout] 127 + while let Some(x) = &file_path { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 127 - for x in &file_path { [INFO] [stdout] 127 + if let Some(x) = &file_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/log.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | for x in &error_file_path { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 133 - for x in &error_file_path { [INFO] [stdout] 133 + while let Some(x) = &error_file_path { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 133 - for x in &error_file_path { [INFO] [stdout] 133 + if let Some(x) = &error_file_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/binary_worker.rs:129:30 [INFO] [stdout] | [INFO] [stdout] 129 | for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 130 | | .filter(|e| e.trim().is_empty().not()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 129 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 129 + while let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 129 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 129 + if let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/binary_worker.rs:167:30 [INFO] [stdout] | [INFO] [stdout] 167 | for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 168 | | .filter(|e| e.trim().is_empty().not()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 167 - for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] 167 + while let Some(x) = Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 167 - for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] 167 + if let Some(x) = Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/binary_worker.rs:172:30 [INFO] [stdout] | [INFO] [stdout] 172 | for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 173 | | .filter(|e| e.trim().is_empty().not()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 172 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 172 + while let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 172 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 172 + if let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/script_worker.rs:134:26 [INFO] [stdout] | [INFO] [stdout] 134 | for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | __________________________^ [INFO] [stdout] 135 | | .filter(|e| e.is_empty().not()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 134 - for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] 134 + while let Some(x) = Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 134 - for x in Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] 134 + if let Some(x) = Some(String::from_utf8_lossy(&data.stdout).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/worker/script_worker.rs:142:26 [INFO] [stdout] | [INFO] [stdout] 142 | for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | __________________________^ [INFO] [stdout] 143 | | .filter(|e| e.is_empty().not()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 142 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 142 + while let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 142 - for x in Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] 142 + if let Some(x) = Some(String::from_utf8_lossy(&data.stderr).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 1.50s [INFO] running `Command { std: "docker" "inspect" "1572ca88acec3a5a61dda365a08118e96d16c9794be89413c0605c50bd5f0962", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1572ca88acec3a5a61dda365a08118e96d16c9794be89413c0605c50bd5f0962", kill_on_drop: false }` [INFO] [stdout] 1572ca88acec3a5a61dda365a08118e96d16c9794be89413c0605c50bd5f0962