[INFO] cloning repository https://github.com/wbjohnston/gameboy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wbjohnston/gameboy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwbjohnston%2Fgameboy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwbjohnston%2Fgameboy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7b941701ef8a8b59bc8a87c03a7799433d9fd0c7 [INFO] checking wbjohnston/gameboy against master#18a029cfe8e761533634bda8fe8a14e30280a21b for pr-139646 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwbjohnston%2Fgameboy" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/wbjohnston/gameboy on toolchain 18a029cfe8e761533634bda8fe8a14e30280a21b [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+18a029cfe8e761533634bda8fe8a14e30280a21b" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/wbjohnston/gameboy [INFO] finished tweaking git repo https://github.com/wbjohnston/gameboy [INFO] tweaked toml for git repo https://github.com/wbjohnston/gameboy written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/wbjohnston/gameboy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+18a029cfe8e761533634bda8fe8a14e30280a21b" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quickcheck_macros v0.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0b074c097205a61b89e8ad263052f976b2b332c4dc5f02aef1fe52501660d6e" "/opt/rustwide/cargo-home/bin/cargo" "+18a029cfe8e761533634bda8fe8a14e30280a21b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 367637acb7d48c0a292cafd760a6ed2f99e80c35a39b5559c8325dbce00ad54f [INFO] running `Command { std: "docker" "start" "-a" "367637acb7d48c0a292cafd760a6ed2f99e80c35a39b5559c8325dbce00ad54f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "367637acb7d48c0a292cafd760a6ed2f99e80c35a39b5559c8325dbce00ad54f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "367637acb7d48c0a292cafd760a6ed2f99e80c35a39b5559c8325dbce00ad54f", kill_on_drop: false }` [INFO] [stdout] 367637acb7d48c0a292cafd760a6ed2f99e80c35a39b5559c8325dbce00ad54f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0b074c097205a61b89e8ad263052f976b2b332c4dc5f02aef1fe52501660d6e" "/opt/rustwide/cargo-home/bin/cargo" "+18a029cfe8e761533634bda8fe8a14e30280a21b" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6454daf44e69b0c4c969f203f5e745a2119735812a69f59c595b12c858653f20 [INFO] running `Command { std: "docker" "start" "-a" "6454daf44e69b0c4c969f203f5e745a2119735812a69f59c595b12c858653f20", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling serde v1.0.103 [INFO] [stderr] Compiling cc v1.0.47 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling rayon-core v1.6.1 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-queue v0.2.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand_xoshiro v0.3.1 [INFO] [stderr] Checking rand_os v0.2.2 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking criterion-plot v0.4.0 [INFO] [stderr] Checking rayon v1.2.1 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.103 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking quickcheck v0.9.0 [INFO] [stderr] Checking serde_json v1.0.42 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Compiling derivative v1.0.3 [INFO] [stderr] Compiling quickcheck_macros v0.8.0 [INFO] [stderr] Checking gameboy v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.3.0 [INFO] [stdout] warning: unused variable: `mmu` [INFO] [stdout] --> src/ppu.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn step(&mut self, mmu: &mut MMU, n_cycles: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mmu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n_cycles` [INFO] [stdout] --> src/ppu.rs:15:41 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn step(&mut self, mmu: &mut MMU, n_cycles: u8) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_n_cycles` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge.rs:31:26 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn read_ram(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/util.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn set_bit(target: u16, n: u8, value: bool) -> u16 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_n_flag`, `n_flag`, and `h_flag` are never used [INFO] [stdout] --> src/cpu.rs:1145:6 [INFO] [stdout] | [INFO] [stdout] 19 | impl CPU { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1145 | fn get_n_flag(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1174 | fn n_flag(&self) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1178 | fn h_flag(&self) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cartridge` [INFO] [stdout] --> src/bin/debugger.rs:47:7 [INFO] [stdout] | [INFO] [stdout] 47 | let cartridge = { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cartridge` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/bin/debugger.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_AppError` [INFO] [stdout] 22 | enum AppError { [INFO] [stdout] | -------- `AppError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/bin/debugger.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_AppError` [INFO] [stdout] 22 | enum AppError { [INFO] [stdout] | -------- `AppError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/bin/debugger.rs:86:15 [INFO] [stdout] | [INFO] [stdout] 86 | [n] if n.clone().chars().all(char::is_numeric) => { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cartridge` [INFO] [stdout] --> src/bin/debugger.rs:47:7 [INFO] [stdout] | [INFO] [stdout] 47 | let cartridge = { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cartridge` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/bin/debugger.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_AppError` [INFO] [stdout] 22 | enum AppError { [INFO] [stdout] | -------- `AppError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/bin/debugger.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_AppError` [INFO] [stdout] 22 | enum AppError { [INFO] [stdout] | -------- `AppError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/bin/debugger.rs:86:15 [INFO] [stdout] | [INFO] [stdout] 86 | [n] if n.clone().chars().all(char::is_numeric) => { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mmu` [INFO] [stdout] --> src/ppu.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn step(&mut self, mmu: &mut MMU, n_cycles: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mmu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n_cycles` [INFO] [stdout] --> src/ppu.rs:15:41 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn step(&mut self, mmu: &mut MMU, n_cycles: u8) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_n_cycles` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge.rs:31:26 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn read_ram(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/util.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn set_bit(target: u16, n: u8, value: bool) -> u16 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_n_flag`, `n_flag`, and `h_flag` are never used [INFO] [stdout] --> src/cpu.rs:1145:6 [INFO] [stdout] | [INFO] [stdout] 19 | impl CPU { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1145 | fn get_n_flag(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1174 | fn n_flag(&self) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1178 | fn h_flag(&self) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.43s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.3.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "6454daf44e69b0c4c969f203f5e745a2119735812a69f59c595b12c858653f20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6454daf44e69b0c4c969f203f5e745a2119735812a69f59c595b12c858653f20", kill_on_drop: false }` [INFO] [stdout] 6454daf44e69b0c4c969f203f5e745a2119735812a69f59c595b12c858653f20