[INFO] cloning repository https://github.com/rohankumardubey/wickdb [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rohankumardubey/wickdb" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frohankumardubey%2Fwickdb", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frohankumardubey%2Fwickdb'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b8e4c6f6a1f284efab49974dd983fff3b3a48383 [INFO] checking rohankumardubey/wickdb against master#bca37a20bd376ce3fd138e7cdee7fe704e0f8814 for pr-139493-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frohankumardubey%2Fwickdb" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/rohankumardubey/wickdb [INFO] finished tweaking git repo https://github.com/rohankumardubey/wickdb [INFO] tweaked toml for git repo https://github.com/rohankumardubey/wickdb written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rohankumardubey/wickdb on toolchain bca37a20bd376ce3fd138e7cdee7fe704e0f8814 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bca37a20bd376ce3fd138e7cdee7fe704e0f8814" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rohankumardubey/wickdb already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bca37a20bd376ce3fd138e7cdee7fe704e0f8814" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-derive v0.3.0 [INFO] [stderr] Downloaded crossbeam-channel v0.4.0 [INFO] [stderr] Downloaded rand_os v0.2.2 [INFO] [stderr] Downloaded rand_xoshiro v0.3.1 [INFO] [stderr] Downloaded criterion-plot v0.4.0 [INFO] [stderr] Downloaded slog v2.5.2 [INFO] [stderr] Downloaded term v0.6.1 [INFO] [stderr] Downloaded criterion v0.3.0 [INFO] [stderr] Downloaded tinytemplate v1.0.3 [INFO] [stderr] Downloaded syn v1.0.13 [INFO] [stderr] Downloaded slog-term v2.5.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.7 [INFO] [stderr] Downloaded slog-async v2.4.0 [INFO] [stderr] Downloaded bstr v0.2.9 [INFO] [stderr] Downloaded csv v1.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:aa71247004a7fa38d13ec170f48f06cdedf5bc50b2a8645e56ed7e992e6fa513" "/opt/rustwide/cargo-home/bin/cargo" "+bca37a20bd376ce3fd138e7cdee7fe704e0f8814" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 55b41a5e545f1ee0d82524cb53278b56fb5c358fa9919927abd9d3369ba73313 [INFO] running `Command { std: "docker" "start" "-a" "55b41a5e545f1ee0d82524cb53278b56fb5c358fa9919927abd9d3369ba73313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "55b41a5e545f1ee0d82524cb53278b56fb5c358fa9919927abd9d3369ba73313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55b41a5e545f1ee0d82524cb53278b56fb5c358fa9919927abd9d3369ba73313", kill_on_drop: false }` [INFO] [stdout] 55b41a5e545f1ee0d82524cb53278b56fb5c358fa9919927abd9d3369ba73313 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:aa71247004a7fa38d13ec170f48f06cdedf5bc50b2a8645e56ed7e992e6fa513" "/opt/rustwide/cargo-home/bin/cargo" "+bca37a20bd376ce3fd138e7cdee7fe704e0f8814" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4902b25637e000bc7da289c752248d4f2e0331e29eef640d18fe11aec7bf3960 [INFO] running `Command { std: "docker" "start" "-a" "4902b25637e000bc7da289c752248d4f2e0331e29eef640d18fe11aec7bf3960", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.7 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling slog v2.5.2 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Compiling snap v1.0.0 [INFO] [stderr] Checking criterion-plot v0.4.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking slog-async v2.4.0 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking crossbeam-channel v0.4.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand_xoshiro v0.3.1 [INFO] [stderr] Checking rand_os v0.2.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking rayon-core v1.7.0 [INFO] [stderr] Checking slog-term v2.5.0 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking bstr v0.2.9 [INFO] [stderr] Checking serde_json v1.0.44 [INFO] [stderr] Checking csv v1.1.2 [INFO] [stderr] Compiling num-derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking tinytemplate v1.0.3 [INFO] [stderr] Checking wickdb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Slice` is never constructed [INFO] [stdout] --> src/util/slice.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct Slice { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `as_slice`, `is_empty`, `compare`, and `as_str` are never used [INFO] [stdout] --> src/util/slice.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl Slice { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 37 | pub fn new(data: *const u8, size: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn as_slice(&self) -> &[u8] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub fn compare(&self, other: &Slice) -> Ordering { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 61 | pub fn as_str(&self) -> &str { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `micros`, `bytes_read`, and `bytes_written` are never read [INFO] [stdout] --> src/compaction.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 369 | pub struct CompactionStats { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 370 | // The microseconds this compaction takes [INFO] [stdout] 371 | pub micros: u64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 372 | /// The data size read by this compaction [INFO] [stdout] 373 | pub bytes_read: u64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 374 | /// The data size created in new generated SSTables [INFO] [stdout] 375 | pub bytes_written: u64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CompactionStats` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/util/coding.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | let bytes = transmute::(value.to_le()); [INFO] [stdout] | -------------------------^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/util/coding.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | let bytes = transmute::(value.to_le()); [INFO] [stdout] | -------------------------^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u64::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/util/slice.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::slice::Iter` that must be used [INFO] [stdout] --> src/compaction.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | self.base.iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = self.base.iter(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/db/mod.rs:900:28 [INFO] [stdout] | [INFO] [stdout] 900 | fn make_room_for_write(&self, mut force: bool) -> Result>> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 900 | fn make_room_for_write(&self, mut force: bool) -> Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/db/mod.rs:1185:22 [INFO] [stdout] | [INFO] [stdout] 1185 | fn do_compaction(&self, mut c: Compaction) -> Result>> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1185 | fn do_compaction(&self, mut c: Compaction) -> Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/db/format.rs:78:76 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn decode_from(internal_key: &'a [u8]) -> Option> { [INFO] [stdout] | -- the lifetime is named here ^^ the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 78 - pub fn decode_from(internal_key: &'a [u8]) -> Option> { [INFO] [stdout] 78 + pub fn decode_from(internal_key: &'a [u8]) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/db/format.rs:96:81 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new(key: &'a [u8], seq: u64, v_type: ValueType) -> ParsedInternalKey<'_> { [INFO] [stdout] | -- the lifetime is named here ^^ the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 96 - pub fn new(key: &'a [u8], seq: u64, v_type: ValueType) -> ParsedInternalKey<'_> { [INFO] [stdout] 96 + pub fn new(key: &'a [u8], seq: u64, v_type: ValueType) -> ParsedInternalKey<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Option::::map_or` that must be used [INFO] [stdout] --> src/iterator.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | self.derived.as_mut().map_or((), |di| di.next()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the returned value, use `if let` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 234 | let _ = self.derived.as_mut().map_or((), |di| di.next()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Option::::map_or` that must be used [INFO] [stdout] --> src/iterator.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | self.derived.as_mut().map_or((), |di| di.prev()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the returned value, use `if let` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 240 | let _ = self.derived.as_mut().map_or((), |di| di.prev()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/options.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 33 | #[derive(Clone, Copy, Debug, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_CompressionType` [INFO] [stdout] 34 | pub enum CompressionType { [INFO] [stdout] | --------------- `CompressionType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.3.0 [INFO] [stdout] warning: struct `Slice` is never constructed [INFO] [stdout] --> src/util/slice.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct Slice { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `as_slice`, `is_empty`, `compare`, and `as_str` are never used [INFO] [stdout] --> src/util/slice.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl Slice { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 37 | pub fn new(data: *const u8, size: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn as_slice(&self) -> &[u8] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub fn compare(&self, other: &Slice) -> Ordering { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 61 | pub fn as_str(&self) -> &str { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `micros`, `bytes_read`, and `bytes_written` are never read [INFO] [stdout] --> src/compaction.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 369 | pub struct CompactionStats { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 370 | // The microseconds this compaction takes [INFO] [stdout] 371 | pub micros: u64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 372 | /// The data size read by this compaction [INFO] [stdout] 373 | pub bytes_read: u64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 374 | /// The data size created in new generated SSTables [INFO] [stdout] 375 | pub bytes_written: u64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CompactionStats` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/util/coding.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | let bytes = transmute::(value.to_le()); [INFO] [stdout] | -------------------------^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/util/coding.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | let bytes = transmute::(value.to_le()); [INFO] [stdout] | -------------------------^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u64::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/util/slice.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::slice::Iter` that must be used [INFO] [stdout] --> src/compaction.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | self.base.iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = self.base.iter(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/db/mod.rs:900:28 [INFO] [stdout] | [INFO] [stdout] 900 | fn make_room_for_write(&self, mut force: bool) -> Result>> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 900 | fn make_room_for_write(&self, mut force: bool) -> Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/db/mod.rs:1185:22 [INFO] [stdout] | [INFO] [stdout] 1185 | fn do_compaction(&self, mut c: Compaction) -> Result>> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1185 | fn do_compaction(&self, mut c: Compaction) -> Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/db/format.rs:78:76 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn decode_from(internal_key: &'a [u8]) -> Option> { [INFO] [stdout] | -- the lifetime is named here ^^ the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 78 - pub fn decode_from(internal_key: &'a [u8]) -> Option> { [INFO] [stdout] 78 + pub fn decode_from(internal_key: &'a [u8]) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/db/format.rs:96:81 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new(key: &'a [u8], seq: u64, v_type: ValueType) -> ParsedInternalKey<'_> { [INFO] [stdout] | -- the lifetime is named here ^^ the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 96 - pub fn new(key: &'a [u8], seq: u64, v_type: ValueType) -> ParsedInternalKey<'_> { [INFO] [stdout] 96 + pub fn new(key: &'a [u8], seq: u64, v_type: ValueType) -> ParsedInternalKey<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/db/mod.rs:1524:34 [INFO] [stdout] | [INFO] [stdout] 1524 | #[derive(Debug, Clone, Copy, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_TestOption` [INFO] [stdout] 1525 | enum TestOption { [INFO] [stdout] | ---------- `TestOption` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Option::::map_or` that must be used [INFO] [stdout] --> src/iterator.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | self.derived.as_mut().map_or((), |di| di.next()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the returned value, use `if let` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 234 | let _ = self.derived.as_mut().map_or((), |di| di.next()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Option::::map_or` that must be used [INFO] [stdout] --> src/iterator.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | self.derived.as_mut().map_or((), |di| di.prev()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the returned value, use `if let` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 240 | let _ = self.derived.as_mut().map_or((), |di| di.prev()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/options.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 33 | #[derive(Clone, Copy, Debug, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_CompressionType` [INFO] [stdout] 34 | pub enum CompressionType { [INFO] [stdout] | --------------- `CompressionType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.13s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.3.0, snap v1.0.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 15` [INFO] running `Command { std: "docker" "inspect" "4902b25637e000bc7da289c752248d4f2e0331e29eef640d18fe11aec7bf3960", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4902b25637e000bc7da289c752248d4f2e0331e29eef640d18fe11aec7bf3960", kill_on_drop: false }` [INFO] [stdout] 4902b25637e000bc7da289c752248d4f2e0331e29eef640d18fe11aec7bf3960