[INFO] cloning repository https://github.com/LuizMqs/quake-game-log [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LuizMqs/quake-game-log" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuizMqs%2Fquake-game-log", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuizMqs%2Fquake-game-log'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4928caab1760c77d2395bc5c526c034051d23619 [INFO] checking LuizMqs/quake-game-log against master#bca37a20bd376ce3fd138e7cdee7fe704e0f8814 for pr-139493-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuizMqs%2Fquake-game-log" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LuizMqs/quake-game-log [INFO] finished tweaking git repo https://github.com/LuizMqs/quake-game-log [INFO] tweaked toml for git repo https://github.com/LuizMqs/quake-game-log written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LuizMqs/quake-game-log on toolchain bca37a20bd376ce3fd138e7cdee7fe704e0f8814 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bca37a20bd376ce3fd138e7cdee7fe704e0f8814" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LuizMqs/quake-game-log already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bca37a20bd376ce3fd138e7cdee7fe704e0f8814" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror-impl v1.0.49 [INFO] [stderr] Downloaded proc-macro2 v1.0.69 [INFO] [stderr] Downloaded thiserror v1.0.49 [INFO] [stderr] Downloaded eyre v0.6.8 [INFO] [stderr] Downloaded aho-corasick v1.1.1 [INFO] [stderr] Downloaded regex v1.9.6 [INFO] [stderr] Downloaded syn v2.0.38 [INFO] [stderr] Downloaded regex-syntax v0.7.5 [INFO] [stderr] Downloaded regex-automata v0.3.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:aa71247004a7fa38d13ec170f48f06cdedf5bc50b2a8645e56ed7e992e6fa513" "/opt/rustwide/cargo-home/bin/cargo" "+bca37a20bd376ce3fd138e7cdee7fe704e0f8814" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c047ab9130a50b3c72d318d29c181c2e76d146f350742b1298a126c6ea99314d [INFO] running `Command { std: "docker" "start" "-a" "c047ab9130a50b3c72d318d29c181c2e76d146f350742b1298a126c6ea99314d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c047ab9130a50b3c72d318d29c181c2e76d146f350742b1298a126c6ea99314d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c047ab9130a50b3c72d318d29c181c2e76d146f350742b1298a126c6ea99314d", kill_on_drop: false }` [INFO] [stdout] c047ab9130a50b3c72d318d29c181c2e76d146f350742b1298a126c6ea99314d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:aa71247004a7fa38d13ec170f48f06cdedf5bc50b2a8645e56ed7e992e6fa513" "/opt/rustwide/cargo-home/bin/cargo" "+bca37a20bd376ce3fd138e7cdee7fe704e0f8814" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ba01097d4eea91f7929e5286a3b81f17f3b6c0accc2125b2bdca0865110fa23 [INFO] running `Command { std: "docker" "start" "-a" "0ba01097d4eea91f7929e5286a3b81f17f3b6c0accc2125b2bdca0865110fa23", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Checking quake_game_log v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/tournament/tournament_manager.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | for game in &self [INFO] [stdout] | _____________________^ [INFO] [stdout] 27 | | .games [INFO] [stdout] 28 | | .last() [INFO] [stdout] 29 | | .ok_or(TournamentError::TournamentNotStarted) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 26 - for game in &self [INFO] [stdout] 26 + while let Ok(game) = &self [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 26 - for game in &self [INFO] [stdout] 26 + if let Ok(game) = &self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/tournament/tournament_manager.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | for game in &self [INFO] [stdout] | _____________________^ [INFO] [stdout] 27 | | .games [INFO] [stdout] 28 | | .last() [INFO] [stdout] 29 | | .ok_or(TournamentError::TournamentNotStarted) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 26 - for game in &self [INFO] [stdout] 26 + while let Ok(game) = &self [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 26 - for game in &self [INFO] [stdout] 26 + if let Ok(game) = &self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.10s [INFO] running `Command { std: "docker" "inspect" "0ba01097d4eea91f7929e5286a3b81f17f3b6c0accc2125b2bdca0865110fa23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ba01097d4eea91f7929e5286a3b81f17f3b6c0accc2125b2bdca0865110fa23", kill_on_drop: false }` [INFO] [stdout] 0ba01097d4eea91f7929e5286a3b81f17f3b6c0accc2125b2bdca0865110fa23