[INFO] cloning repository https://github.com/lowks/gettingrusty [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lowks/gettingrusty" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flowks%2Fgettingrusty", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flowks%2Fgettingrusty'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6c793a1888c8b5ef702b8ea63e1e91c9084c7e9a [INFO] checking lowks/gettingrusty/6c793a1888c8b5ef702b8ea63e1e91c9084c7e9a against master#518b428304e0008859cb1fd81d1ac20efb2a064a for pr-138961-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flowks%2Fgettingrusty" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lowks/gettingrusty [INFO] finished tweaking git repo https://github.com/lowks/gettingrusty [INFO] tweaked toml for git repo https://github.com/lowks/gettingrusty written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lowks/gettingrusty on toolchain 518b428304e0008859cb1fd81d1ac20efb2a064a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+518b428304e0008859cb1fd81d1ac20efb2a064a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lowks/gettingrusty already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+518b428304e0008859cb1fd81d1ac20efb2a064a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+518b428304e0008859cb1fd81d1ac20efb2a064a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0abe34560e6f64eaf3b81c9a9c896685278fb1981cb332faa6f3010d9c840439 [INFO] running `Command { std: "docker" "start" "-a" "0abe34560e6f64eaf3b81c9a9c896685278fb1981cb332faa6f3010d9c840439", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0abe34560e6f64eaf3b81c9a9c896685278fb1981cb332faa6f3010d9c840439", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0abe34560e6f64eaf3b81c9a9c896685278fb1981cb332faa6f3010d9c840439", kill_on_drop: false }` [INFO] [stdout] 0abe34560e6f64eaf3b81c9a9c896685278fb1981cb332faa6f3010d9c840439 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+518b428304e0008859cb1fd81d1ac20efb2a064a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eeb58f1a8ef757f08f83796a2f959d464d06f2bdab4f9a3b17d8690bfbaa5a03 [INFO] running `Command { std: "docker" "start" "-a" "eeb58f1a8ef757f08f83796a2f959d464d06f2bdab4f9a3b17d8690bfbaa5a03", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Checking gettingrusty v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:32:45 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!("HelloWorld", original_string.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/semicolons.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | 2 * m; [INFO] [stdout] | ^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 13 | let _ = 2 * m; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/functional.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 101 | for x in b.iter() [INFO] [stdout] | __________________^ [INFO] [stdout] 102 | | .max() { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 101 - for x in b.iter() [INFO] [stdout] 101 + while let Some(x) = b.iter() [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 101 - for x in b.iter() [INFO] [stdout] 101 + if let Some(x) = b.iter() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/functional.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | for x in b.iter() [INFO] [stdout] | __________________^ [INFO] [stdout] 107 | | .min() { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 106 - for x in b.iter() [INFO] [stdout] 106 + while let Some(x) = b.iter() [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 106 - for x in b.iter() [INFO] [stdout] 106 + if let Some(x) = b.iter() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:32:45 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!("HelloWorld", original_string.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/semicolons.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | 2 * m; [INFO] [stdout] | ^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 13 | let _ = 2 * m; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/functional.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 101 | for x in b.iter() [INFO] [stdout] | __________________^ [INFO] [stdout] 102 | | .max() { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 101 - for x in b.iter() [INFO] [stdout] 101 + while let Some(x) = b.iter() [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 101 - for x in b.iter() [INFO] [stdout] 101 + if let Some(x) = b.iter() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/functional.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | for x in b.iter() [INFO] [stdout] | __________________^ [INFO] [stdout] 107 | | .min() { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 106 - for x in b.iter() [INFO] [stdout] 106 + while let Some(x) = b.iter() [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 106 - for x in b.iter() [INFO] [stdout] 106 + if let Some(x) = b.iter() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `Command { std: "docker" "inspect" "eeb58f1a8ef757f08f83796a2f959d464d06f2bdab4f9a3b17d8690bfbaa5a03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eeb58f1a8ef757f08f83796a2f959d464d06f2bdab4f9a3b17d8690bfbaa5a03", kill_on_drop: false }` [INFO] [stdout] eeb58f1a8ef757f08f83796a2f959d464d06f2bdab4f9a3b17d8690bfbaa5a03