[INFO] cloning repository https://github.com/flaviu-toader/rbe-ftp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/flaviu-toader/rbe-ftp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflaviu-toader%2Frbe-ftp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflaviu-toader%2Frbe-ftp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9b5cda83ff969699b8775c8cef6a825036d67d6f [INFO] checking flaviu-toader/rbe-ftp against master#068609ce766e55d2e7371cd2a86143a6d7e8e2e4 for pr-138952 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflaviu-toader%2Frbe-ftp" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/flaviu-toader/rbe-ftp on toolchain 068609ce766e55d2e7371cd2a86143a6d7e8e2e4 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+068609ce766e55d2e7371cd2a86143a6d7e8e2e4" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/flaviu-toader/rbe-ftp [INFO] finished tweaking git repo https://github.com/flaviu-toader/rbe-ftp [INFO] tweaked toml for git repo https://github.com/flaviu-toader/rbe-ftp written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/flaviu-toader/rbe-ftp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+068609ce766e55d2e7371cd2a86143a6d7e8e2e4" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4b26683ee3c49f365255c425c23003cbf4366de097804722c29c5bbbee3624d2" "/opt/rustwide/cargo-home/bin/cargo" "+068609ce766e55d2e7371cd2a86143a6d7e8e2e4" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d6a12a20dd21f27270e679928620d70e2f8a9ec0080e241d8db5ee35028d4635 [INFO] running `Command { std: "docker" "start" "-a" "d6a12a20dd21f27270e679928620d70e2f8a9ec0080e241d8db5ee35028d4635", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d6a12a20dd21f27270e679928620d70e2f8a9ec0080e241d8db5ee35028d4635", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6a12a20dd21f27270e679928620d70e2f8a9ec0080e241d8db5ee35028d4635", kill_on_drop: false }` [INFO] [stdout] d6a12a20dd21f27270e679928620d70e2f8a9ec0080e241d8db5ee35028d4635 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4b26683ee3c49f365255c425c23003cbf4366de097804722c29c5bbbee3624d2" "/opt/rustwide/cargo-home/bin/cargo" "+068609ce766e55d2e7371cd2a86143a6d7e8e2e4" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d1d926ba903f3cf63a3680c8b630cc788be281c4e2d732d4ca4609de6342171 [INFO] running `Command { std: "docker" "start" "-a" "9d1d926ba903f3cf63a3680c8b630cc788be281c4e2d732d4ca4609de6342171", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.60 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rbe-ftp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `pb` [INFO] [stdout] --> src/main.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 73 | Command::Cwd(pb) => send_cmd(&mut self.stream, ResultCode::Ok, "Hahahahaha"), [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pb` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pb` [INFO] [stdout] --> src/main.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 73 | Command::Cwd(pb) => send_cmd(&mut self.stream, ResultCode::Ok, "Hahahahaha"), [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pb` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:84:38 [INFO] [stdout] | [INFO] [stdout] 84 | for entry in dir { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 84 - for entry in dir { [INFO] [stdout] 84 + while let Ok(entry) = dir { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 84 - for entry in dir { [INFO] [stdout] 84 + if let Ok(entry) = dir { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:84:38 [INFO] [stdout] | [INFO] [stdout] 84 | for entry in dir { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 84 - for entry in dir { [INFO] [stdout] 84 + while let Ok(entry) = dir { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 84 - for entry in dir { [INFO] [stdout] 84 + if let Ok(entry) = dir { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `Command { std: "docker" "inspect" "9d1d926ba903f3cf63a3680c8b630cc788be281c4e2d732d4ca4609de6342171", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d1d926ba903f3cf63a3680c8b630cc788be281c4e2d732d4ca4609de6342171", kill_on_drop: false }` [INFO] [stdout] 9d1d926ba903f3cf63a3680c8b630cc788be281c4e2d732d4ca4609de6342171