[INFO] cloning repository https://github.com/stephenc/envsub [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/stephenc/envsub" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstephenc%2Fenvsub", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstephenc%2Fenvsub'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 581d65ba82259cf15af3ecde265d336144e07d66 [INFO] checking stephenc/envsub against master#f8c27dfe1a2e7fb538fd91dad53de06992c7c967 for pr-138915 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstephenc%2Fenvsub" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/stephenc/envsub on toolchain f8c27dfe1a2e7fb538fd91dad53de06992c7c967 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f8c27dfe1a2e7fb538fd91dad53de06992c7c967" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/stephenc/envsub [INFO] finished tweaking git repo https://github.com/stephenc/envsub [INFO] tweaked toml for git repo https://github.com/stephenc/envsub written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/stephenc/envsub already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f8c27dfe1a2e7fb538fd91dad53de06992c7c967" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4b26683ee3c49f365255c425c23003cbf4366de097804722c29c5bbbee3624d2" "/opt/rustwide/cargo-home/bin/cargo" "+f8c27dfe1a2e7fb538fd91dad53de06992c7c967" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aaef8aa35beca508d99f77a42cf1054e76d8bc5318aaf8a6ce0df145cafde783 [INFO] running `Command { std: "docker" "start" "-a" "aaef8aa35beca508d99f77a42cf1054e76d8bc5318aaf8a6ce0df145cafde783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aaef8aa35beca508d99f77a42cf1054e76d8bc5318aaf8a6ce0df145cafde783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aaef8aa35beca508d99f77a42cf1054e76d8bc5318aaf8a6ce0df145cafde783", kill_on_drop: false }` [INFO] [stdout] aaef8aa35beca508d99f77a42cf1054e76d8bc5318aaf8a6ce0df145cafde783 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4b26683ee3c49f365255c425c23003cbf4366de097804722c29c5bbbee3624d2" "/opt/rustwide/cargo-home/bin/cargo" "+f8c27dfe1a2e7fb538fd91dad53de06992c7c967" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c0128a5d65d1d4da9e8f845cde37e87b81b3edc9cb19aed0de75f854a8cd95c5 [INFO] running `Command { std: "docker" "start" "-a" "c0128a5d65d1d4da9e8f845cde37e87b81b3edc9cb19aed0de75f854a8cd95c5", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking regex-syntax v0.6.11 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking regex v1.2.1 [INFO] [stderr] Checking envsub v0.1.4-pre (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | Err(f) => panic!(f.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 74 | Err(f) => panic!("{}", f.to_string()), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | Err(f) => panic!(f.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 74 | Err(f) => panic!("{}", f.to_string()), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:179:46 [INFO] [stdout] | [INFO] [stdout] 179 | ... ":-" => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 179 - ":-" => match val.borrow() { [INFO] [stdout] 179 + ":-" => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:189:43 [INFO] [stdout] | [INFO] [stdout] 189 | ... _ => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 189 - _ => match val.borrow() { [INFO] [stdout] 189 + _ => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:194:42 [INFO] [stdout] | [INFO] [stdout] 194 | None => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 194 - None => match val.borrow() { [INFO] [stdout] 194 + None => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:208:52 [INFO] [stdout] | [INFO] [stdout] 208 | .map_or("", |m| m.as_str()) [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 209 | | .clone() [INFO] [stdout] | |________________________________^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:179:46 [INFO] [stdout] | [INFO] [stdout] 179 | ... ":-" => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 179 - ":-" => match val.borrow() { [INFO] [stdout] 179 + ":-" => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:189:43 [INFO] [stdout] | [INFO] [stdout] 189 | ... _ => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 189 - _ => match val.borrow() { [INFO] [stdout] 189 + _ => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:194:42 [INFO] [stdout] | [INFO] [stdout] 194 | None => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 194 - None => match val.borrow() { [INFO] [stdout] 194 + None => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:208:52 [INFO] [stdout] | [INFO] [stdout] 208 | .map_or("", |m| m.as_str()) [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 209 | | .clone() [INFO] [stdout] | |________________________________^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.02s [INFO] running `Command { std: "docker" "inspect" "c0128a5d65d1d4da9e8f845cde37e87b81b3edc9cb19aed0de75f854a8cd95c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0128a5d65d1d4da9e8f845cde37e87b81b3edc9cb19aed0de75f854a8cd95c5", kill_on_drop: false }` [INFO] [stdout] c0128a5d65d1d4da9e8f845cde37e87b81b3edc9cb19aed0de75f854a8cd95c5