[INFO] cloning repository https://github.com/ssihala/RustBoy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ssihala/RustBoy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fssihala%2FRustBoy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fssihala%2FRustBoy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dc040db011c5d4a487680fac0ab11748b3d22dcc [INFO] checking ssihala/RustBoy against master#9c67cecd12d79f1bbc00a74f70e7ef9fff086a5a for pr-138458 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fssihala%2FRustBoy" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ssihala/RustBoy on toolchain 9c67cecd12d79f1bbc00a74f70e7ef9fff086a5a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+9c67cecd12d79f1bbc00a74f70e7ef9fff086a5a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ssihala/RustBoy [INFO] finished tweaking git repo https://github.com/ssihala/RustBoy [INFO] tweaked toml for git repo https://github.com/ssihala/RustBoy written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/ssihala/RustBoy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+9c67cecd12d79f1bbc00a74f70e7ef9fff086a5a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:1680c8fbd8dfb46fcd6d22e546df16ab0e007457dc29fcd9e987cdd5077fd1af" "/opt/rustwide/cargo-home/bin/cargo" "+9c67cecd12d79f1bbc00a74f70e7ef9fff086a5a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9131b58796fc22d7ae0234e8ff8e917e159e18ce6f9dec73aec2e6f17ab1166 [INFO] running `Command { std: "docker" "start" "-a" "e9131b58796fc22d7ae0234e8ff8e917e159e18ce6f9dec73aec2e6f17ab1166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9131b58796fc22d7ae0234e8ff8e917e159e18ce6f9dec73aec2e6f17ab1166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9131b58796fc22d7ae0234e8ff8e917e159e18ce6f9dec73aec2e6f17ab1166", kill_on_drop: false }` [INFO] [stdout] e9131b58796fc22d7ae0234e8ff8e917e159e18ce6f9dec73aec2e6f17ab1166 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:1680c8fbd8dfb46fcd6d22e546df16ab0e007457dc29fcd9e987cdd5077fd1af" "/opt/rustwide/cargo-home/bin/cargo" "+9c67cecd12d79f1bbc00a74f70e7ef9fff086a5a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3cdbee1d5ac18fc19006d153fe4e94ab7422000410848b55e9ccc4a14b36ad2 [INFO] running `Command { std: "docker" "start" "-a" "f3cdbee1d5ac18fc19006d153fe4e94ab7422000410848b55e9ccc4a14b36ad2", kill_on_drop: false }` [INFO] [stderr] Checking rustboy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::borrow::BorrowMut` [INFO] [stdout] --> src/rustboy.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::borrow::BorrowMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/rustboy.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hash::Hash` [INFO] [stdout] --> src/rustboy.rs:3:33 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{collections::HashMap, hash::Hash}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `CPU_Registers` should have an upper camel case name [INFO] [stdout] --> src/rustboy.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct CPU_Registers{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `CpuRegisters` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/rustboy.rs:77:35 [INFO] [stdout] | [INFO] [stdout] 77 | self.flag_register |= (1 << shift_length); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 77 - self.flag_register |= (1 << shift_length); [INFO] [stdout] 77 + self.flag_register |= 1 << shift_length; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::BorrowMut` [INFO] [stdout] --> src/rustboy.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::borrow::BorrowMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/rustboy.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hash::Hash` [INFO] [stdout] --> src/rustboy.rs:3:33 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{collections::HashMap, hash::Hash}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `CPU_Registers` should have an upper camel case name [INFO] [stdout] --> src/rustboy.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct CPU_Registers{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `CpuRegisters` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/rustboy.rs:77:35 [INFO] [stdout] | [INFO] [stdout] 77 | self.flag_register |= (1 << shift_length); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 77 - self.flag_register |= (1 << shift_length); [INFO] [stdout] 77 + self.flag_register |= 1 << shift_length; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/rustboy.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | use super::* ; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_register`, `get_joint_register`, `set_joint_register`, and `get_flag` are never used [INFO] [stdout] --> src/rustboy.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl CPU_Registers{ [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn get_register(&self, key:&str) -> u8{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn get_joint_register(&self, hi:&str, lo:&str) -> u16{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn set_joint_register(&mut self, hi:&str, lo:&str, value:u16){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub fn get_flag(&self, state: &str) -> u8{ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `memory` and `sp` are never read [INFO] [stdout] --> src/rustboy.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 107 | pub struct CPU{ [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 108 | pub registers: CPU_Registers, [INFO] [stdout] 109 | pub memory: [u8; 0xFFFF], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 110 | pub sp: u16 [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `addc`, `addc_hl`, `add_n8`, `add_HL_r16`, `add_HL_SP`, and `add_SP_e8` are never used [INFO] [stdout] --> src/rustboy.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 113 | impl CPU{ [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 134 | pub fn addc(&mut self, operand: u8){ [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | pub fn addc_hl(&mut self){ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 157 | pub fn add_n8(&mut self, immediate_val: u8){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | pub fn add_HL_r16(&mut self, operand: u16){ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 175 | pub fn add_HL_SP(&mut self){ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 184 | pub fn add_SP_e8(&mut self, signed_operand: i8){ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_HL_r16` should have a snake case name [INFO] [stdout] --> src/rustboy.rs:166:12 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn add_HL_r16(&mut self, operand: u16){ [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `add_hl_r16` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_HL_SP` should have a snake case name [INFO] [stdout] --> src/rustboy.rs:175:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn add_HL_SP(&mut self){ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `add_hl_sp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_SP_e8` should have a snake case name [INFO] [stdout] --> src/rustboy.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn add_SP_e8(&mut self, signed_operand: i8){ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `add_sp_e8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_flag` is never used [INFO] [stdout] --> src/rustboy.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl CPU_Registers{ [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 65 | pub fn get_flag(&self, state: &str) -> u8{ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `memory` is never read [INFO] [stdout] --> src/rustboy.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 107 | pub struct CPU{ [INFO] [stdout] | --- field in this struct [INFO] [stdout] 108 | pub registers: CPU_Registers, [INFO] [stdout] 109 | pub memory: [u8; 0xFFFF], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `addc`, `addc_hl`, `add_n8`, and `add_HL_SP` are never used [INFO] [stdout] --> src/rustboy.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 113 | impl CPU{ [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 134 | pub fn addc(&mut self, operand: u8){ [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | pub fn addc_hl(&mut self){ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 157 | pub fn add_n8(&mut self, immediate_val: u8){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 175 | pub fn add_HL_SP(&mut self){ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_HL_r16` should have a snake case name [INFO] [stdout] --> src/rustboy.rs:166:12 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn add_HL_r16(&mut self, operand: u16){ [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `add_hl_r16` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_HL_SP` should have a snake case name [INFO] [stdout] --> src/rustboy.rs:175:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn add_HL_SP(&mut self){ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `add_hl_sp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_SP_e8` should have a snake case name [INFO] [stdout] --> src/rustboy.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn add_SP_e8(&mut self, signed_operand: i8){ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `add_sp_e8` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.11s [INFO] running `Command { std: "docker" "inspect" "f3cdbee1d5ac18fc19006d153fe4e94ab7422000410848b55e9ccc4a14b36ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3cdbee1d5ac18fc19006d153fe4e94ab7422000410848b55e9ccc4a14b36ad2", kill_on_drop: false }` [INFO] [stdout] f3cdbee1d5ac18fc19006d153fe4e94ab7422000410848b55e9ccc4a14b36ad2