[INFO] cloning repository https://github.com/pocketonion/Chip8Emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pocketonion/Chip8Emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocketonion%2FChip8Emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocketonion%2FChip8Emulator'... [INFO] [stderr] /workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocketonion%2FChip8Emulator: No space left on device [WARN] Retrying crate fetch in 3 seconds (attempt 1) [INFO] cloning repository https://github.com/pocketonion/Chip8Emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pocketonion/Chip8Emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocketonion%2FChip8Emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocketonion%2FChip8Emulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 409305cf3c922d855e7b8015f9522d62fe8f344c [INFO] checking pocketonion/Chip8Emulator against master#90384941aae4ea38de00e4702b50757e9b882a19 for pr-138340 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocketonion%2FChip8Emulator" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pocketonion/Chip8Emulator on toolchain 90384941aae4ea38de00e4702b50757e9b882a19 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+90384941aae4ea38de00e4702b50757e9b882a19" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pocketonion/Chip8Emulator [INFO] finished tweaking git repo https://github.com/pocketonion/Chip8Emulator [INFO] tweaked toml for git repo https://github.com/pocketonion/Chip8Emulator written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/pocketonion/Chip8Emulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+90384941aae4ea38de00e4702b50757e9b882a19" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:1680c8fbd8dfb46fcd6d22e546df16ab0e007457dc29fcd9e987cdd5077fd1af" "/opt/rustwide/cargo-home/bin/cargo" "+90384941aae4ea38de00e4702b50757e9b882a19" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9030bf555862336b9d1cf0dc5076a266edadb3f1f26825e83397786429a8d8c [INFO] running `Command { std: "docker" "start" "-a" "e9030bf555862336b9d1cf0dc5076a266edadb3f1f26825e83397786429a8d8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9030bf555862336b9d1cf0dc5076a266edadb3f1f26825e83397786429a8d8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9030bf555862336b9d1cf0dc5076a266edadb3f1f26825e83397786429a8d8c", kill_on_drop: false }` [INFO] [stdout] e9030bf555862336b9d1cf0dc5076a266edadb3f1f26825e83397786429a8d8c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:1680c8fbd8dfb46fcd6d22e546df16ab0e007457dc29fcd9e987cdd5077fd1af" "/opt/rustwide/cargo-home/bin/cargo" "+90384941aae4ea38de00e4702b50757e9b882a19" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c5a24914cca456d5764d8f64782aaa74b758999dda323e20e8529a1f38197cf [INFO] running `Command { std: "docker" "start" "-a" "1c5a24914cca456d5764d8f64782aaa74b758999dda323e20e8529a1f38197cf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking chip8_emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `time` [INFO] [stdout] --> src/main.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{thread, time}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | let a = (self.opcode & 0x0FFF); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - let a = (self.opcode & 0x0FFF); [INFO] [stdout] 104 + let a = self.opcode & 0x0FFF; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:113:18 [INFO] [stdout] | [INFO] [stdout] 113 | let nl:u16 = (self.opcode & 0x0FFF); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 113 - let nl:u16 = (self.opcode & 0x0FFF); [INFO] [stdout] 113 + let nl:u16 = self.opcode & 0x0FFF; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:119:7 [INFO] [stdout] | [INFO] [stdout] 119 | if(self.v[((self.opcode & 0x0F00) >> 8) as usize] == (self.opcode & 0xFF) as u8) //probably broken [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 119 - if(self.v[((self.opcode & 0x0F00) >> 8) as usize] == (self.opcode & 0xFF) as u8) //probably broken [INFO] [stdout] 119 + if self.v[((self.opcode & 0x0F00) >> 8) as usize] == (self.opcode & 0xFF) as u8 //probably broken [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:132:7 [INFO] [stdout] | [INFO] [stdout] 132 | if(self.v[(self.opcode & 0x0F00 >> 8) as usize] != (self.opcode & 0x00FF) as u8) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 132 - if(self.v[(self.opcode & 0x0F00 >> 8) as usize] != (self.opcode & 0x00FF) as u8) [INFO] [stdout] 132 + if self.v[(self.opcode & 0x0F00 >> 8) as usize] != (self.opcode & 0x00FF) as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:145:7 [INFO] [stdout] | [INFO] [stdout] 145 | if(self.v[((self.opcode & 0xF00) >> 8) as usize] == self.v[((self.opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - if(self.v[((self.opcode & 0xF00) >> 8) as usize] == self.v[((self.opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] 145 + if self.v[((self.opcode & 0xF00) >> 8) as usize] == self.v[((self.opcode & 0x00F0) >> 4) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:169:7 [INFO] [stdout] | [INFO] [stdout] 169 | if(((self.v[i] as u16) + (v as u16)) <= 255) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 169 - if(((self.v[i] as u16) + (v as u16)) <= 255) [INFO] [stdout] 169 + if ((self.v[i] as u16) + (v as u16)) <= 255 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/main.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | match (self.opcode & 0x000F) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 183 - match (self.opcode & 0x000F) [INFO] [stdout] 183 + match self.opcode & 0x000F [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | if(self.v[((self.opcode & 0x00F0) >> 4) as usize] > (0xFF - self.v[((self.opcode & 0x0F00) >> 8) as usize])) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 211 - if(self.v[((self.opcode & 0x00F0) >> 4) as usize] > (0xFF - self.v[((self.opcode & 0x0F00) >> 8) as usize])) [INFO] [stdout] 211 + if self.v[((self.opcode & 0x00F0) >> 4) as usize] > (0xFF - self.v[((self.opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 225 | if(self.v[((self.opcode & 0x00F0) >> 4) as usize] > self.v[((self.opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 225 - if(self.v[((self.opcode & 0x00F0) >> 4) as usize] > self.v[((self.opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] 225 + if self.v[((self.opcode & 0x00F0) >> 4) as usize] > self.v[((self.opcode & 0x0F00) >> 8) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:246:14 [INFO] [stdout] | [INFO] [stdout] 246 | self.i = (self.opcode & 0x0FFF); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 246 - self.i = (self.opcode & 0x0FFF); [INFO] [stdout] 246 + self.i = self.opcode & 0x0FFF; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:256:26 [INFO] [stdout] | [INFO] [stdout] 256 | self.v[i as usize] = (n & r); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 256 - self.v[i as usize] = (n & r); [INFO] [stdout] 256 + self.v[i as usize] = n & r; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | if((pixel & (0x80 >> xline)) != 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - if((pixel & (0x80 >> xline)) != 0) [INFO] [stdout] 273 + if (pixel & (0x80 >> xline)) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:275:10 [INFO] [stdout] | [INFO] [stdout] 275 | if(self.gfx[(x + xline + ((y + yline) * 64)) as usize] == 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 275 - if(self.gfx[(x + xline + ((y + yline) * 64)) as usize] == 1) [INFO] [stdout] 275 + if self.gfx[(x + xline + ((y + yline) * 64)) as usize] == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/main.rs:289:11 [INFO] [stdout] | [INFO] [stdout] 289 | match (self.opcode & 0x00FF) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 289 - match (self.opcode & 0x00FF) [INFO] [stdout] 289 + match self.opcode & 0x00FF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | if(self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] != 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 293 - if(self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] != 0) [INFO] [stdout] 293 + if self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | if(self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 304 - if(self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] == 0) [INFO] [stdout] 304 + if self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/main.rs:321:11 [INFO] [stdout] | [INFO] [stdout] 321 | match (self.opcode & 0x00FF) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 321 - match (self.opcode & 0x00FF) [INFO] [stdout] 321 + match self.opcode & 0x00FF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:332:9 [INFO] [stdout] | [INFO] [stdout] 332 | if(((self.i as u16) + (self.v[((self.opcode & 0xF00) >> 8) as usize] as u16) as u16) > 0xFFF) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 332 - if(((self.i as u16) + (self.v[((self.opcode & 0xF00) >> 8) as usize] as u16) as u16) > 0xFFF) [INFO] [stdout] 332 + if ((self.i as u16) + (self.v[((self.opcode & 0xF00) >> 8) as usize] as u16) as u16) > 0xFFF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/main.rs:342:24 [INFO] [stdout] | [INFO] [stdout] 342 | self.i += self.v[(((self.opcode & 0x0F00) >> 8) as usize)] as u16; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 342 - self.i += self.v[(((self.opcode & 0x0F00) >> 8) as usize)] as u16; [INFO] [stdout] 342 + self.i += self.v[((self.opcode & 0x0F00) >> 8) as usize] as u16; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:385:5 [INFO] [stdout] | [INFO] [stdout] 385 | if(self.draw_flag) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 385 - if(self.draw_flag) [INFO] [stdout] 385 + if self.draw_flag [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:391:8 [INFO] [stdout] | [INFO] [stdout] 391 | if(self.gfx[(y*64) + x] == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - if(self.gfx[(y*64) + x] == 0) [INFO] [stdout] 391 + if self.gfx[(y*64) + x] == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/main.rs:416:5 [INFO] [stdout] | [INFO] [stdout] 416 | while true [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time` [INFO] [stdout] --> src/main.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{thread, time}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | let a = (self.opcode & 0x0FFF); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - let a = (self.opcode & 0x0FFF); [INFO] [stdout] 104 + let a = self.opcode & 0x0FFF; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:113:18 [INFO] [stdout] | [INFO] [stdout] 113 | let nl:u16 = (self.opcode & 0x0FFF); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 113 - let nl:u16 = (self.opcode & 0x0FFF); [INFO] [stdout] 113 + let nl:u16 = self.opcode & 0x0FFF; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:119:7 [INFO] [stdout] | [INFO] [stdout] 119 | if(self.v[((self.opcode & 0x0F00) >> 8) as usize] == (self.opcode & 0xFF) as u8) //probably broken [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 119 - if(self.v[((self.opcode & 0x0F00) >> 8) as usize] == (self.opcode & 0xFF) as u8) //probably broken [INFO] [stdout] 119 + if self.v[((self.opcode & 0x0F00) >> 8) as usize] == (self.opcode & 0xFF) as u8 //probably broken [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:132:7 [INFO] [stdout] | [INFO] [stdout] 132 | if(self.v[(self.opcode & 0x0F00 >> 8) as usize] != (self.opcode & 0x00FF) as u8) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 132 - if(self.v[(self.opcode & 0x0F00 >> 8) as usize] != (self.opcode & 0x00FF) as u8) [INFO] [stdout] 132 + if self.v[(self.opcode & 0x0F00 >> 8) as usize] != (self.opcode & 0x00FF) as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:145:7 [INFO] [stdout] | [INFO] [stdout] 145 | if(self.v[((self.opcode & 0xF00) >> 8) as usize] == self.v[((self.opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - if(self.v[((self.opcode & 0xF00) >> 8) as usize] == self.v[((self.opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] 145 + if self.v[((self.opcode & 0xF00) >> 8) as usize] == self.v[((self.opcode & 0x00F0) >> 4) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:169:7 [INFO] [stdout] | [INFO] [stdout] 169 | if(((self.v[i] as u16) + (v as u16)) <= 255) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 169 - if(((self.v[i] as u16) + (v as u16)) <= 255) [INFO] [stdout] 169 + if ((self.v[i] as u16) + (v as u16)) <= 255 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/main.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | match (self.opcode & 0x000F) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 183 - match (self.opcode & 0x000F) [INFO] [stdout] 183 + match self.opcode & 0x000F [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | if(self.v[((self.opcode & 0x00F0) >> 4) as usize] > (0xFF - self.v[((self.opcode & 0x0F00) >> 8) as usize])) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 211 - if(self.v[((self.opcode & 0x00F0) >> 4) as usize] > (0xFF - self.v[((self.opcode & 0x0F00) >> 8) as usize])) [INFO] [stdout] 211 + if self.v[((self.opcode & 0x00F0) >> 4) as usize] > (0xFF - self.v[((self.opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 225 | if(self.v[((self.opcode & 0x00F0) >> 4) as usize] > self.v[((self.opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 225 - if(self.v[((self.opcode & 0x00F0) >> 4) as usize] > self.v[((self.opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] 225 + if self.v[((self.opcode & 0x00F0) >> 4) as usize] > self.v[((self.opcode & 0x0F00) >> 8) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:246:14 [INFO] [stdout] | [INFO] [stdout] 246 | self.i = (self.opcode & 0x0FFF); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 246 - self.i = (self.opcode & 0x0FFF); [INFO] [stdout] 246 + self.i = self.opcode & 0x0FFF; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:256:26 [INFO] [stdout] | [INFO] [stdout] 256 | self.v[i as usize] = (n & r); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 256 - self.v[i as usize] = (n & r); [INFO] [stdout] 256 + self.v[i as usize] = n & r; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | if((pixel & (0x80 >> xline)) != 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - if((pixel & (0x80 >> xline)) != 0) [INFO] [stdout] 273 + if (pixel & (0x80 >> xline)) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:275:10 [INFO] [stdout] | [INFO] [stdout] 275 | if(self.gfx[(x + xline + ((y + yline) * 64)) as usize] == 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 275 - if(self.gfx[(x + xline + ((y + yline) * 64)) as usize] == 1) [INFO] [stdout] 275 + if self.gfx[(x + xline + ((y + yline) * 64)) as usize] == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/main.rs:289:11 [INFO] [stdout] | [INFO] [stdout] 289 | match (self.opcode & 0x00FF) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 289 - match (self.opcode & 0x00FF) [INFO] [stdout] 289 + match self.opcode & 0x00FF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | if(self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] != 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 293 - if(self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] != 0) [INFO] [stdout] 293 + if self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | if(self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 304 - if(self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] == 0) [INFO] [stdout] 304 + if self.key[self.v[((self.opcode & 0x0F00) >> 8) as usize] as usize] == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/main.rs:321:11 [INFO] [stdout] | [INFO] [stdout] 321 | match (self.opcode & 0x00FF) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 321 - match (self.opcode & 0x00FF) [INFO] [stdout] 321 + match self.opcode & 0x00FF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:332:9 [INFO] [stdout] | [INFO] [stdout] 332 | if(((self.i as u16) + (self.v[((self.opcode & 0xF00) >> 8) as usize] as u16) as u16) > 0xFFF) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 332 - if(((self.i as u16) + (self.v[((self.opcode & 0xF00) >> 8) as usize] as u16) as u16) > 0xFFF) [INFO] [stdout] 332 + if ((self.i as u16) + (self.v[((self.opcode & 0xF00) >> 8) as usize] as u16) as u16) > 0xFFF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/main.rs:342:24 [INFO] [stdout] | [INFO] [stdout] 342 | self.i += self.v[(((self.opcode & 0x0F00) >> 8) as usize)] as u16; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 342 - self.i += self.v[(((self.opcode & 0x0F00) >> 8) as usize)] as u16; [INFO] [stdout] 342 + self.i += self.v[((self.opcode & 0x0F00) >> 8) as usize] as u16; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:385:5 [INFO] [stdout] | [INFO] [stdout] 385 | if(self.draw_flag) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 385 - if(self.draw_flag) [INFO] [stdout] 385 + if self.draw_flag [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:391:8 [INFO] [stdout] | [INFO] [stdout] 391 | if(self.gfx[(y*64) + x] == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - if(self.gfx[(y*64) + x] == 0) [INFO] [stdout] 391 + if self.gfx[(y*64) + x] == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/main.rs:416:5 [INFO] [stdout] | [INFO] [stdout] 416 | while true [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::thread::sleep_ms`: replaced by `std::thread::sleep` [INFO] [stdout] --> src/main.rs:422:11 [INFO] [stdout] | [INFO] [stdout] 422 | thread::sleep_ms(1000/30); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::thread::sleep_ms`: replaced by `std::thread::sleep` [INFO] [stdout] --> src/main.rs:422:11 [INFO] [stdout] | [INFO] [stdout] 422 | thread::sleep_ms(1000/30); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pixel` is never read [INFO] [stdout] --> src/main.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | let mut pixel: u16 = 0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pixel` is never read [INFO] [stdout] --> src/main.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | let mut pixel: u16 = 0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:414:10 [INFO] [stdout] | [INFO] [stdout] 414 | let mut t = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:414:10 [INFO] [stdout] | [INFO] [stdout] 414 | let mut t = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:414:6 [INFO] [stdout] | [INFO] [stdout] 414 | let mut t = 0; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:414:6 [INFO] [stdout] | [INFO] [stdout] 414 | let mut t = 0; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sound_timer` is never read [INFO] [stdout] --> src/main.rs:26:2 [INFO] [stdout] | [INFO] [stdout] 11 | struct Chip8 [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 26 | sound_timer: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sound_timer` is never read [INFO] [stdout] --> src/main.rs:26:2 [INFO] [stdout] | [INFO] [stdout] 11 | struct Chip8 [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 26 | sound_timer: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `debug_render` is never used [INFO] [stdout] --> src/main.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 30 | impl Chip8 [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 383 | fn debug_render(&mut self) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `debug_render` is never used [INFO] [stdout] --> src/main.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 30 | impl Chip8 [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 383 | fn debug_render(&mut self) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.03s [INFO] running `Command { std: "docker" "inspect" "1c5a24914cca456d5764d8f64782aaa74b758999dda323e20e8529a1f38197cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c5a24914cca456d5764d8f64782aaa74b758999dda323e20e8529a1f38197cf", kill_on_drop: false }` [INFO] [stdout] 1c5a24914cca456d5764d8f64782aaa74b758999dda323e20e8529a1f38197cf