[INFO] cloning repository https://github.com/kjuulh/toolkit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kjuulh/toolkit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkjuulh%2Ftoolkit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkjuulh%2Ftoolkit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 018393027c99e4819472d605c9ec3648d96d0cef [INFO] checking kjuulh/toolkit against master#4ecd70ddd1039a3954056c1071e40278048476fa for pr-137633 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkjuulh%2Ftoolkit" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/kjuulh/toolkit on toolchain 4ecd70ddd1039a3954056c1071e40278048476fa [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4ecd70ddd1039a3954056c1071e40278048476fa" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/kjuulh/toolkit [INFO] finished tweaking git repo https://github.com/kjuulh/toolkit [INFO] tweaked toml for git repo https://github.com/kjuulh/toolkit written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/kjuulh/toolkit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4ecd70ddd1039a3954056c1071e40278048476fa" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+4ecd70ddd1039a3954056c1071e40278048476fa" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b7e66e669abd981fddb93acd8b4d3025e17a7890361b6720d7d7635cffa2ab5 [INFO] running `Command { std: "docker" "start" "-a" "2b7e66e669abd981fddb93acd8b4d3025e17a7890361b6720d7d7635cffa2ab5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b7e66e669abd981fddb93acd8b4d3025e17a7890361b6720d7d7635cffa2ab5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b7e66e669abd981fddb93acd8b4d3025e17a7890361b6720d7d7635cffa2ab5", kill_on_drop: false }` [INFO] [stdout] 2b7e66e669abd981fddb93acd8b4d3025e17a7890361b6720d7d7635cffa2ab5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+4ecd70ddd1039a3954056c1071e40278048476fa" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 755e0dc0c528b6577b9c6b765eec508d266930704fe4a5d9a6a1931dbef42b89 [INFO] running `Command { std: "docker" "start" "-a" "755e0dc0c528b6577b9c6b765eec508d266930704fe4a5d9a6a1931dbef42b89", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling proc-macro2 v1.0.68 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.0 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Checking util v0.2.0 (/opt/rustwide/workdir/crates/util) [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> crates/util/src/shell.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | drop(stdin); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut ChildStdin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 71 - drop(stdin); [INFO] [stdout] 71 + let _ = stdin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> crates/util/src/shell.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | drop(stdin); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut ChildStdin` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 117 - drop(stdin); [INFO] [stdout] 117 + let _ = stdin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sourcegraph v0.1.0 (/opt/rustwide/workdir/crates/sourcegraph) [INFO] [stderr] Checking tldr v0.2.0 (/opt/rustwide/workdir/crates/tldr) [INFO] [stderr] Checking stats v0.1.0 (/opt/rustwide/workdir/crates/stats) [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> crates/util/src/shell.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | drop(stdin); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut ChildStdin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 71 - drop(stdin); [INFO] [stdout] 71 + let _ = stdin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> crates/util/src/shell.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | drop(stdin); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut ChildStdin` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 117 - drop(stdin); [INFO] [stdout] 117 + let _ = stdin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking comfy-table v6.2.0 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking github v0.2.0 (/opt/rustwide/workdir/crates/github) [INFO] [stderr] Checking gitea v0.2.0 (/opt/rustwide/workdir/crates/gitea) [INFO] [stderr] Checking toolkit v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/prereqs.rs:15:57 [INFO] [stdout] | [INFO] [stdout] 15 | let mut deps: Vec<&str> = DEPS.into_iter().map(|d| d.clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/prereqs.rs:15:57 [INFO] [stdout] | [INFO] [stdout] 15 | let mut deps: Vec<&str> = DEPS.into_iter().map(|d| d.clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> crates/gitea/src/review.rs:320:32 [INFO] [stdout] | [INFO] [stdout] 320 | let snapshot = snapshot.clone().replace("\n", "").replace(" ", ""); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> crates/github/src/review.rs:320:32 [INFO] [stdout] | [INFO] [stdout] 320 | let snapshot = snapshot.clone().replace("\n", "").replace(" ", ""); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.72s [INFO] running `Command { std: "docker" "inspect" "755e0dc0c528b6577b9c6b765eec508d266930704fe4a5d9a6a1931dbef42b89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "755e0dc0c528b6577b9c6b765eec508d266930704fe4a5d9a6a1931dbef42b89", kill_on_drop: false }` [INFO] [stdout] 755e0dc0c528b6577b9c6b765eec508d266930704fe4a5d9a6a1931dbef42b89