[INFO] cloning repository https://github.com/kaulshashank/see [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kaulshashank/see" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkaulshashank%2Fsee", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkaulshashank%2Fsee'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4d5b0fe57ff02c70208f54ed892e312ee43938d6 [INFO] checking kaulshashank/see against master#4ecd70ddd1039a3954056c1071e40278048476fa for pr-137633 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkaulshashank%2Fsee" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/kaulshashank/see on toolchain 4ecd70ddd1039a3954056c1071e40278048476fa [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4ecd70ddd1039a3954056c1071e40278048476fa" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/kaulshashank/see [INFO] finished tweaking git repo https://github.com/kaulshashank/see [INFO] tweaked toml for git repo https://github.com/kaulshashank/see written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/kaulshashank/see already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4ecd70ddd1039a3954056c1071e40278048476fa" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+4ecd70ddd1039a3954056c1071e40278048476fa" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1cbeaf9a1d16a0e329afa7c429bed3d7b788d725f26ef1526599da9829842021 [INFO] running `Command { std: "docker" "start" "-a" "1cbeaf9a1d16a0e329afa7c429bed3d7b788d725f26ef1526599da9829842021", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1cbeaf9a1d16a0e329afa7c429bed3d7b788d725f26ef1526599da9829842021", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cbeaf9a1d16a0e329afa7c429bed3d7b788d725f26ef1526599da9829842021", kill_on_drop: false }` [INFO] [stdout] 1cbeaf9a1d16a0e329afa7c429bed3d7b788d725f26ef1526599da9829842021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+4ecd70ddd1039a3954056c1071e40278048476fa" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 133c17d0a26614072e27c84c6f3c650c323e6a2724a8b3909949323f8ba1c29f [INFO] running `Command { std: "docker" "start" "-a" "133c17d0a26614072e27c84c6f3c650c323e6a2724a8b3909949323f8ba1c29f", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking see v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: value assigned to `path` is never read [INFO] [stdout] --> src/main.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | let mut path = ""; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `isList` should have a snake case name [INFO] [stdout] --> src/main.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | let mut isList = false; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `is_list` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/file_io.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | for e in read_dir_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 12 - for e in read_dir_result { [INFO] [stdout] 12 + while let Ok(e) = read_dir_result { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 12 - for e in read_dir_result { [INFO] [stdout] 12 + if let Ok(e) = read_dir_result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/file_io.rs:14:30 [INFO] [stdout] | [INFO] [stdout] 14 | for dir_entry in ex { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 14 - for dir_entry in ex { [INFO] [stdout] 14 + while let Ok(dir_entry) = ex { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 14 - for dir_entry in ex { [INFO] [stdout] 14 + if let Ok(dir_entry) = ex { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/util/string.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | _str.push_str(strp2.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `path` is never read [INFO] [stdout] --> src/main.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | let mut path = ""; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `isList` should have a snake case name [INFO] [stdout] --> src/main.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | let mut isList = false; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `is_list` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/file_io.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | for e in read_dir_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 12 - for e in read_dir_result { [INFO] [stdout] 12 + while let Ok(e) = read_dir_result { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 12 - for e in read_dir_result { [INFO] [stdout] 12 + if let Ok(e) = read_dir_result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/file_io.rs:14:30 [INFO] [stdout] | [INFO] [stdout] 14 | for dir_entry in ex { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 14 - for dir_entry in ex { [INFO] [stdout] 14 + while let Ok(dir_entry) = ex { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 14 - for dir_entry in ex { [INFO] [stdout] 14 + if let Ok(dir_entry) = ex { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/util/string.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | _str.push_str(strp2.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.01s [INFO] running `Command { std: "docker" "inspect" "133c17d0a26614072e27c84c6f3c650c323e6a2724a8b3909949323f8ba1c29f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "133c17d0a26614072e27c84c6f3c650c323e6a2724a8b3909949323f8ba1c29f", kill_on_drop: false }` [INFO] [stdout] 133c17d0a26614072e27c84c6f3c650c323e6a2724a8b3909949323f8ba1c29f