[INFO] cloning repository https://github.com/pontuslaestadius/goliath [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pontuslaestadius/goliath" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpontuslaestadius%2Fgoliath", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpontuslaestadius%2Fgoliath'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f264ab5bb7a22fd7795673ef07cb671b01a06713 [INFO] checking pontuslaestadius/goliath against master#d8810e3e2dab96778d20dd6d746ff95465515509 for pr-137045 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpontuslaestadius%2Fgoliath" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pontuslaestadius/goliath on toolchain d8810e3e2dab96778d20dd6d746ff95465515509 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+d8810e3e2dab96778d20dd6d746ff95465515509" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pontuslaestadius/goliath [INFO] finished tweaking git repo https://github.com/pontuslaestadius/goliath [INFO] tweaked toml for git repo https://github.com/pontuslaestadius/goliath written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/pontuslaestadius/goliath already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+d8810e3e2dab96778d20dd6d746ff95465515509" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+d8810e3e2dab96778d20dd6d746ff95465515509" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48698f3f472c2547b053a52af43b44b46aa8494caee3ddf769cc83d5f7015050 [INFO] running `Command { std: "docker" "start" "-a" "48698f3f472c2547b053a52af43b44b46aa8494caee3ddf769cc83d5f7015050", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48698f3f472c2547b053a52af43b44b46aa8494caee3ddf769cc83d5f7015050", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48698f3f472c2547b053a52af43b44b46aa8494caee3ddf769cc83d5f7015050", kill_on_drop: false }` [INFO] [stdout] 48698f3f472c2547b053a52af43b44b46aa8494caee3ddf769cc83d5f7015050 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+d8810e3e2dab96778d20dd6d746ff95465515509" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 560b731abd5ed945507960efbd47a85f33cc32c2e6ad56424f3aea74c69f8823 [INFO] running `Command { std: "docker" "start" "-a" "560b731abd5ed945507960efbd47a85f33cc32c2e6ad56424f3aea74c69f8823", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Checking goliath v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut temp_item = Item {key: s, value: get_value(s)}; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `index` is never used [INFO] [stdout] --> src/lib.rs:6:4 [INFO] [stdout] | [INFO] [stdout] 6 | fn index<'a>(string: &'a mut String) -> Vec> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_most_valued_sentence` is never used [INFO] [stdout] --> src/lib.rs:41:4 [INFO] [stdout] | [INFO] [stdout] 41 | fn get_most_valued_sentence<'a>(string: &'a mut String, vec: Vec) -> &'a str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_value` is never used [INFO] [stdout] --> src/lib.rs:70:4 [INFO] [stdout] | [INFO] [stdout] 70 | fn get_value(string: &str) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Item` is never constructed [INFO] [stdout] --> src/lib.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 90 | struct Item<'a> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `increase_value`, `get_value`, and `get_key` are never used [INFO] [stdout] --> src/lib.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 95 | impl<'a> Item<'a> { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] 96 | fn increase_value(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 100 | fn get_value(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 104 | fn get_key(&self) -> &str { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | most_valuable = sentence.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut temp_item = Item {key: s, value: get_value(s)}; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let mut vec = index(&mut string); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | let mut vec = index(&mut string); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | most_valuable = sentence.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s [INFO] running `Command { std: "docker" "inspect" "560b731abd5ed945507960efbd47a85f33cc32c2e6ad56424f3aea74c69f8823", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "560b731abd5ed945507960efbd47a85f33cc32c2e6ad56424f3aea74c69f8823", kill_on_drop: false }` [INFO] [stdout] 560b731abd5ed945507960efbd47a85f33cc32c2e6ad56424f3aea74c69f8823