[INFO] cloning repository https://github.com/fprasx/wordle-analysis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fprasx/wordle-analysis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffprasx%2Fwordle-analysis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffprasx%2Fwordle-analysis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a5943f1a945d0564fa75bd11f86849a3e9ea50ba [INFO] checking fprasx/wordle-analysis against master#a7fc463dd8fbeca800d4b3efc501069502cffe64 for pr-136988 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffprasx%2Fwordle-analysis" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/fprasx/wordle-analysis on toolchain a7fc463dd8fbeca800d4b3efc501069502cffe64 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a7fc463dd8fbeca800d4b3efc501069502cffe64" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/fprasx/wordle-analysis [INFO] finished tweaking git repo https://github.com/fprasx/wordle-analysis [INFO] tweaked toml for git repo https://github.com/fprasx/wordle-analysis written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/fprasx/wordle-analysis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a7fc463dd8fbeca800d4b3efc501069502cffe64" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6475c868a6d27846ca172efb246699580b64b57a5b3744ef73949e850a31b38a" "/opt/rustwide/cargo-home/bin/cargo" "+a7fc463dd8fbeca800d4b3efc501069502cffe64" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6105956e91df906455178d067caa337dc4c220306163a98b634c6e1e07496d86 [INFO] running `Command { std: "docker" "start" "-a" "6105956e91df906455178d067caa337dc4c220306163a98b634c6e1e07496d86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6105956e91df906455178d067caa337dc4c220306163a98b634c6e1e07496d86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6105956e91df906455178d067caa337dc4c220306163a98b634c6e1e07496d86", kill_on_drop: false }` [INFO] [stdout] 6105956e91df906455178d067caa337dc4c220306163a98b634c6e1e07496d86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6475c868a6d27846ca172efb246699580b64b57a5b3744ef73949e850a31b38a" "/opt/rustwide/cargo-home/bin/cargo" "+a7fc463dd8fbeca800d4b3efc501069502cffe64" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0a2bf74846b988e730c8d5dbc2580e0356dcda5683d2df65eb0a2ebd5e2241ad [INFO] running `Command { std: "docker" "start" "-a" "0a2bf74846b988e730c8d5dbc2580e0356dcda5683d2df65eb0a2ebd5e2241ad", kill_on_drop: false }` [INFO] [stderr] Checking wordle v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/freq_ranking/utilities.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | for c in word.chars().nth(index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 24 - for c in word.chars().nth(index) { [INFO] [stdout] 24 + while let Some(c) = word.chars().nth(index) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 24 - for c in word.chars().nth(index) { [INFO] [stdout] 24 + if let Some(c) = word.chars().nth(index) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/freq_ranking/utilities.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | for c in word.chars().nth(index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 24 - for c in word.chars().nth(index) { [INFO] [stdout] 24 + while let Some(c) = word.chars().nth(index) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 24 - for c in word.chars().nth(index) { [INFO] [stdout] 24 + if let Some(c) = word.chars().nth(index) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s [INFO] running `Command { std: "docker" "inspect" "0a2bf74846b988e730c8d5dbc2580e0356dcda5683d2df65eb0a2ebd5e2241ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a2bf74846b988e730c8d5dbc2580e0356dcda5683d2df65eb0a2ebd5e2241ad", kill_on_drop: false }` [INFO] [stdout] 0a2bf74846b988e730c8d5dbc2580e0356dcda5683d2df65eb0a2ebd5e2241ad