[INFO] fetching crate bullet_rs 0.0.1... [INFO] checking bullet_rs-0.0.1 against master#cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9 for pr-136968 [INFO] extracting crate bullet_rs 0.0.1 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate bullet_rs 0.0.1 on toolchain cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bullet_rs 0.0.1 [INFO] finished tweaking crates.io crate bullet_rs 0.0.1 [INFO] tweaked toml for crates.io crate bullet_rs 0.0.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate crates.io crate bullet_rs 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 112fc25e0540544943a4595a968a0e4be97307c46c91195586eb67adc02dae32 [INFO] running `Command { std: "docker" "start" "-a" "112fc25e0540544943a4595a968a0e4be97307c46c91195586eb67adc02dae32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "112fc25e0540544943a4595a968a0e4be97307c46c91195586eb67adc02dae32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "112fc25e0540544943a4595a968a0e4be97307c46c91195586eb67adc02dae32", kill_on_drop: false }` [INFO] [stdout] 112fc25e0540544943a4595a968a0e4be97307c46c91195586eb67adc02dae32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 207cbcac909b9b8ed82c0d20caf047c316294ddca24abdbd5f29b7ca896a4c68 [INFO] running `Command { std: "docker" "start" "-a" "207cbcac909b9b8ed82c0d20caf047c316294ddca24abdbd5f29b7ca896a4c68", kill_on_drop: false }` [INFO] [stderr] Checking bullet_rs v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/bt_vector3.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | fn div(self, rhs: f32) -> Self::Output { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 296 | return self * 1.0 / rhs; [INFO] [stdout] | ---------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/bt_vector3.rs:421:5 [INFO] [stdout] | [INFO] [stdout] 421 | pub fn normalized(&self) -> &BtVector3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] ... [INFO] [stdout] 424 | return nrm.normalized(); [INFO] [stdout] | ---------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/bt_vector3.rs:705:27 [INFO] [stdout] | [INFO] [stdout] 705 | pub fn max_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array_count` [INFO] [stdout] --> src/bt_vector3.rs:705:45 [INFO] [stdout] | [INFO] [stdout] 705 | pub fn max_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_array_count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dot_out` [INFO] [stdout] --> src/bt_vector3.rs:705:63 [INFO] [stdout] | [INFO] [stdout] 705 | pub fn max_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dot_out` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/bt_vector3.rs:714:27 [INFO] [stdout] | [INFO] [stdout] 714 | pub fn min_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array_count` [INFO] [stdout] --> src/bt_vector3.rs:714:45 [INFO] [stdout] | [INFO] [stdout] 714 | pub fn min_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_array_count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dot_out` [INFO] [stdout] --> src/bt_vector3.rs:714:63 [INFO] [stdout] | [INFO] [stdout] 714 | pub fn min_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dot_out` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bt_vector3.rs:422:23 [INFO] [stdout] | [INFO] [stdout] 422 | let nrm = self.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `BtVector3` does not implement `Clone`, so calling `clone` on `&BtVector3` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 422 - let nrm = self.clone(); [INFO] [stdout] 422 + let nrm = self; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `BtVector3`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 120 + #[derive(Clone)] [INFO] [stdout] 121 | pub struct BtVector3 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/bt_vector3.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | fn div(self, rhs: f32) -> Self::Output { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 296 | return self * 1.0 / rhs; [INFO] [stdout] | ---------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/bt_vector3.rs:421:5 [INFO] [stdout] | [INFO] [stdout] 421 | pub fn normalized(&self) -> &BtVector3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] ... [INFO] [stdout] 424 | return nrm.normalized(); [INFO] [stdout] | ---------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/bt_vector3.rs:705:27 [INFO] [stdout] | [INFO] [stdout] 705 | pub fn max_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array_count` [INFO] [stdout] --> src/bt_vector3.rs:705:45 [INFO] [stdout] | [INFO] [stdout] 705 | pub fn max_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_array_count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dot_out` [INFO] [stdout] --> src/bt_vector3.rs:705:63 [INFO] [stdout] | [INFO] [stdout] 705 | pub fn max_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dot_out` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/bt_vector3.rs:714:27 [INFO] [stdout] | [INFO] [stdout] 714 | pub fn min_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array_count` [INFO] [stdout] --> src/bt_vector3.rs:714:45 [INFO] [stdout] | [INFO] [stdout] 714 | pub fn min_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_array_count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dot_out` [INFO] [stdout] --> src/bt_vector3.rs:714:63 [INFO] [stdout] | [INFO] [stdout] 714 | pub fn min_dot(&self, array: BtVector3, array_count: i64, dot_out: &mut BtScalar) -> i64 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dot_out` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bt_vector3.rs:422:23 [INFO] [stdout] | [INFO] [stdout] 422 | let nrm = self.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `BtVector3` does not implement `Clone`, so calling `clone` on `&BtVector3` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 422 - let nrm = self.clone(); [INFO] [stdout] 422 + let nrm = self; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `BtVector3`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 120 + #[derive(Clone)] [INFO] [stdout] 121 | pub struct BtVector3 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `Command { std: "docker" "inspect" "207cbcac909b9b8ed82c0d20caf047c316294ddca24abdbd5f29b7ca896a4c68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "207cbcac909b9b8ed82c0d20caf047c316294ddca24abdbd5f29b7ca896a4c68", kill_on_drop: false }` [INFO] [stdout] 207cbcac909b9b8ed82c0d20caf047c316294ddca24abdbd5f29b7ca896a4c68