[INFO] cloning repository https://github.com/mckinnsb/rusty_z [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mckinnsb/rusty_z" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmckinnsb%2Frusty_z", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmckinnsb%2Frusty_z'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6b1700f8b6c2a8cbff967721435b0cea9dc2191d [INFO] checking mckinnsb/rusty_z against master#cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9 for pr-136968 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmckinnsb%2Frusty_z" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mckinnsb/rusty_z on toolchain cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mckinnsb/rusty_z [INFO] finished tweaking git repo https://github.com/mckinnsb/rusty_z [INFO] tweaked toml for git repo https://github.com/mckinnsb/rusty_z written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/mckinnsb/rusty_z already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded termion v1.5.3 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.55 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.55 [INFO] [stderr] Downloaded ordered-float v0.2.3 [INFO] [stderr] Downloaded unreachable v0.1.1 [INFO] [stderr] Downloaded log-mdc v0.1.0 [INFO] [stderr] Downloaded futures-sink v0.3.1 [INFO] [stderr] Downloaded traitobject v0.1.0 [INFO] [stderr] Downloaded proc-macro-nested v0.1.3 [INFO] [stderr] Downloaded futures-executor v0.3.1 [INFO] [stderr] Downloaded futures-core v0.3.1 [INFO] [stderr] Downloaded futures-io v0.3.1 [INFO] [stderr] Downloaded wasm-bindgen v0.2.55 [INFO] [stderr] Downloaded futures v0.3.1 [INFO] [stderr] Downloaded futures-channel v0.3.1 [INFO] [stderr] Downloaded dtoa v0.3.1 [INFO] [stderr] Downloaded futures-channel-preview v0.3.0-alpha.19 [INFO] [stderr] Downloaded chrono v0.2.25 [INFO] [stderr] Downloaded futures-util v0.3.1 [INFO] [stderr] Downloaded bumpalo v2.6.0 [INFO] [stderr] Downloaded futures-util-preview v0.3.0-alpha.19 [INFO] [stderr] Downloaded syn v1.0.8 [INFO] [stderr] Downloaded serde_derive v1.0.102 [INFO] [stderr] Downloaded serde v1.0.102 [INFO] [stderr] Downloaded serde_json v1.0.41 [INFO] [stderr] Downloaded proc-macro2 v1.0.6 [INFO] [stderr] Downloaded crossbeam v0.2.12 [INFO] [stderr] Downloaded num-traits v0.2.9 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] [stderr] Downloaded log4rs v0.5.2 [INFO] [stderr] Downloaded ryu v1.0.2 [INFO] [stderr] Downloaded num-integer v0.1.41 [INFO] [stderr] Downloaded time v0.1.42 [INFO] [stderr] Downloaded quick-error v1.2.2 [INFO] [stderr] Downloaded autocfg v0.1.7 [INFO] [stderr] Downloaded serde v0.8.23 [INFO] [stderr] Downloaded libc v0.2.65 [INFO] [stderr] Downloaded rand v0.3.23 [INFO] [stderr] Downloaded futures-executor-preview v0.3.0-alpha.19 [INFO] [stderr] Downloaded futures-macro v0.3.1 [INFO] [stderr] Downloaded num-iter v0.1.39 [INFO] [stderr] Downloaded log v0.3.9 [INFO] [stderr] Downloaded itoa v0.4.4 [INFO] [stderr] Downloaded proc-macro-hack v0.5.11 [INFO] [stderr] Downloaded num v0.1.42 [INFO] [stderr] Downloaded linked-hash-map v0.3.0 [INFO] [stderr] Downloaded futures-core-preview v0.3.0-alpha.19 [INFO] [stderr] Downloaded quote v1.0.2 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.55 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.55 [INFO] [stderr] Downloaded futures-task v0.3.1 [INFO] [stderr] Downloaded num_cpus v1.11.1 [INFO] [stderr] Downloaded antidote v1.0.0 [INFO] [stderr] Downloaded serde_test v0.8.23 [INFO] [stderr] Downloaded unsafe-any v0.4.2 [INFO] [stderr] Downloaded hermit-abi v0.1.3 [INFO] [stderr] Downloaded serde-value v0.3.1 [INFO] [stderr] Downloaded typemap v0.3.3 [INFO] [stderr] Downloaded serde_yaml v0.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e895d2e6276649002e60a65dbccf578500d4d4b79b352d6563f58a3015588c2d [INFO] running `Command { std: "docker" "start" "-a" "e895d2e6276649002e60a65dbccf578500d4d4b79b352d6563f58a3015588c2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e895d2e6276649002e60a65dbccf578500d4d4b79b352d6563f58a3015588c2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e895d2e6276649002e60a65dbccf578500d4d4b79b352d6563f58a3015588c2d", kill_on_drop: false }` [INFO] [stdout] e895d2e6276649002e60a65dbccf578500d4d4b79b352d6563f58a3015588c2d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+cfe9ffcd7c2d63fd3e0fc33a8d23ac4f0d50efe9" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c18693d80c77a71e7022143c1fbfd344991b11279fbff0623ccce7edb5459089 [INFO] running `Command { std: "docker" "start" "-a" "c18693d80c77a71e7022143c1fbfd344991b11279fbff0623ccce7edb5459089", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking serde v0.8.23 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking futures-sink v0.3.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking futures-core v0.3.1 [INFO] [stderr] Checking futures-io v0.3.1 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking futures-task v0.3.1 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking futures-channel v0.3.1 [INFO] [stderr] Checking dtoa v0.3.1 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking antidote v1.0.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Compiling num-traits v0.2.9 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking termion v1.5.3 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking ordered-float v0.2.3 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking serde_test v0.8.23 [INFO] [stderr] Checking serde-value v0.3.1 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking serde_yaml v0.5.1 [INFO] [stderr] Checking log4rs v0.5.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Compiling futures-macro v0.3.1 [INFO] [stderr] Checking futures-util v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.1 [INFO] [stderr] Checking futures v0.3.1 [INFO] [stderr] Checking rusty_z v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/interfaces/zinterface.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Copy, Clone, Serialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/zmachine/instruction_set.rs:836:39 [INFO] [stdout] | [INFO] [stdout] 836 | (Some(uhalf), Some(lhalf)) => ((((uhalf as u32) << 16) & 0xFFFF0000) | (lhalf as u32)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 836 - (Some(uhalf), Some(lhalf)) => ((((uhalf as u32) << 16) & 0xFFFF0000) | (lhalf as u32)), [INFO] [stdout] 836 + (Some(uhalf), Some(lhalf)) => (((uhalf as u32) << 16) & 0xFFFF0000) | (lhalf as u32), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/zmachine/memory_view.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | (self.pointer + (offset)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 70 - (self.pointer + (offset)) [INFO] [stdout] 70 + self.pointer + (offset) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/interfaces/zinterface.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Copy, Clone, Serialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/zmachine/instruction_set.rs:836:39 [INFO] [stdout] | [INFO] [stdout] 836 | (Some(uhalf), Some(lhalf)) => ((((uhalf as u32) << 16) & 0xFFFF0000) | (lhalf as u32)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 836 - (Some(uhalf), Some(lhalf)) => ((((uhalf as u32) << 16) & 0xFFFF0000) | (lhalf as u32)), [INFO] [stdout] 836 + (Some(uhalf), Some(lhalf)) => (((uhalf as u32) << 16) & 0xFFFF0000) | (lhalf as u32), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/zmachine/memory_view.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | (self.pointer + (offset)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 70 - (self.pointer + (offset)) [INFO] [stdout] 70 + self.pointer + (offset) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/interfaces/zinterface.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Copy, Clone, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_LoopState` [INFO] [stdout] 6 | #[repr(u8)] [INFO] [stdout] 7 | pub enum LoopState { [INFO] [stdout] | --------- `LoopState` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/interfaces/zinterface.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Copy, Clone, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_LoopState` [INFO] [stdout] 6 | #[repr(u8)] [INFO] [stdout] 7 | pub enum LoopState { [INFO] [stdout] | --------- `LoopState` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.66s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: traitobject v0.1.0, typemap v0.3.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "c18693d80c77a71e7022143c1fbfd344991b11279fbff0623ccce7edb5459089", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c18693d80c77a71e7022143c1fbfd344991b11279fbff0623ccce7edb5459089", kill_on_drop: false }` [INFO] [stdout] c18693d80c77a71e7022143c1fbfd344991b11279fbff0623ccce7edb5459089