[INFO] cloning repository https://github.com/mhn1991/BinaryTree [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mhn1991/BinaryTree" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmhn1991%2FBinaryTree", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmhn1991%2FBinaryTree'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7656902817f6da21bcc0d08e9f5b6266d92d2521 [INFO] checking mhn1991/BinaryTree against master#a5db378dc14a40dd1580c27fb8362156446382c3 for pr-136490 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmhn1991%2FBinaryTree" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mhn1991/BinaryTree on toolchain a5db378dc14a40dd1580c27fb8362156446382c3 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5db378dc14a40dd1580c27fb8362156446382c3" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mhn1991/BinaryTree [INFO] finished tweaking git repo https://github.com/mhn1991/BinaryTree [INFO] tweaked toml for git repo https://github.com/mhn1991/BinaryTree written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/mhn1991/BinaryTree already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5db378dc14a40dd1580c27fb8362156446382c3" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded typed-arena v2.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c80049f3b88b82089a44e0f06d0d6029d44b96b7257e55a1cd63dbc9f4c33334" "/opt/rustwide/cargo-home/bin/cargo" "+a5db378dc14a40dd1580c27fb8362156446382c3" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7218a1e0a01d9504c68236b8492687f7c952e3afe03fafa8de8345c2fc588051 [INFO] running `Command { std: "docker" "start" "-a" "7218a1e0a01d9504c68236b8492687f7c952e3afe03fafa8de8345c2fc588051", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7218a1e0a01d9504c68236b8492687f7c952e3afe03fafa8de8345c2fc588051", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7218a1e0a01d9504c68236b8492687f7c952e3afe03fafa8de8345c2fc588051", kill_on_drop: false }` [INFO] [stdout] 7218a1e0a01d9504c68236b8492687f7c952e3afe03fafa8de8345c2fc588051 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c80049f3b88b82089a44e0f06d0d6029d44b96b7257e55a1cd63dbc9f4c33334" "/opt/rustwide/cargo-home/bin/cargo" "+a5db378dc14a40dd1580c27fb8362156446382c3" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eb483ac42bf51cf0bd2e356b280ab6ad7e36df16b834800f4708333831831f74 [INFO] running `Command { std: "docker" "start" "-a" "eb483ac42bf51cf0bd2e356b280ab6ad7e36df16b834800f4708333831831f74", kill_on_drop: false }` [INFO] [stderr] Checking typed-arena v2.0.0 [INFO] [stderr] Checking BinaryTree v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if (self.left.as_ref().unwrap().left.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - if (self.left.as_ref().unwrap().left.is_none()) { [INFO] [stdout] 67 + if self.left.as_ref().unwrap().left.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if (self.value.unwrap() <= value) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 135 - if (self.value.unwrap() <= value) { [INFO] [stdout] 135 + if self.value.unwrap() <= value { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:136:16 [INFO] [stdout] | [INFO] [stdout] 136 | if (self.right.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 136 - if (self.right.is_none()) { [INFO] [stdout] 136 + if self.right.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 140 | if (self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] | ^ [INFO] [stdout] 141 | && self.right.as_ref().unwrap().left.is_none() [INFO] [stdout] 142 | && self.right.as_ref().unwrap().right.is_none()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 140 ~ if self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] 141 | && self.right.as_ref().unwrap().left.is_none() [INFO] [stdout] 142 ~ && self.right.as_ref().unwrap().right.is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:147:16 [INFO] [stdout] | [INFO] [stdout] 147 | if (self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] | ^ [INFO] [stdout] 148 | && self.right.as_ref().unwrap().right.is_some()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 147 ~ if self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] 148 ~ && self.right.as_ref().unwrap().right.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:155:16 [INFO] [stdout] | [INFO] [stdout] 155 | if (self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] | ^ [INFO] [stdout] 156 | && self.right.as_ref().unwrap().left.is_some()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 155 ~ if self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] 156 ~ && self.right.as_ref().unwrap().left.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if (self.left.as_ref().unwrap().left.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - if (self.left.as_ref().unwrap().left.is_none()) { [INFO] [stdout] 67 + if self.left.as_ref().unwrap().left.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if (self.value.unwrap() <= value) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 135 - if (self.value.unwrap() <= value) { [INFO] [stdout] 135 + if self.value.unwrap() <= value { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:136:16 [INFO] [stdout] | [INFO] [stdout] 136 | if (self.right.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 136 - if (self.right.is_none()) { [INFO] [stdout] 136 + if self.right.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 140 | if (self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] | ^ [INFO] [stdout] 141 | && self.right.as_ref().unwrap().left.is_none() [INFO] [stdout] 142 | && self.right.as_ref().unwrap().right.is_none()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 140 ~ if self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] 141 | && self.right.as_ref().unwrap().left.is_none() [INFO] [stdout] 142 ~ && self.right.as_ref().unwrap().right.is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:147:16 [INFO] [stdout] | [INFO] [stdout] 147 | if (self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] | ^ [INFO] [stdout] 148 | && self.right.as_ref().unwrap().right.is_some()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 147 ~ if self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] 148 ~ && self.right.as_ref().unwrap().right.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:155:16 [INFO] [stdout] | [INFO] [stdout] 155 | if (self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] | ^ [INFO] [stdout] 156 | && self.right.as_ref().unwrap().left.is_some()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 155 ~ if self.right.as_ref().unwrap().value.unwrap() == value [INFO] [stdout] 156 ~ && self.right.as_ref().unwrap().left.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `findMin` should have a snake case name [INFO] [stdout] --> src/main.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | fn findMin(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `find_min` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `findMin` should have a snake case name [INFO] [stdout] --> src/main.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | fn findMin(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `find_min` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `Command { std: "docker" "inspect" "eb483ac42bf51cf0bd2e356b280ab6ad7e36df16b834800f4708333831831f74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb483ac42bf51cf0bd2e356b280ab6ad7e36df16b834800f4708333831831f74", kill_on_drop: false }` [INFO] [stdout] eb483ac42bf51cf0bd2e356b280ab6ad7e36df16b834800f4708333831831f74