[INFO] cloning repository https://github.com/dmschreiber/advent-of-code-2018 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dmschreiber/advent-of-code-2018" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmschreiber%2Fadvent-of-code-2018", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmschreiber%2Fadvent-of-code-2018'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 673173031121af8103c4cab7120cac905265a67d [INFO] checking dmschreiber/advent-of-code-2018 against master#a5db378dc14a40dd1580c27fb8362156446382c3 for pr-136490 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmschreiber%2Fadvent-of-code-2018" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dmschreiber/advent-of-code-2018 on toolchain a5db378dc14a40dd1580c27fb8362156446382c3 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5db378dc14a40dd1580c27fb8362156446382c3" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dmschreiber/advent-of-code-2018 [INFO] finished tweaking git repo https://github.com/dmschreiber/advent-of-code-2018 [INFO] tweaked toml for git repo https://github.com/dmschreiber/advent-of-code-2018 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/dmschreiber/advent-of-code-2018 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5db378dc14a40dd1580c27fb8362156446382c3" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded futures-sink v0.3.10 [INFO] [stderr] Downloaded futures-io v0.3.9 [INFO] [stderr] Downloaded futures-core v0.3.10 [INFO] [stderr] Downloaded futures-macro v0.3.9 [INFO] [stderr] Downloaded futures-task v0.3.10 [INFO] [stderr] Downloaded futures-executor v0.3.9 [INFO] [stderr] Downloaded futures-channel v0.3.10 [INFO] [stderr] Downloaded cached v0.22.0 [INFO] [stderr] Downloaded pathfinding v2.1.1 [INFO] [stderr] Downloaded futures-util v0.3.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c80049f3b88b82089a44e0f06d0d6029d44b96b7257e55a1cd63dbc9f4c33334" "/opt/rustwide/cargo-home/bin/cargo" "+a5db378dc14a40dd1580c27fb8362156446382c3" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e18286ec84d06bc3a6393b5b0e4de4916b0338b4b5759c691e4e354879270841 [INFO] running `Command { std: "docker" "start" "-a" "e18286ec84d06bc3a6393b5b0e4de4916b0338b4b5759c691e4e354879270841", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e18286ec84d06bc3a6393b5b0e4de4916b0338b4b5759c691e4e354879270841", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e18286ec84d06bc3a6393b5b0e4de4916b0338b4b5759c691e4e354879270841", kill_on_drop: false }` [INFO] [stdout] e18286ec84d06bc3a6393b5b0e4de4916b0338b4b5759c691e4e354879270841 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c80049f3b88b82089a44e0f06d0d6029d44b96b7257e55a1cd63dbc9f4c33334" "/opt/rustwide/cargo-home/bin/cargo" "+a5db378dc14a40dd1580c27fb8362156446382c3" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9060cc6354f29e9d3a122fcb88eef7f1485bb04b7a0e85c8477002a8afd077a [INFO] running `Command { std: "docker" "start" "-a" "c9060cc6354f29e9d3a122fcb88eef7f1485bb04b7a0e85c8477002a8afd077a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking pin-project-lite v0.2.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking futures-core v0.3.10 [INFO] [stderr] Checking futures-sink v0.3.10 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Checking futures-io v0.3.9 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling event-listener v2.5.1 [INFO] [stderr] Checking futures-channel v0.3.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Checking bytes v1.0.0 [INFO] [stderr] Compiling cached_proc_macro_types v0.1.0 [INFO] [stderr] Checking futures-task v0.3.10 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking async-mutex v1.4.0 [INFO] [stderr] Compiling tokio v1.0.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking thread_local v1.1.0 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking fixedbitset v0.3.1 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking mio v0.7.7 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking pathfinding v2.1.1 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling futures-macro v0.3.9 [INFO] [stderr] Compiling tokio-macros v1.0.0 [INFO] [stderr] Compiling async-trait v0.1.42 [INFO] [stderr] Checking futures-util v0.3.9 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling cached_proc_macro v0.6.0 [INFO] [stderr] Checking futures-executor v0.3.9 [INFO] [stderr] Checking futures v0.3.8 [INFO] [stderr] Checking cached v0.22.0 [INFO] [stderr] Checking tokio-stream v0.1.1 [INFO] [stderr] Checking tokio-util v0.6.0 [INFO] [stderr] Checking puzzle-base v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle24.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | let mut target_group = groups.get_mut(target_pos).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle24.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | let mut target_group = groups.get_mut(target_pos).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle15.rs:169:7 [INFO] [stdout] | [INFO] [stdout] 169 | let mut target = units.get_mut(target_position).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle15.rs:190:7 [INFO] [stdout] | [INFO] [stdout] 190 | let mut target = units.get_mut(target_position).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle15.rs:169:7 [INFO] [stdout] | [INFO] [stdout] 169 | let mut target = units.get_mut(target_position).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle15.rs:190:7 [INFO] [stdout] | [INFO] [stdout] 190 | let mut target = units.get_mut(target_position).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle9.rs:86:7 [INFO] [stdout] | [INFO] [stdout] 86 | let mut prev = map.get_mut(&prev_marble).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle9.rs:88:7 [INFO] [stdout] | [INFO] [stdout] 88 | let mut next = map.get_mut(&next_marble).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle9.rs:86:7 [INFO] [stdout] | [INFO] [stdout] 86 | let mut prev = map.get_mut(&prev_marble).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle9.rs:88:7 [INFO] [stdout] | [INFO] [stdout] 88 | let mut next = map.get_mut(&next_marble).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/puzzle9.rs:82:40 [INFO] [stdout] | [INFO] [stdout] 82 | let target = map.get(&which).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Marble` does not implement `Clone`, so calling `clone` on `&Marble` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 82 - let target = map.get(&which).unwrap().clone(); [INFO] [stdout] 82 + let target = map.get(&which).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Marble`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub struct Marble { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/puzzle9.rs:82:40 [INFO] [stdout] | [INFO] [stdout] 82 | let target = map.get(&which).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Marble` does not implement `Clone`, so calling `clone` on `&Marble` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 82 - let target = map.get(&which).unwrap().clone(); [INFO] [stdout] 82 + let target = map.get(&which).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Marble`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub struct Marble { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.28s [INFO] running `Command { std: "docker" "inspect" "c9060cc6354f29e9d3a122fcb88eef7f1485bb04b7a0e85c8477002a8afd077a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9060cc6354f29e9d3a122fcb88eef7f1485bb04b7a0e85c8477002a8afd077a", kill_on_drop: false }` [INFO] [stdout] c9060cc6354f29e9d3a122fcb88eef7f1485bb04b7a0e85c8477002a8afd077a