[INFO] cloning repository https://github.com/stianeklund/z80-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/stianeklund/z80-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstianeklund%2Fz80-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstianeklund%2Fz80-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 563f6195c3d2c6e13cdb27e4a9121f8887e1b63d [INFO] checking stianeklund/z80-rs against master#b2728d5426bab1d8c39709768c7e22b7f66dde5d for pr-135852 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstianeklund%2Fz80-rs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/stianeklund/z80-rs on toolchain b2728d5426bab1d8c39709768c7e22b7f66dde5d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b2728d5426bab1d8c39709768c7e22b7f66dde5d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/stianeklund/z80-rs [INFO] finished tweaking git repo https://github.com/stianeklund/z80-rs [INFO] tweaked toml for git repo https://github.com/stianeklund/z80-rs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/stianeklund/z80-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b2728d5426bab1d8c39709768c7e22b7f66dde5d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c80049f3b88b82089a44e0f06d0d6029d44b96b7257e55a1cd63dbc9f4c33334" "/opt/rustwide/cargo-home/bin/cargo" "+b2728d5426bab1d8c39709768c7e22b7f66dde5d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] defebbf2df46d5859ea5e888c0e616d4fff16345f71e53ecec01528f01695746 [INFO] running `Command { std: "docker" "start" "-a" "defebbf2df46d5859ea5e888c0e616d4fff16345f71e53ecec01528f01695746", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "defebbf2df46d5859ea5e888c0e616d4fff16345f71e53ecec01528f01695746", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "defebbf2df46d5859ea5e888c0e616d4fff16345f71e53ecec01528f01695746", kill_on_drop: false }` [INFO] [stdout] defebbf2df46d5859ea5e888c0e616d4fff16345f71e53ecec01528f01695746 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c80049f3b88b82089a44e0f06d0d6029d44b96b7257e55a1cd63dbc9f4c33334" "/opt/rustwide/cargo-home/bin/cargo" "+b2728d5426bab1d8c39709768c7e22b7f66dde5d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e4aeafcc6f12f84a21a9bdf5c2610f9c56240db3e24c37aa2997d0bca3f7ff7 [INFO] running `Command { std: "docker" "start" "-a" "8e4aeafcc6f12f84a21a9bdf5c2610f9c56240db3e24c37aa2997d0bca3f7ff7", kill_on_drop: false }` [INFO] [stderr] Checking z80-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/cpu.rs:349:19 [INFO] [stdout] | [INFO] [stdout] 349 | AF => ((self.reg.a as u16) << 8 | (self.flags.get() as u16)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 349 - AF => ((self.reg.a as u16) << 8 | (self.flags.get() as u16)), [INFO] [stdout] 349 + AF => (self.reg.a as u16) << 8 | (self.flags.get() as u16), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Cpu` and `Registers` [INFO] [stdout] --> src/memory.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::{Cpu, Registers}; [INFO] [stdout] | ^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/cpu.rs:349:19 [INFO] [stdout] | [INFO] [stdout] 349 | AF => ((self.reg.a as u16) << 8 | (self.flags.get() as u16)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 349 - AF => ((self.reg.a as u16) << 8 | (self.flags.get() as u16)), [INFO] [stdout] 349 + AF => (self.reg.a as u16) << 8 | (self.flags.get() as u16), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IXH` [INFO] [stdout] --> src/cpu_tests.rs:4:61 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::instruction_info::Register::{BC, DE, HL, IX, IXH, IY, R, SP}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Cpu` and `Registers` [INFO] [stdout] --> src/memory.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::{Cpu, Registers}; [INFO] [stdout] | ^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `overflow` [INFO] [stdout] --> src/cpu.rs:967:13 [INFO] [stdout] | [INFO] [stdout] 967 | let overflow = (self.reg.a as i8).overflowing_sub(value as i8).1; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_overflow` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `overflow` [INFO] [stdout] --> src/cpu.rs:1610:13 [INFO] [stdout] | [INFO] [stdout] 1610 | let overflow = (self.reg.a as i8).overflowing_sub(value as i8).1; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_overflow` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `overflow` [INFO] [stdout] --> src/cpu.rs:1663:13 [INFO] [stdout] | [INFO] [stdout] 1663 | let overflow = (self.reg.a as i8).overflowing_sub(value as i8).1; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_overflow` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `overflow` [INFO] [stdout] --> src/cpu.rs:1924:13 [INFO] [stdout] | [INFO] [stdout] 1924 | let overflow = 0_i8.overflowing_sub(value as i8).1; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_overflow` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `overflow` [INFO] [stdout] --> src/cpu.rs:967:13 [INFO] [stdout] | [INFO] [stdout] 967 | let overflow = (self.reg.a as i8).overflowing_sub(value as i8).1; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_overflow` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `overflow` [INFO] [stdout] --> src/cpu.rs:1610:13 [INFO] [stdout] | [INFO] [stdout] 1610 | let overflow = (self.reg.a as i8).overflowing_sub(value as i8).1; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_overflow` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `overflow` [INFO] [stdout] --> src/cpu.rs:1663:13 [INFO] [stdout] | [INFO] [stdout] 1663 | let overflow = (self.reg.a as i8).overflowing_sub(value as i8).1; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_overflow` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `overflow` [INFO] [stdout] --> src/cpu.rs:1924:13 [INFO] [stdout] | [INFO] [stdout] 1924 | let overflow = 0_i8.overflowing_sub(value as i8).1; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_overflow` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `output` is never read [INFO] [stdout] --> src/cpu.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 56 | pub struct Io { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 60 | output: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `debug_decode` is never used [INFO] [stdout] --> src/interconnect.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 9 | impl Interconnect { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 44 | fn debug_decode(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/cpu.rs:307:25 [INFO] [stdout] | [INFO] [stdout] 307 | _ => panic!(format!( [INFO] [stdout] | _________________________^ [INFO] [stdout] 308 | | "Writing to RP: {:#?}, is not supported by write_reg, called by: {}, opcode:{:02X}{:02X}", [INFO] [stdout] 309 | | dst, self.current_instruction, self.opcode, self.next_opcode [INFO] [stdout] 310 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 307 ~ _ => panic!( [INFO] [stdout] 308 | "Writing to RP: {:#?}, is not supported by write_reg, called by: {}, opcode:{:02X}{:02X}", [INFO] [stdout] 309 | dst, self.current_instruction, self.opcode, self.next_opcode [INFO] [stdout] 310 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/cpu.rs:2840:63 [INFO] [stdout] | [INFO] [stdout] 2840 | _ => panic!("Unknown or unimplemented instruction:{:#?}"), // Instruction::decode(self) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 2840 | _ => panic!("Unknown or unimplemented instruction:{:#?}", ...), // Instruction::decode(self) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 2840 | _ => panic!("{}", "Unknown or unimplemented instruction:{:#?}"), // Instruction::decode(self) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Formatter::<'a>::align` that must be used [INFO] [stdout] --> src/formatter.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | fmt.align(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 21 | let _ = fmt.align(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Formatter::<'a>::align` that must be used [INFO] [stdout] --> src/formatter.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | fmt.align(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 45 | let _ = fmt.align(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Formatter::<'a>::align` that must be used [INFO] [stdout] --> src/instruction_info.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | fmt.align(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 24 | let _ = fmt.align(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `output` is never read [INFO] [stdout] --> src/cpu.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 56 | pub struct Io { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 60 | output: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `all_tests` is never used [INFO] [stdout] --> src/cpu_tests.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | fn all_tests() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `debug_decode` is never used [INFO] [stdout] --> src/interconnect.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 9 | impl Interconnect { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 44 | fn debug_decode(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/cpu.rs:307:25 [INFO] [stdout] | [INFO] [stdout] 307 | _ => panic!(format!( [INFO] [stdout] | _________________________^ [INFO] [stdout] 308 | | "Writing to RP: {:#?}, is not supported by write_reg, called by: {}, opcode:{:02X}{:02X}", [INFO] [stdout] 309 | | dst, self.current_instruction, self.opcode, self.next_opcode [INFO] [stdout] 310 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 307 ~ _ => panic!( [INFO] [stdout] 308 | "Writing to RP: {:#?}, is not supported by write_reg, called by: {}, opcode:{:02X}{:02X}", [INFO] [stdout] 309 | dst, self.current_instruction, self.opcode, self.next_opcode [INFO] [stdout] 310 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/cpu.rs:2840:63 [INFO] [stdout] | [INFO] [stdout] 2840 | _ => panic!("Unknown or unimplemented instruction:{:#?}"), // Instruction::decode(self) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 2840 | _ => panic!("Unknown or unimplemented instruction:{:#?}", ...), // Instruction::decode(self) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 2840 | _ => panic!("{}", "Unknown or unimplemented instruction:{:#?}"), // Instruction::decode(self) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Formatter::<'a>::align` that must be used [INFO] [stdout] --> src/formatter.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | fmt.align(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 21 | let _ = fmt.align(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Formatter::<'a>::align` that must be used [INFO] [stdout] --> src/formatter.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | fmt.align(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 45 | let _ = fmt.align(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Formatter::<'a>::align` that must be used [INFO] [stdout] --> src/instruction_info.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | fmt.align(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 24 | let _ = fmt.align(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `Command { std: "docker" "inspect" "8e4aeafcc6f12f84a21a9bdf5c2610f9c56240db3e24c37aa2997d0bca3f7ff7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e4aeafcc6f12f84a21a9bdf5c2610f9c56240db3e24c37aa2997d0bca3f7ff7", kill_on_drop: false }` [INFO] [stdout] 8e4aeafcc6f12f84a21a9bdf5c2610f9c56240db3e24c37aa2997d0bca3f7ff7