[INFO] cloning repository https://github.com/io3dev/space-invaders-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'... [INFO] [stderr] /workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator: No space left on device [WARN] Retrying crate fetch in 3 seconds (attempt 1) [INFO] cloning repository https://github.com/io3dev/space-invaders-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'... [INFO] [stderr] error: copy-fd: write returned: No space left on device [INFO] [stderr] fatal: cannot copy '/usr/share/git-core/templates/hooks/pre-commit.sample' to '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator/hooks/pre-commit.sample': No space left on device [WARN] Retrying crate fetch in 3 seconds (attempt 2) [INFO] cloning repository https://github.com/io3dev/space-invaders-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'... [INFO] [stderr] error: copy-fd: write returned: No space left on device [INFO] [stderr] fatal: cannot copy '/usr/share/git-core/templates/hooks/pre-push.sample' to '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator/hooks/pre-push.sample': No space left on device [WARN] Retrying crate fetch in 3 seconds (attempt 3) [INFO] cloning repository https://github.com/io3dev/space-invaders-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'... [INFO] [stderr] /workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator: No space left on device [WARN] Retrying crate fetch in 3 seconds (attempt 4) [INFO] cloning repository https://github.com/io3dev/space-invaders-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'... [INFO] [stderr] /workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator: No space left on device [WARN] Retrying crate fetch in 3 seconds (attempt 5) [INFO] cloning repository https://github.com/io3dev/space-invaders-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'... [INFO] [stderr] /workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator: No space left on device [WARN] Retrying crate fetch in 3 seconds (attempt 6) [INFO] cloning repository https://github.com/io3dev/space-invaders-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'... [INFO] [stderr] /workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator: No space left on device [WARN] Retrying crate fetch in 3 seconds (attempt 7) [INFO] cloning repository https://github.com/io3dev/space-invaders-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0efa547e46ad6da3d427f698bd4e9dccc90080cf [INFO] checking io3dev/space-invaders-emulator against try#173780a87744406b7489b28349c0176f14bb3881 for pr-135841 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] error: copy-fd: write returned: No space left on device [INFO] [stderr] fatal: cannot copy '/usr/share/git-core/templates/hooks/pre-merge-commit.sample' to '/workspace/builds/worker-7-tc2/source/.git/hooks/pre-merge-commit.sample': No space left on device [INFO] checking io3dev/space-invaders-emulator against try#173780a87744406b7489b28349c0176f14bb3881 for pr-135841 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/io3dev/space-invaders-emulator on toolchain 173780a87744406b7489b28349c0176f14bb3881 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+173780a87744406b7489b28349c0176f14bb3881" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/io3dev/space-invaders-emulator [INFO] finished tweaking git repo https://github.com/io3dev/space-invaders-emulator [INFO] tweaked toml for git repo https://github.com/io3dev/space-invaders-emulator written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/io3dev/space-invaders-emulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+173780a87744406b7489b28349c0176f14bb3881" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c80049f3b88b82089a44e0f06d0d6029d44b96b7257e55a1cd63dbc9f4c33334" "/opt/rustwide/cargo-home/bin/cargo" "+173780a87744406b7489b28349c0176f14bb3881" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e71301f8b0a9dd61c5fded670cc426fb4e46356332791bbb82773d5051e3494 [INFO] running `Command { std: "docker" "start" "-a" "7e71301f8b0a9dd61c5fded670cc426fb4e46356332791bbb82773d5051e3494", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e71301f8b0a9dd61c5fded670cc426fb4e46356332791bbb82773d5051e3494", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e71301f8b0a9dd61c5fded670cc426fb4e46356332791bbb82773d5051e3494", kill_on_drop: false }` [INFO] [stdout] 7e71301f8b0a9dd61c5fded670cc426fb4e46356332791bbb82773d5051e3494 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c80049f3b88b82089a44e0f06d0d6029d44b96b7257e55a1cd63dbc9f4c33334" "/opt/rustwide/cargo-home/bin/cargo" "+173780a87744406b7489b28349c0176f14bb3881" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 134b289fb7020b09e886428856bcbee9cf37608287de2d3a46349ba69c554b91 [INFO] running `Command { std: "docker" "start" "-a" "134b289fb7020b09e886428856bcbee9cf37608287de2d3a46349ba69c554b91", kill_on_drop: false }` [INFO] [stderr] Checking space_invaders v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:481:35 [INFO] [stdout] | [INFO] [stdout] 481 | self.flags.zero = (0x01 == (psw & 0x01)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 481 - self.flags.zero = (0x01 == (psw & 0x01)); [INFO] [stdout] 481 + self.flags.zero = 0x01 == (psw & 0x01); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:482:35 [INFO] [stdout] | [INFO] [stdout] 482 | self.flags.sign = (0x02 == (psw & 0x02)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 482 - self.flags.sign = (0x02 == (psw & 0x02)); [INFO] [stdout] 482 + self.flags.sign = 0x02 == (psw & 0x02); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:483:37 [INFO] [stdout] | [INFO] [stdout] 483 | self.flags.parity = (0x04 == (psw & 0x04)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 483 - self.flags.parity = (0x04 == (psw & 0x04)); [INFO] [stdout] 483 + self.flags.parity = 0x04 == (psw & 0x04); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:484:37 [INFO] [stdout] | [INFO] [stdout] 484 | self.flags.carry = (0x05 == (psw & 0x08)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 484 - self.flags.carry = (0x05 == (psw & 0x08)); [INFO] [stdout] 484 + self.flags.carry = 0x05 == (psw & 0x08); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:485:40 [INFO] [stdout] | [INFO] [stdout] 485 | self.flags.aux_carry = (0x10 == (psw & 0x10)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 485 - self.flags.aux_carry = (0x10 == (psw & 0x10)); [INFO] [stdout] 485 + self.flags.aux_carry = 0x10 == (psw & 0x10); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:525:36 [INFO] [stdout] | [INFO] [stdout] 525 | self.flags.carry = (1 == (x&1)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 525 - self.flags.carry = (1 == (x&1)); [INFO] [stdout] 525 + self.flags.carry = 1 == (x&1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:589:12 [INFO] [stdout] | [INFO] [stdout] 589 | if (condition == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 589 - if (condition == true) { [INFO] [stdout] 589 + if condition == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:602:12 [INFO] [stdout] | [INFO] [stdout] 602 | if (condition == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 602 - if (condition == true) { [INFO] [stdout] 602 + if condition == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:830:28 [INFO] [stdout] | [INFO] [stdout] 830 | self.flags.carry = (r1 > 0xff); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 830 - self.flags.carry = (r1 > 0xff); [INFO] [stdout] 830 + self.flags.carry = r1 > 0xff; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:844:28 [INFO] [stdout] | [INFO] [stdout] 844 | self.flags.carry = (r1 > 0xff); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 844 - self.flags.carry = (r1 > 0xff); [INFO] [stdout] 844 + self.flags.carry = r1 > 0xff; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:856:28 [INFO] [stdout] | [INFO] [stdout] 856 | self.flags.carry = (r1 > 0xff); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 856 - self.flags.carry = (r1 > 0xff); [INFO] [stdout] 856 + self.flags.carry = r1 > 0xff; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:885:28 [INFO] [stdout] | [INFO] [stdout] 885 | self.flags.carry = (self.regs.a < val as u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 885 - self.flags.carry = (self.regs.a < val as u8); [INFO] [stdout] 885 + self.flags.carry = self.regs.a < val as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:481:35 [INFO] [stdout] | [INFO] [stdout] 481 | self.flags.zero = (0x01 == (psw & 0x01)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 481 - self.flags.zero = (0x01 == (psw & 0x01)); [INFO] [stdout] 481 + self.flags.zero = 0x01 == (psw & 0x01); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:482:35 [INFO] [stdout] | [INFO] [stdout] 482 | self.flags.sign = (0x02 == (psw & 0x02)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 482 - self.flags.sign = (0x02 == (psw & 0x02)); [INFO] [stdout] 482 + self.flags.sign = 0x02 == (psw & 0x02); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:483:37 [INFO] [stdout] | [INFO] [stdout] 483 | self.flags.parity = (0x04 == (psw & 0x04)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 483 - self.flags.parity = (0x04 == (psw & 0x04)); [INFO] [stdout] 483 + self.flags.parity = 0x04 == (psw & 0x04); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:484:37 [INFO] [stdout] | [INFO] [stdout] 484 | self.flags.carry = (0x05 == (psw & 0x08)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 484 - self.flags.carry = (0x05 == (psw & 0x08)); [INFO] [stdout] 484 + self.flags.carry = 0x05 == (psw & 0x08); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:485:40 [INFO] [stdout] | [INFO] [stdout] 485 | self.flags.aux_carry = (0x10 == (psw & 0x10)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 485 - self.flags.aux_carry = (0x10 == (psw & 0x10)); [INFO] [stdout] 485 + self.flags.aux_carry = 0x10 == (psw & 0x10); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:525:36 [INFO] [stdout] | [INFO] [stdout] 525 | self.flags.carry = (1 == (x&1)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 525 - self.flags.carry = (1 == (x&1)); [INFO] [stdout] 525 + self.flags.carry = 1 == (x&1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:589:12 [INFO] [stdout] | [INFO] [stdout] 589 | if (condition == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 589 - if (condition == true) { [INFO] [stdout] 589 + if condition == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:602:12 [INFO] [stdout] | [INFO] [stdout] 602 | if (condition == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 602 - if (condition == true) { [INFO] [stdout] 602 + if condition == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:830:28 [INFO] [stdout] | [INFO] [stdout] 830 | self.flags.carry = (r1 > 0xff); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 830 - self.flags.carry = (r1 > 0xff); [INFO] [stdout] 830 + self.flags.carry = r1 > 0xff; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:844:28 [INFO] [stdout] | [INFO] [stdout] 844 | self.flags.carry = (r1 > 0xff); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 844 - self.flags.carry = (r1 > 0xff); [INFO] [stdout] 844 + self.flags.carry = r1 > 0xff; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:856:28 [INFO] [stdout] | [INFO] [stdout] 856 | self.flags.carry = (r1 > 0xff); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 856 - self.flags.carry = (r1 > 0xff); [INFO] [stdout] 856 + self.flags.carry = r1 > 0xff; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu/mod.rs:885:28 [INFO] [stdout] | [INFO] [stdout] 885 | self.flags.carry = (self.regs.a < val as u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 885 - self.flags.carry = (self.regs.a < val as u8); [INFO] [stdout] 885 + self.flags.carry = self.regs.a < val as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/platform/mod.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | let args: Vec = env::args().collect(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/cpu/flags.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn calc_sub_cy(&self, res: u16) -> bool { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `num_of_on_bits` is assigned to, but never used [INFO] [stdout] --> src/cpu/flags.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mut num_of_on_bits: u8 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_num_of_on_bits` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `de32` [INFO] [stdout] --> src/cpu/mod.rs:310:21 [INFO] [stdout] | [INFO] [stdout] 310 | let de32: u32 = self.cmb_be(self.regs.b, self.regs.c).into(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_de32` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_frame` is never used [INFO] [stdout] --> src/platform/mod.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl InvadersCabinet { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn get_frame(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `read_1` is never read [INFO] [stdout] --> src/platform/io.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct IO { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | read_1: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cpu_read`, `set_port_1`, and `insert_coin` are never used [INFO] [stdout] --> src/platform/io.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl IO { [INFO] [stdout] | ------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn cpu_read(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn set_port_1(&mut self, bit: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn insert_coin(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `output` is never read [INFO] [stdout] --> src/cpu/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub struct Cpu { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 77 | pub output: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `debug`, `cpm_call`, `get_add`, `get_sub`, and `get_regs` are never used [INFO] [stdout] --> src/cpu/mod.rs:565:12 [INFO] [stdout] | [INFO] [stdout] 80 | impl Cpu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 565 | pub fn debug(&self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 671 | fn cpm_call(&mut self, advance: *mut u16) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 814 | fn get_add(&mut self, val: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 839 | fn get_sub(&mut self, val: u8) -> u8 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 892 | pub fn get_regs(&self) -> ([&str; 9], [u8; 7], [u16; 2]) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `calc_sub_cy` and `set_all_flags` are never used [INFO] [stdout] --> src/cpu/flags.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl Flags { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn calc_sub_cy(&self, res: u16) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn set_all_flags(&mut self, res: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cpu/mod.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | c.load_into_memory(program, pc as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = c.load_into_memory(program, pc as usize); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `parity_table` should have an upper case name [INFO] [stdout] --> src/cpu/flags.rs:1:7 [INFO] [stdout] | [INFO] [stdout] 1 | const parity_table: [u8; 256] = [ [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `PARITY_TABLE` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/platform/mod.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | let args: Vec = env::args().collect(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/cpu/flags.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn calc_sub_cy(&self, res: u16) -> bool { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `num_of_on_bits` is assigned to, but never used [INFO] [stdout] --> src/cpu/flags.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mut num_of_on_bits: u8 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_num_of_on_bits` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `de32` [INFO] [stdout] --> src/cpu/mod.rs:310:21 [INFO] [stdout] | [INFO] [stdout] 310 | let de32: u32 = self.cmb_be(self.regs.b, self.regs.c).into(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_de32` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/cpu/mod.rs:983:13 [INFO] [stdout] | [INFO] [stdout] 983 | for i in 0..2 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_frame` is never used [INFO] [stdout] --> src/platform/mod.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl InvadersCabinet { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn get_frame(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `cpu_read` is never used [INFO] [stdout] --> src/platform/io.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl IO { [INFO] [stdout] | ------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn cpu_read(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `output` is never read [INFO] [stdout] --> src/cpu/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub struct Cpu { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 77 | pub output: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `debug`, `cpm_call`, `get_add`, `get_sub`, and `get_regs` are never used [INFO] [stdout] --> src/cpu/mod.rs:565:12 [INFO] [stdout] | [INFO] [stdout] 80 | impl Cpu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 565 | pub fn debug(&self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 671 | fn cpm_call(&mut self, advance: *mut u16) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 814 | fn get_add(&mut self, val: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 839 | fn get_sub(&mut self, val: u8) -> u8 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 892 | pub fn get_regs(&self) -> ([&str; 9], [u8; 7], [u16; 2]) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `calc_sub_cy` and `set_all_flags` are never used [INFO] [stdout] --> src/cpu/flags.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl Flags { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn calc_sub_cy(&self, res: u16) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn set_all_flags(&mut self, res: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cpu/mod.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | c.load_into_memory(program, pc as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = c.load_into_memory(program, pc as usize); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `parity_table` should have an upper case name [INFO] [stdout] --> src/cpu/flags.rs:1:7 [INFO] [stdout] | [INFO] [stdout] 1 | const parity_table: [u8; 256] = [ [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `PARITY_TABLE` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s [INFO] running `Command { std: "docker" "inspect" "134b289fb7020b09e886428856bcbee9cf37608287de2d3a46349ba69c554b91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "134b289fb7020b09e886428856bcbee9cf37608287de2d3a46349ba69c554b91", kill_on_drop: false }` [INFO] [stdout] 134b289fb7020b09e886428856bcbee9cf37608287de2d3a46349ba69c554b91