[INFO] cloning repository https://github.com/ealvan/battleship [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ealvan/battleship" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fealvan%2Fbattleship", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fealvan%2Fbattleship'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 39a9b5fac1da078990e18eb99f4e7f466b65cd9c [INFO] checking ealvan/battleship against try#50b21af28e291c419ae81eebcb7705fb4200dc90 for pr-135167 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fealvan%2Fbattleship" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ealvan/battleship on toolchain 50b21af28e291c419ae81eebcb7705fb4200dc90 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+50b21af28e291c419ae81eebcb7705fb4200dc90" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ealvan/battleship [INFO] finished tweaking git repo https://github.com/ealvan/battleship [INFO] tweaked toml for git repo https://github.com/ealvan/battleship written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ealvan/battleship already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+50b21af28e291c419ae81eebcb7705fb4200dc90" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+50b21af28e291c419ae81eebcb7705fb4200dc90" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7073a177f7e96e271d2f3af8cf7df7a03579038b0613e7a634da3b90462e2b28 [INFO] running `Command { std: "docker" "start" "-a" "7073a177f7e96e271d2f3af8cf7df7a03579038b0613e7a634da3b90462e2b28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7073a177f7e96e271d2f3af8cf7df7a03579038b0613e7a634da3b90462e2b28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7073a177f7e96e271d2f3af8cf7df7a03579038b0613e7a634da3b90462e2b28", kill_on_drop: false }` [INFO] [stdout] 7073a177f7e96e271d2f3af8cf7df7a03579038b0613e7a634da3b90462e2b28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+50b21af28e291c419ae81eebcb7705fb4200dc90" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1edc53c14288d759c5aa3ed0fa2f3f95ca873e75a242650a5fd1607962f54bbd [INFO] running `Command { std: "docker" "start" "-a" "1edc53c14288d759c5aa3ed0fa2f3f95ca873e75a242650a5fd1607962f54bbd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling libc v0.2.167 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking battleship v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Piece` [INFO] [stdout] --> src/table.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | items::pieces::{Direction,Piece}, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/table.rs:39:25 [INFO] [stdout] | [INFO] [stdout] 39 | let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] 39 + let value = x as usize*usize::from(self.columns) + y as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/table.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] 46 + let value = x as usize*usize::from(self.columns) + y as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/table.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | let value = (point.x as usize*usize::from(self.columns) + point.y as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 53 - let value = (point.x as usize*usize::from(self.columns) + point.y as usize); [INFO] [stdout] 53 + let value = point.x as usize*usize::from(self.columns) + point.y as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/table.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] 61 + let value = x as usize*usize::from(self.columns) + y as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `UP_RIGHT` should have an upper camel case name [INFO] [stdout] --> src/items.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | UP_RIGHT,//1,1 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `UpRight` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `UP_LEFT` should have an upper camel case name [INFO] [stdout] --> src/items.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | UP_LEFT,//1,-1 [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `UpLeft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DOWN_LEFT` should have an upper camel case name [INFO] [stdout] --> src/items.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | DOWN_LEFT,//-1,-1 [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `DownLeft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DOWN_RIGHT` should have an upper camel case name [INFO] [stdout] --> src/items.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | DOWN_RIGHT,//-1,1 [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `DownRight` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | use std::io::{self, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Piece` [INFO] [stdout] --> src/table.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | items::pieces::{Direction,Piece}, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/table.rs:39:25 [INFO] [stdout] | [INFO] [stdout] 39 | let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] 39 + let value = x as usize*usize::from(self.columns) + y as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/table.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] 46 + let value = x as usize*usize::from(self.columns) + y as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/table.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | let value = (point.x as usize*usize::from(self.columns) + point.y as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 53 - let value = (point.x as usize*usize::from(self.columns) + point.y as usize); [INFO] [stdout] 53 + let value = point.x as usize*usize::from(self.columns) + point.y as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/table.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - let value = (x as usize*usize::from(self.columns) + y as usize); [INFO] [stdout] 61 + let value = x as usize*usize::from(self.columns) + y as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `UP_RIGHT` should have an upper camel case name [INFO] [stdout] --> src/items.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | UP_RIGHT,//1,1 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `UpRight` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `UP_LEFT` should have an upper camel case name [INFO] [stdout] --> src/items.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | UP_LEFT,//1,-1 [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `UpLeft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DOWN_LEFT` should have an upper camel case name [INFO] [stdout] --> src/items.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | DOWN_LEFT,//-1,-1 [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `DownLeft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DOWN_RIGHT` should have an upper camel case name [INFO] [stdout] --> src/items.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | DOWN_RIGHT,//-1,1 [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `DownRight` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | use std::io::{self, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `to_array` is never used [INFO] [stdout] --> src/main.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn to_array(v: Vec) -> [T; N] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `user_A` should have a snake case name [INFO] [stdout] --> src/main.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | fn promp_winner(user_A:&User, user_B:&User) -> bool{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `user_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `user_B` should have a snake case name [INFO] [stdout] --> src/main.rs:71:31 [INFO] [stdout] | [INFO] [stdout] 71 | fn promp_winner(user_A:&User, user_B:&User) -> bool{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `user_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `user_A` should have a snake case name [INFO] [stdout] --> src/main.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 83 | fn show_points(user_A:&User,user_B:&User){ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `user_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `user_B` should have a snake case name [INFO] [stdout] --> src/main.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | fn show_points(user_A:&User,user_B:&User){ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `user_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `u_A` should have a snake case name [INFO] [stdout] --> src/main.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | let mut u_A = create_user(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `u_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `u_B` should have a snake case name [INFO] [stdout] --> src/main.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let mut u_B = create_user(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `u_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `tached` should have an upper case name [INFO] [stdout] --> src/table.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | const tached: &str = "⛝"; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `TACHED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `to_array` is never used [INFO] [stdout] --> src/main.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn to_array(v: Vec) -> [T; N] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `user_A` should have a snake case name [INFO] [stdout] --> src/main.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | fn promp_winner(user_A:&User, user_B:&User) -> bool{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `user_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `user_B` should have a snake case name [INFO] [stdout] --> src/main.rs:71:31 [INFO] [stdout] | [INFO] [stdout] 71 | fn promp_winner(user_A:&User, user_B:&User) -> bool{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `user_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `user_A` should have a snake case name [INFO] [stdout] --> src/main.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 83 | fn show_points(user_A:&User,user_B:&User){ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `user_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `user_B` should have a snake case name [INFO] [stdout] --> src/main.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | fn show_points(user_A:&User,user_B:&User){ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `user_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `u_A` should have a snake case name [INFO] [stdout] --> src/main.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | let mut u_A = create_user(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `u_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `u_B` should have a snake case name [INFO] [stdout] --> src/main.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let mut u_B = create_user(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `u_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `tached` should have an upper case name [INFO] [stdout] --> src/table.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | const tached: &str = "⛝"; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `TACHED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.70s [INFO] running `Command { std: "docker" "inspect" "1edc53c14288d759c5aa3ed0fa2f3f95ca873e75a242650a5fd1607962f54bbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1edc53c14288d759c5aa3ed0fa2f3f95ca873e75a242650a5fd1607962f54bbd", kill_on_drop: false }` [INFO] [stdout] 1edc53c14288d759c5aa3ed0fa2f3f95ca873e75a242650a5fd1607962f54bbd