[INFO] cloning repository https://github.com/joeyrobert/advent2018 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/joeyrobert/advent2018" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoeyrobert%2Fadvent2018", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoeyrobert%2Fadvent2018'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 55c36c9da533fec63d30683799c1e6b53477bdae [INFO] checking joeyrobert/advent2018 against master#1f81f906893d166d05fb4839f169983f2b564cc7 for pr-135167 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoeyrobert%2Fadvent2018" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/joeyrobert/advent2018 on toolchain 1f81f906893d166d05fb4839f169983f2b564cc7 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f81f906893d166d05fb4839f169983f2b564cc7" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/joeyrobert/advent2018 [INFO] finished tweaking git repo https://github.com/joeyrobert/advent2018 [INFO] tweaked toml for git repo https://github.com/joeyrobert/advent2018 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/joeyrobert/advent2018 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f81f906893d166d05fb4839f169983f2b564cc7" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded skiplist v0.2.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+1f81f906893d166d05fb4839f169983f2b564cc7" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0d8ffc8b79ba13eb2c26b3be104ae0aaddef470b05009ec6bd14ef7d64c8625 [INFO] running `Command { std: "docker" "start" "-a" "a0d8ffc8b79ba13eb2c26b3be104ae0aaddef470b05009ec6bd14ef7d64c8625", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0d8ffc8b79ba13eb2c26b3be104ae0aaddef470b05009ec6bd14ef7d64c8625", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0d8ffc8b79ba13eb2c26b3be104ae0aaddef470b05009ec6bd14ef7d64c8625", kill_on_drop: false }` [INFO] [stdout] a0d8ffc8b79ba13eb2c26b3be104ae0aaddef470b05009ec6bd14ef7d64c8625 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+1f81f906893d166d05fb4839f169983f2b564cc7" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf746f3519c5fc5a9e76d5b354036791bdaa010201cfaf0cb06e425f8c4cf873 [INFO] running `Command { std: "docker" "start" "-a" "bf746f3519c5fc5a9e76d5b354036791bdaa010201cfaf0cb06e425f8c4cf873", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking bit-vec v0.5.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.4 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking skiplist v0.2.10 [INFO] [stderr] Checking advent2018 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/advent_13.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | for (x, mut ch) in s.chars().enumerate() { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/advent_04.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | let mut likely_minutes_for_guard = likely_minutes.entry(active_guard).or_insert(HashMap::new()); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/advent_17.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 176 | if (clay.contains(&(x, node.1)) && water.contains(&(x, node.1)) && falling.contains(&(x, node.1))) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 - if (clay.contains(&(x, node.1)) && water.contains(&(x, node.1)) && falling.contains(&(x, node.1))) { [INFO] [stdout] 176 + if clay.contains(&(x, node.1)) && water.contains(&(x, node.1)) && falling.contains(&(x, node.1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/advent_17.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | if (clay.contains(&(x, node.1))) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 179 - if (clay.contains(&(x, node.1))) { [INFO] [stdout] 179 + if clay.contains(&(x, node.1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/advent_17.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 194 | if (clay.contains(&(x, node.1))) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 194 - if (clay.contains(&(x, node.1))) { [INFO] [stdout] 194 + if clay.contains(&(x, node.1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/advent_04.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | let mut likely_minutes_for_guard = likely_minutes.entry(active_guard).or_insert(HashMap::new()); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/advent_13.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | for (x, mut ch) in s.chars().enumerate() { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/advent_17.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 176 | if (clay.contains(&(x, node.1)) && water.contains(&(x, node.1)) && falling.contains(&(x, node.1))) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 - if (clay.contains(&(x, node.1)) && water.contains(&(x, node.1)) && falling.contains(&(x, node.1))) { [INFO] [stdout] 176 + if clay.contains(&(x, node.1)) && water.contains(&(x, node.1)) && falling.contains(&(x, node.1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `falling` [INFO] [stdout] --> src/advent_17.rs:45:77 [INFO] [stdout] | [INFO] [stdout] 45 | fn determine_range(clay: &HashSet<(i32, i32)>, water: &HashSet<(i32, i32)>, falling: &HashSet<(i32, i32)>) -> (i32, i32, i32, i32) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_falling` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/advent_17.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | if (clay.contains(&(x, node.1))) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 179 - if (clay.contains(&(x, node.1))) { [INFO] [stdout] 179 + if clay.contains(&(x, node.1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/advent_17.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 194 | if (clay.contains(&(x, node.1))) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 194 - if (clay.contains(&(x, node.1))) { [INFO] [stdout] 194 + if clay.contains(&(x, node.1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/advent_17.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | let mut union: HashSet<_> = clay.union(water).collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `falling` [INFO] [stdout] --> src/advent_17.rs:45:77 [INFO] [stdout] | [INFO] [stdout] 45 | fn determine_range(clay: &HashSet<(i32, i32)>, water: &HashSet<(i32, i32)>, falling: &HashSet<(i32, i32)>) -> (i32, i32, i32, i32) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_falling` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/advent_15.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | ... let mut unoccupied_spots: Vec = open_spots.iter().filter(|x| !occupied_spots.contains(x) || x == position).cloned().collect(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/advent_17.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | let mut union: HashSet<_> = clay.union(water).collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/advent_15.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | ... let mut unoccupied_spots: Vec = open_spots.iter().filter(|x| !occupied_spots.contains(x) || x == position).cloned().collect(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.17s [INFO] running `Command { std: "docker" "inspect" "bf746f3519c5fc5a9e76d5b354036791bdaa010201cfaf0cb06e425f8c4cf873", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf746f3519c5fc5a9e76d5b354036791bdaa010201cfaf0cb06e425f8c4cf873", kill_on_drop: false }` [INFO] [stdout] bf746f3519c5fc5a9e76d5b354036791bdaa010201cfaf0cb06e425f8c4cf873