[INFO] fetching crate zyx-compiler 0.1.1... [INFO] building zyx-compiler-0.1.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate zyx-compiler 0.1.1 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate zyx-compiler 0.1.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zyx-compiler 0.1.1 [INFO] finished tweaking crates.io crate zyx-compiler 0.1.1 [INFO] tweaked toml for crates.io crate zyx-compiler 0.1.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zyx-core v0.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a246a1f50028f446c3bc2f2c8ae61371a4a3136951de99d3c05137790c1eb86 [INFO] running `Command { std: "docker" "start" "-a" "6a246a1f50028f446c3bc2f2c8ae61371a4a3136951de99d3c05137790c1eb86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a246a1f50028f446c3bc2f2c8ae61371a4a3136951de99d3c05137790c1eb86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a246a1f50028f446c3bc2f2c8ae61371a4a3136951de99d3c05137790c1eb86", kill_on_drop: false }` [INFO] [stdout] 6a246a1f50028f446c3bc2f2c8ae61371a4a3136951de99d3c05137790c1eb86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5195e15b850b1f998c6a730dd5e5fa5a7aff0d5dd3ad732f51c8cc26d3d632a2 [INFO] running `Command { std: "docker" "start" "-a" "5195e15b850b1f998c6a730dd5e5fa5a7aff0d5dd3ad732f51c8cc26d3d632a2", kill_on_drop: false }` [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling zyx-core v0.1.1 [INFO] [stderr] Compiling zyx-compiler v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/ast.rs:65:47 [INFO] [stdout] | [INFO] [stdout] 65 | if let Some(mut buffer) = self.buffers.remove(&p) { [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `buffer` calls a custom destructor [INFO] [stdout] | `buffer` will be dropped later as of Edition 2024 [INFO] [stdout] 66 | //std::println!("Dropping buffer {p} out of total {} buffers", self.buffers.len()); [INFO] [stdout] 67 | self.compiler.drop_buffer(&mut buffer)?; [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 68 | } [INFO] [stdout] 69 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/ast.rs:351:47 [INFO] [stdout] | [INFO] [stdout] 351 | if let Some(mut buffer) = self.buffers.remove(&p) { [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `buffer` calls a custom destructor [INFO] [stdout] | `buffer` will be dropped later as of Edition 2024 [INFO] [stdout] 352 | //std::println!("Dropping buffer {p} out of total {} buffers", self.buffers.len()); [INFO] [stdout] 353 | self.compiler.drop_buffer(&mut buffer)?; [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 354 | } [INFO] [stdout] 355 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zyx-compiler` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5195e15b850b1f998c6a730dd5e5fa5a7aff0d5dd3ad732f51c8cc26d3d632a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5195e15b850b1f998c6a730dd5e5fa5a7aff0d5dd3ad732f51c8cc26d3d632a2", kill_on_drop: false }` [INFO] [stdout] 5195e15b850b1f998c6a730dd5e5fa5a7aff0d5dd3ad732f51c8cc26d3d632a2