[INFO] fetching crate xxcalc 0.2.1... [INFO] building xxcalc-0.2.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate xxcalc 0.2.1 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate xxcalc 0.2.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xxcalc 0.2.1 [INFO] finished tweaking crates.io crate xxcalc 0.2.1 [INFO] tweaked toml for crates.io crate xxcalc 0.2.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding rustyline v1.0.0 (available: v15.0.0) [INFO] [stderr] Adding smallvec v0.2.1 (available: v1.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded encode_unicode v0.1.3 [INFO] [stderr] Downloaded rustyline v1.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b688495b19671e8b7d9ac63f9085d9535b4a03494a1990c4c40522c8eb14f83e [INFO] running `Command { std: "docker" "start" "-a" "b688495b19671e8b7d9ac63f9085d9535b4a03494a1990c4c40522c8eb14f83e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b688495b19671e8b7d9ac63f9085d9535b4a03494a1990c4c40522c8eb14f83e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b688495b19671e8b7d9ac63f9085d9535b4a03494a1990c4c40522c8eb14f83e", kill_on_drop: false }` [INFO] [stdout] b688495b19671e8b7d9ac63f9085d9535b4a03494a1990c4c40522c8eb14f83e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa04251d5fdd35dbd7476249601541e6cdbdc1e91b23f8296637ea2faa3a3286 [INFO] running `Command { std: "docker" "start" "-a" "aa04251d5fdd35dbd7476249601541e6cdbdc1e91b23f8296637ea2faa3a3286", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling smallvec v0.2.1 [INFO] [stderr] Compiling xxcalc v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused macro definition: `tokenize` [INFO] [stdout] --> src/tokenizer.rs:267:14 [INFO] [stdout] | [INFO] [stdout] 267 | macro_rules! tokenize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `tokenize_ref` [INFO] [stdout] --> src/tokenizer.rs:271:14 [INFO] [stdout] | [INFO] [stdout] 271 | macro_rules! tokenize_ref { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/evaluator.rs:250:24 [INFO] [stdout] | [INFO] [stdout] 250 | let result = try!(self.call_function(&x.to_string(), position, &mut stack)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/evaluator.rs:261:24 [INFO] [stdout] | [INFO] [stdout] 261 | let result = try!(self.call_function(&x, position, &mut stack)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/calculator.rs:52:25 [INFO] [stdout] | [INFO] [stdout] 52 | let parsed_tokens = try!(parser.process(tokens)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/calculator.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | let evaluated = try!(evaluator.process(parsed_tokens)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/polynomial_calculator.rs:261:29 [INFO] [stdout] | [INFO] [stdout] 261 | Ok(Polynomial::constant(try!(args[0].as_f64()).log(try!(args[1].as_f64())))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/polynomial_calculator.rs:261:56 [INFO] [stdout] | [INFO] [stdout] 261 | Ok(Polynomial::constant(try!(args[0].as_f64()).log(try!(args[1].as_f64())))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/polynomial_calculator.rs:280:29 [INFO] [stdout] | [INFO] [stdout] 280 | Ok(Polynomial::constant(try!(args[0].as_f64()).log10())) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/polynomial_calculator.rs:302:21 [INFO] [stdout] | [INFO] [stdout] 302 | Ok(args[0].bind(try!(args[1].as_f64()))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/evaluator.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | pub type FunctionHandle = Box) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | pub type FunctionHandle = Box) -> Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/polynomial.rs:416:5 [INFO] [stdout] | [INFO] [stdout] 416 | self + &other; [INFO] [stdout] | ^^^^^^^^^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 416 | let _ = self + &other; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/polynomial.rs:500:5 [INFO] [stdout] | [INFO] [stdout] 500 | self - &other; [INFO] [stdout] | ^^^^^^^^^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 500 | let _ = self - &other; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/polynomial.rs:596:5 [INFO] [stdout] | [INFO] [stdout] 596 | self * &other; [INFO] [stdout] | ^^^^^^^^^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 596 | let _ = self * &other; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `mul` that must be used [INFO] [stdout] --> src/polynomial.rs:618:5 [INFO] [stdout] | [INFO] [stdout] 618 | self.mul(other); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the result of the operation, without modifying the original [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 618 | let _ = self.mul(other); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | match evaluator.process(t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 38 | Ok(result) => println!("{}", result.as_string("x")), [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | }, [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/smallvec-0.2.1/lib.rs:465:1 [INFO] [stdout] | [INFO] [stdout] 465 | impl Drop for SmallVec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `result` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/smallvec-0.2.1/lib.rs:465:1 [INFO] [stdout] | [INFO] [stdout] 465 | impl Drop for SmallVec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xxcalc` (bin "xxcalc") due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "aa04251d5fdd35dbd7476249601541e6cdbdc1e91b23f8296637ea2faa3a3286", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa04251d5fdd35dbd7476249601541e6cdbdc1e91b23f8296637ea2faa3a3286", kill_on_drop: false }` [INFO] [stdout] aa04251d5fdd35dbd7476249601541e6cdbdc1e91b23f8296637ea2faa3a3286