[INFO] fetching crate wrecc_compiler 0.2.0... [INFO] building wrecc_compiler-0.2.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate wrecc_compiler 0.2.0 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate wrecc_compiler 0.2.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wrecc_compiler 0.2.0 [INFO] finished tweaking crates.io crate wrecc_compiler 0.2.0 [INFO] tweaked toml for crates.io crate wrecc_compiler 0.2.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 80e6a7dbb0fa57c095865195539bcfd5fcefe08e84eb2a028e93e7ea705213f0 [INFO] running `Command { std: "docker" "start" "-a" "80e6a7dbb0fa57c095865195539bcfd5fcefe08e84eb2a028e93e7ea705213f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "80e6a7dbb0fa57c095865195539bcfd5fcefe08e84eb2a028e93e7ea705213f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80e6a7dbb0fa57c095865195539bcfd5fcefe08e84eb2a028e93e7ea705213f0", kill_on_drop: false }` [INFO] [stdout] 80e6a7dbb0fa57c095865195539bcfd5fcefe08e84eb2a028e93e7ea705213f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93e196839daefe73c06068f53657c4dc20475cb452c7de411bfd7154ba1fa2f1 [INFO] running `Command { std: "docker" "start" "-a" "93e196839daefe73c06068f53657c4dc20475cb452c7de411bfd7154ba1fa2f1", kill_on_drop: false }` [INFO] [stderr] Compiling wrecc_compiler v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/compiler/codegen/register_allocation.rs:301:46 [INFO] [stdout] | [INFO] [stdout] 301 | if let Some(expired_intervals) = self.live_intervals.remove(&key) { [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `expired_intervals` calls a custom destructor [INFO] [stdout] | `expired_intervals` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `expired_intervals` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/compiler/codegen/mod.rs:395:17 [INFO] [stdout] | [INFO] [stdout] 373 | for declarator in declarators { [INFO] [stdout] | ---------- ----------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `declarator` calls a custom destructor [INFO] [stdout] | `declarator` will be dropped later as of Edition 2024 [INFO] [stdout] 374 | let var_symbol = declarator.entry.borrow().clone(); [INFO] [stdout] | ---------- ------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | `var_symbol` calls a custom destructor [INFO] [stdout] | `var_symbol` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | / declarator [INFO] [stdout] 396 | | .entry [INFO] [stdout] 397 | | .borrow_mut() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `declarator` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `var_symbol` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/compiler/codegen/mod.rs:518:21 [INFO] [stdout] | [INFO] [stdout] 486 | for declarator in declarators { [INFO] [stdout] | ---------- ----------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `declarator` calls a custom destructor [INFO] [stdout] | `declarator` will be dropped later as of Edition 2024 [INFO] [stdout] 487 | let var_symbol = declarator.entry.borrow().clone(); [INFO] [stdout] | ---------- ------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | `var_symbol` calls a custom destructor [INFO] [stdout] | `var_symbol` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | / declarator [INFO] [stdout] 501 | | .entry [INFO] [stdout] 502 | | .borrow_mut() [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | / declarator [INFO] [stdout] 519 | | .entry [INFO] [stdout] 520 | | .borrow_mut() [INFO] [stdout] | | ^ [INFO] [stdout] | |_____________________________________| [INFO] [stdout] | |_____________________________________this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 526 | | } [INFO] [stdout] | | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `declarator` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `var_symbol` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wrecc_compiler` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "93e196839daefe73c06068f53657c4dc20475cb452c7de411bfd7154ba1fa2f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93e196839daefe73c06068f53657c4dc20475cb452c7de411bfd7154ba1fa2f1", kill_on_drop: false }` [INFO] [stdout] 93e196839daefe73c06068f53657c4dc20475cb452c7de411bfd7154ba1fa2f1