[INFO] fetching crate weak-table 0.3.2... [INFO] building weak-table-0.3.2 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate weak-table 0.3.2 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate weak-table 0.3.2 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate weak-table 0.3.2 [INFO] finished tweaking crates.io crate weak-table 0.3.2 [INFO] tweaked toml for crates.io crate weak-table 0.3.2 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (available: v0.8.11) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6db0183106f54018f84b71d67e45628df26a6386bda9317679ea74b4bd514678 [INFO] running `Command { std: "docker" "start" "-a" "6db0183106f54018f84b71d67e45628df26a6386bda9317679ea74b4bd514678", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6db0183106f54018f84b71d67e45628df26a6386bda9317679ea74b4bd514678", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6db0183106f54018f84b71d67e45628df26a6386bda9317679ea74b4bd514678", kill_on_drop: false }` [INFO] [stdout] 6db0183106f54018f84b71d67e45628df26a6386bda9317679ea74b4bd514678 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 25ef76b2685ec8cb92dc508c1cf9981bbdf2b14bb4074380403cf9197e265eec [INFO] running `Command { std: "docker" "start" "-a" "25ef76b2685ec8cb92dc508c1cf9981bbdf2b14bb4074380403cf9197e265eec", kill_on_drop: false }` [INFO] [stderr] Compiling weak-table v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `string::String` [INFO] [stdout] --> src/compat.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | string::String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_key_hash_map.rs:147:43 [INFO] [stdout] | [INFO] [stdout] 145 | if let Some((weak_ptr, value, _)) = bucket.take() { [INFO] [stdout] | -------- ----- [INFO] [stdout] | | | [INFO] [stdout] | | `value` calls a custom destructor [INFO] [stdout] | | `value` will be dropped later as of Edition 2024 [INFO] [stdout] | `weak_ptr` calls a custom destructor [INFO] [stdout] | `weak_ptr` will be dropped later as of Edition 2024 [INFO] [stdout] 146 | self.size -= 1; [INFO] [stdout] 147 | if let Some(strong_ptr) = weak_ptr.view() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_key_hash_map.rs:145:49 [INFO] [stdout] | [INFO] [stdout] 145 | if let Some((weak_ptr, value, _)) = bucket.take() { [INFO] [stdout] | -------- ----- ^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | `value` calls a custom destructor [INFO] [stdout] | | `value` will be dropped later as of Edition 2024 [INFO] [stdout] | `weak_ptr` calls a custom destructor [INFO] [stdout] | `weak_ptr` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_key_hash_map.rs:181:39 [INFO] [stdout] | [INFO] [stdout] 179 | for (weak_ptr, value, _) in (&mut self.base).flatten() { [INFO] [stdout] | -------- ----- -------------------------- [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | | `value` calls a custom destructor [INFO] [stdout] | | `value` will be dropped later as of Edition 2024 [INFO] [stdout] | `weak_ptr` calls a custom destructor [INFO] [stdout] | `weak_ptr` will be dropped later as of Edition 2024 [INFO] [stdout] 180 | self.size -= 1; [INFO] [stdout] 181 | if let Some(strong_ptr) = weak_ptr.view() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_key_hash_map.rs:385:47 [INFO] [stdout] | [INFO] [stdout] 385 | if let Some(bucket_key) = weak_key.view() { [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `bucket_key` calls a custom destructor [INFO] [stdout] | `bucket_key` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_value_hash_map.rs:108:38 [INFO] [stdout] | [INFO] [stdout] 106 | if let Some((key, weak_value, _)) = bucket.take() { [INFO] [stdout] | --- ---------- [INFO] [stdout] | | | [INFO] [stdout] | | `weak_value` calls a custom destructor [INFO] [stdout] | | `weak_value` will be dropped later as of Edition 2024 [INFO] [stdout] | `key` calls a custom destructor [INFO] [stdout] | `key` will be dropped later as of Edition 2024 [INFO] [stdout] 107 | self.size -= 1; [INFO] [stdout] 108 | if let Some(value) = weak_value.view() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_value_hash_map.rs:106:49 [INFO] [stdout] | [INFO] [stdout] 106 | if let Some((key, weak_value, _)) = bucket.take() { [INFO] [stdout] | --- ---------- ^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | `weak_value` calls a custom destructor [INFO] [stdout] | | `weak_value` will be dropped later as of Edition 2024 [INFO] [stdout] | `key` calls a custom destructor [INFO] [stdout] | `key` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_value_hash_map.rs:142:34 [INFO] [stdout] | [INFO] [stdout] 140 | for (key, weak_value, _) in (&mut self.base).flatten() { [INFO] [stdout] | --- ---------- -------------------------- [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | | `weak_value` calls a custom destructor [INFO] [stdout] | | `weak_value` will be dropped later as of Edition 2024 [INFO] [stdout] | `key` calls a custom destructor [INFO] [stdout] | `key` will be dropped later as of Edition 2024 [INFO] [stdout] 141 | self.size -= 1; [INFO] [stdout] 142 | if let Some(value) = weak_value.view() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_value_hash_map.rs:347:42 [INFO] [stdout] | [INFO] [stdout] 347 | if let Some(value) = weak_value.view() { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `value` calls a custom destructor [INFO] [stdout] | `value` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_value_hash_map.rs:460:35 [INFO] [stdout] | [INFO] [stdout] 459 | for (key, value1) in self { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 460 | if let Some(value2) = other.get(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 467 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_weak_hash_map.rs:109:51 [INFO] [stdout] | [INFO] [stdout] 107 | if let Some((weak_key, weak_value, _)) = bucket.take() { [INFO] [stdout] | -------- ---------- [INFO] [stdout] | | | [INFO] [stdout] | | `weak_value` calls a custom destructor [INFO] [stdout] | | `weak_value` will be dropped later as of Edition 2024 [INFO] [stdout] | `weak_key` calls a custom destructor [INFO] [stdout] | `weak_key` will be dropped later as of Edition 2024 [INFO] [stdout] 108 | self.size -= 1; [INFO] [stdout] 109 | if let (Some(key), Some(value)) = (weak_key.view(), weak_value.view()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_weak_hash_map.rs:107:54 [INFO] [stdout] | [INFO] [stdout] 107 | if let Some((weak_key, weak_value, _)) = bucket.take() { [INFO] [stdout] | -------- ---------- ^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | `weak_value` calls a custom destructor [INFO] [stdout] | | `weak_value` will be dropped later as of Edition 2024 [INFO] [stdout] | `weak_key` calls a custom destructor [INFO] [stdout] | `weak_key` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_weak_hash_map.rs:143:47 [INFO] [stdout] | [INFO] [stdout] 141 | for (weak_key, weak_value, _) in (&mut self.base).flatten() { [INFO] [stdout] | -------- ---------- -------------------------- [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | | `weak_value` calls a custom destructor [INFO] [stdout] | | `weak_value` will be dropped later as of Edition 2024 [INFO] [stdout] | `weak_key` calls a custom destructor [INFO] [stdout] | `weak_key` will be dropped later as of Edition 2024 [INFO] [stdout] 142 | self.size -= 1; [INFO] [stdout] 143 | if let (Some(key), Some(value)) = (weak_key.view(), weak_value.view()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_weak_hash_map.rs:348:59 [INFO] [stdout] | [INFO] [stdout] 348 | if let (Some(b_key), Some(b_value)) = (w_key.view(), w_value.view()) { [INFO] [stdout] | ----- ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | `b_value` calls a custom destructor [INFO] [stdout] | | `b_value` will be dropped later as of Edition 2024 [INFO] [stdout] | `b_key` calls a custom destructor [INFO] [stdout] | `b_key` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/weak_weak_hash_map.rs:481:35 [INFO] [stdout] | [INFO] [stdout] 480 | for (key, value1) in self { [INFO] [stdout] | --- ---- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `key` calls a custom destructor [INFO] [stdout] | `key` will be dropped later as of Edition 2024 [INFO] [stdout] 481 | if let Some(value2) = K::with_key(&key, |k| other.get(k)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `weak-table` (lib) due to 14 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "25ef76b2685ec8cb92dc508c1cf9981bbdf2b14bb4074380403cf9197e265eec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25ef76b2685ec8cb92dc508c1cf9981bbdf2b14bb4074380403cf9197e265eec", kill_on_drop: false }` [INFO] [stdout] 25ef76b2685ec8cb92dc508c1cf9981bbdf2b14bb4074380403cf9197e265eec