[INFO] fetching crate w-pgn 0.1.2... [INFO] building w-pgn-0.1.2 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate w-pgn 0.1.2 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate w-pgn 0.1.2 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate w-pgn 0.1.2 [INFO] finished tweaking crates.io crate w-pgn 0.1.2 [INFO] tweaked toml for crates.io crate w-pgn 0.1.2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 74ecb7d70b18cbcaea1dbe69786a4a41bd921512b53b93b457258ed27f225e27 [INFO] running `Command { std: "docker" "start" "-a" "74ecb7d70b18cbcaea1dbe69786a4a41bd921512b53b93b457258ed27f225e27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74ecb7d70b18cbcaea1dbe69786a4a41bd921512b53b93b457258ed27f225e27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74ecb7d70b18cbcaea1dbe69786a4a41bd921512b53b93b457258ed27f225e27", kill_on_drop: false }` [INFO] [stdout] 74ecb7d70b18cbcaea1dbe69786a4a41bd921512b53b93b457258ed27f225e27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35700b0d1a6219d9385efccb122edc8818722a0336250ba2531940aa9a82b978 [INFO] running `Command { std: "docker" "start" "-a" "35700b0d1a6219d9385efccb122edc8818722a0336250ba2531940aa9a82b978", kill_on_drop: false }` [INFO] [stderr] Compiling w-pgn v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:130:37 [INFO] [stdout] | [INFO] [stdout] 53 | let mut moves = None; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `moves` calls a custom destructor [INFO] [stdout] | `moves` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let variation = ChessMove::new(m); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `variation` calls a custom destructor [INFO] [stdout] | `variation` will be dropped later as of Edition 2024 [INFO] [stdout] 125 | if variation_depth.len() == 0 { [INFO] [stdout] 126 | variation.borrow_mut().parent = Some(Rc::downgrade(current_move)); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 127 | current_move.borrow_mut().add_variation(variation.clone()); [INFO] [stdout] | ------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 128 | } else if let Some(variation_turn) = variation_depth.last() { [INFO] [stdout] 129 | if let Some(parent) = [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `parent` calls a custom destructor [INFO] [stdout] | `parent` will be dropped later as of Edition 2024 [INFO] [stdout] 130 | current_move.borrow().get_piece_at_turn(*variation_turn) [INFO] [stdout] | ---------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | up until Edition 2021 `#6` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 131 | { [INFO] [stdout] 132 | variation.borrow_mut().parent = Some(Rc::downgrade(&parent)); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] 133 | parent.borrow_mut().add_variation(variation.clone()); [INFO] [stdout] | ------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] 134 | } [INFO] [stdout] 135 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `#6` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `moves` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `variation` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `parent` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `w-pgn` (lib) due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "35700b0d1a6219d9385efccb122edc8818722a0336250ba2531940aa9a82b978", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35700b0d1a6219d9385efccb122edc8818722a0336250ba2531940aa9a82b978", kill_on_drop: false }` [INFO] [stdout] 35700b0d1a6219d9385efccb122edc8818722a0336250ba2531940aa9a82b978