[INFO] fetching crate unsync 0.1.2... [INFO] building unsync-0.1.2 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate unsync 0.1.2 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate unsync 0.1.2 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unsync 0.1.2 [INFO] finished tweaking crates.io crate unsync 0.1.2 [INFO] tweaked toml for crates.io crate unsync 0.1.2 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 86 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.4.0 (available: v0.5.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 01fadc5106f8869d0a1d9713f322b7354347e1c976c03cf7f6462c9609be6204 [INFO] running `Command { std: "docker" "start" "-a" "01fadc5106f8869d0a1d9713f322b7354347e1c976c03cf7f6462c9609be6204", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "01fadc5106f8869d0a1d9713f322b7354347e1c976c03cf7f6462c9609be6204", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01fadc5106f8869d0a1d9713f322b7354347e1c976c03cf7f6462c9609be6204", kill_on_drop: false }` [INFO] [stdout] 01fadc5106f8869d0a1d9713f322b7354347e1c976c03cf7f6462c9609be6204 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f70f80293eb84949716d714a347f2e722151d46b0ff5ba18bd47e7cea6d35313 [INFO] running `Command { std: "docker" "start" "-a" "f70f80293eb84949716d714a347f2e722151d46b0ff5ba18bd47e7cea6d35313", kill_on_drop: false }` [INFO] [stderr] Compiling unsync v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/broad_rc.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | let mut inner = &mut (*self.inner.as_ptr()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/semaphore.rs:263:49 [INFO] [stdout] | [INFO] [stdout] 259 | if let Some(guard) = self.try_acquire(to_acquire) { [INFO] [stdout] | ---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | match self.waiters.wait(to_acquire).await { [INFO] [stdout] | ------------------------------^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/wait_list.rs:501:1 [INFO] [stdout] | [INFO] [stdout] 501 | / impl Drop for WaitInner<'_, '_, I, O> { [INFO] [stdout] 502 | | fn drop(&mut self) { [INFO] [stdout] 503 | | let mut list = match self.list.try_borrow() { [INFO] [stdout] 504 | | Some(guard) => guard, [INFO] [stdout] ... | [INFO] [stdout] 516 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/wait_list.rs:195:1 [INFO] [stdout] | [INFO] [stdout] 195 | / impl Drop for Waiter { [INFO] [stdout] 196 | | fn drop(&mut self) { [INFO] [stdout] 197 | | unsafe { [INFO] [stdout] 198 | | if self.waker.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 205 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/semaphore.rs:467:1 [INFO] [stdout] | [INFO] [stdout] 467 | / impl Drop for Permit<'_> { [INFO] [stdout] 468 | | fn drop(&mut self) { [INFO] [stdout] 469 | | self.semaphore() [INFO] [stdout] 470 | | .release_permits(self.permits(), WakeUp::Unfair); [INFO] [stdout] 471 | | } [INFO] [stdout] 472 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> src/wait_list.rs:501:1 [INFO] [stdout] | [INFO] [stdout] 501 | / impl Drop for WaitInner<'_, '_, I, O> { [INFO] [stdout] 502 | | fn drop(&mut self) { [INFO] [stdout] 503 | | let mut list = match self.list.try_borrow() { [INFO] [stdout] 504 | | Some(guard) => guard, [INFO] [stdout] ... | [INFO] [stdout] 516 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> src/wait_list.rs:195:1 [INFO] [stdout] | [INFO] [stdout] 195 | / impl Drop for Waiter { [INFO] [stdout] 196 | | fn drop(&mut self) { [INFO] [stdout] 197 | | unsafe { [INFO] [stdout] 198 | | if self.waker.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 205 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/semaphore.rs:310:49 [INFO] [stdout] | [INFO] [stdout] 306 | if let Some(guard) = self.try_acquire_unfair(to_acquire) { [INFO] [stdout] | ----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | match self.waiters.wait(to_acquire).await { [INFO] [stdout] | ------------------------------^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/wait_list.rs:501:1 [INFO] [stdout] | [INFO] [stdout] 501 | / impl Drop for WaitInner<'_, '_, I, O> { [INFO] [stdout] 502 | | fn drop(&mut self) { [INFO] [stdout] 503 | | let mut list = match self.list.try_borrow() { [INFO] [stdout] 504 | | Some(guard) => guard, [INFO] [stdout] ... | [INFO] [stdout] 516 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/wait_list.rs:195:1 [INFO] [stdout] | [INFO] [stdout] 195 | / impl Drop for Waiter { [INFO] [stdout] 196 | | fn drop(&mut self) { [INFO] [stdout] 197 | | unsafe { [INFO] [stdout] 198 | | if self.waker.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 205 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/semaphore.rs:467:1 [INFO] [stdout] | [INFO] [stdout] 467 | / impl Drop for Permit<'_> { [INFO] [stdout] 468 | | fn drop(&mut self) { [INFO] [stdout] 469 | | self.semaphore() [INFO] [stdout] 470 | | .release_permits(self.permits(), WakeUp::Unfair); [INFO] [stdout] 471 | | } [INFO] [stdout] 472 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> src/wait_list.rs:501:1 [INFO] [stdout] | [INFO] [stdout] 501 | / impl Drop for WaitInner<'_, '_, I, O> { [INFO] [stdout] 502 | | fn drop(&mut self) { [INFO] [stdout] 503 | | let mut list = match self.list.try_borrow() { [INFO] [stdout] 504 | | Some(guard) => guard, [INFO] [stdout] ... | [INFO] [stdout] 516 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> src/wait_list.rs:195:1 [INFO] [stdout] | [INFO] [stdout] 195 | / impl Drop for Waiter { [INFO] [stdout] 196 | | fn drop(&mut self) { [INFO] [stdout] 197 | | unsafe { [INFO] [stdout] 198 | | if self.waker.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 205 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unsync` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f70f80293eb84949716d714a347f2e722151d46b0ff5ba18bd47e7cea6d35313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f70f80293eb84949716d714a347f2e722151d46b0ff5ba18bd47e7cea6d35313", kill_on_drop: false }` [INFO] [stdout] f70f80293eb84949716d714a347f2e722151d46b0ff5ba18bd47e7cea6d35313