[INFO] fetching crate unbounded-spsc 0.1.9... [INFO] building unbounded-spsc-0.1.9 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate unbounded-spsc 0.1.9 into /workspace/builds/worker-1-tc1/source [INFO] validating manifest of crates.io crate unbounded-spsc 0.1.9 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unbounded-spsc 0.1.9 [INFO] finished tweaking crates.io crate unbounded-spsc 0.1.9 [INFO] tweaked toml for crates.io crate unbounded-spsc 0.1.9 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate crates.io crate unbounded-spsc 0.1.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bounded-spsc-queue v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8778f05494bcd12fabd4881e603fe69d2f661242acd6dc6d607b1a78cf79a8f2 [INFO] running `Command { std: "docker" "start" "-a" "8778f05494bcd12fabd4881e603fe69d2f661242acd6dc6d607b1a78cf79a8f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8778f05494bcd12fabd4881e603fe69d2f661242acd6dc6d607b1a78cf79a8f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8778f05494bcd12fabd4881e603fe69d2f661242acd6dc6d607b1a78cf79a8f2", kill_on_drop: false }` [INFO] [stdout] 8778f05494bcd12fabd4881e603fe69d2f661242acd6dc6d607b1a78cf79a8f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a615ae4173f6a09a15d34b6307bae077fdcd821305dc1dc4a085816fa5823bc5 [INFO] running `Command { std: "docker" "start" "-a" "a615ae4173f6a09a15d34b6307bae077fdcd821305dc1dc4a085816fa5823bc5", kill_on_drop: false }` [INFO] [stderr] Compiling bounded-spsc-queue v0.4.0 [INFO] [stderr] Compiling unbounded-spsc v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:140:11 [INFO] [stdout] | [INFO] [stdout] 136 | let (wait_token, signal_token) = blocking::tokens(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `wait_token` calls a custom destructor [INFO] [stdout] | `wait_token` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | match self.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `wait_token` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | match self.recv_deadline (deadline) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 185 | result @ Err (RecvTimeoutError::Timeout) => { [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:213:11 [INFO] [stdout] | [INFO] [stdout] 205 | let (wait_token, signal_token) = blocking::tokens(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `wait_token` calls a custom destructor [INFO] [stdout] | `wait_token` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | match self.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `wait_token` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:347:29 [INFO] [stdout] | [INFO] [stdout] 347 | while let Some (_t) = unsafe { (*self.consumer.get()).try_pop() } { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `_t` calls a custom destructor [INFO] [stdout] | `_t` will be dropped later as of Edition 2024 [INFO] [stdout] 348 | steals += 1; [INFO] [stdout] 349 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unbounded-spsc` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "a615ae4173f6a09a15d34b6307bae077fdcd821305dc1dc4a085816fa5823bc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a615ae4173f6a09a15d34b6307bae077fdcd821305dc1dc4a085816fa5823bc5", kill_on_drop: false }` [INFO] [stdout] a615ae4173f6a09a15d34b6307bae077fdcd821305dc1dc4a085816fa5823bc5