[INFO] fetching crate structdiff 0.7.1... [INFO] building structdiff-0.7.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate structdiff 0.7.1 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate structdiff 0.7.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate structdiff 0.7.1 [INFO] finished tweaking crates.io crate structdiff 0.7.1 [INFO] tweaked toml for crates.io crate structdiff 0.7.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded assert_unordered v0.3.5 [INFO] [stderr] Downloaded nanoserde-derive v0.1.22 [INFO] [stderr] Downloaded nanoserde v0.1.37 [INFO] [stderr] Downloaded structdiff-derive v0.7.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91e162b576ce91e08df5b4efec9ef5be746d32fdaef2bfd795b11e502a4c4838 [INFO] running `Command { std: "docker" "start" "-a" "91e162b576ce91e08df5b4efec9ef5be746d32fdaef2bfd795b11e502a4c4838", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91e162b576ce91e08df5b4efec9ef5be746d32fdaef2bfd795b11e502a4c4838", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91e162b576ce91e08df5b4efec9ef5be746d32fdaef2bfd795b11e502a4c4838", kill_on_drop: false }` [INFO] [stdout] 91e162b576ce91e08df5b4efec9ef5be746d32fdaef2bfd795b11e502a4c4838 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb4c70e68b667003913804297e9fa675673db554c664bbcd0f776139f82f8b6e [INFO] running `Command { std: "docker" "start" "-a" "bb4c70e68b667003913804297e9fa675673db554c664bbcd0f776139f82f8b6e", kill_on_drop: false }` [INFO] [stderr] Compiling structdiff-derive v0.7.1 [INFO] [stderr] Compiling structdiff v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `unused` [INFO] [stdout] --> src/collections/ordered_array_like.rs:152:7 [INFO] [stdout] | [INFO] [stdout] 152 | #[cfg(unused)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(unused)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(unused)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `unused` [INFO] [stdout] --> src/collections/ordered_array_like.rs:160:7 [INFO] [stdout] | [INFO] [stdout] 160 | #[cfg(unused)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(unused)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(unused)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/collections/rope.rs:198:40 [INFO] [stdout] | [INFO] [stdout] 198 | while let Some(mut vec_iter) = self.self_own.0.pop_first().map(|(_, vec)| vec.into_iter()) { [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `vec_iter` calls a custom destructor [INFO] [stdout] | `vec_iter` will be dropped later as of Edition 2024 [INFO] [stdout] 199 | let ret @ Some(_) = vec_iter.next() else { [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/collections/rope.rs:245:32 [INFO] [stdout] | [INFO] [stdout] 245 | while let Some(item) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | / map.insert( [INFO] [stdout] 250 | | Key::from(counter - DEF_SLOT_SIZE), [INFO] [stdout] 251 | | std::mem::replace(&mut current, VecDeque::with_capacity(MAX_SLOT_SIZE)), [INFO] [stdout] 252 | | ); [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 253 | } [INFO] [stdout] 254 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `structdiff` (lib) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bb4c70e68b667003913804297e9fa675673db554c664bbcd0f776139f82f8b6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb4c70e68b667003913804297e9fa675673db554c664bbcd0f776139f82f8b6e", kill_on_drop: false }` [INFO] [stdout] bb4c70e68b667003913804297e9fa675673db554c664bbcd0f776139f82f8b6e