[INFO] fetching crate sti 0.5.0... [INFO] building sti-0.5.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate sti 0.5.0 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate sti 0.5.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sti 0.5.0 [INFO] finished tweaking crates.io crate sti 0.5.0 [INFO] tweaked toml for crates.io crate sti 0.5.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 966c79103ff7a631ef5464fbc2b589e6afddd1c2912a10bff06b45db63ae0f31 [INFO] running `Command { std: "docker" "start" "-a" "966c79103ff7a631ef5464fbc2b589e6afddd1c2912a10bff06b45db63ae0f31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "966c79103ff7a631ef5464fbc2b589e6afddd1c2912a10bff06b45db63ae0f31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "966c79103ff7a631ef5464fbc2b589e6afddd1c2912a10bff06b45db63ae0f31", kill_on_drop: false }` [INFO] [stdout] 966c79103ff7a631ef5464fbc2b589e6afddd1c2912a10bff06b45db63ae0f31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93dad6556f65fb7ec375d4a202c55bdbcbef2ce795957e63bc57742cf4fb10ee [INFO] running `Command { std: "docker" "start" "-a" "93dad6556f65fb7ec375d4a202c55bdbcbef2ce795957e63bc57742cf4fb10ee", kill_on_drop: false }` [INFO] [stderr] Compiling sti v0.5.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `Command { std: "docker" "inspect" "93dad6556f65fb7ec375d4a202c55bdbcbef2ce795957e63bc57742cf4fb10ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93dad6556f65fb7ec375d4a202c55bdbcbef2ce795957e63bc57742cf4fb10ee", kill_on_drop: false }` [INFO] [stdout] 93dad6556f65fb7ec375d4a202c55bdbcbef2ce795957e63bc57742cf4fb10ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aeb4f77303dcd149eb9e0925bb13995ec231123cefa9ce70edeef82dcd52332d [INFO] running `Command { std: "docker" "start" "-a" "aeb4f77303dcd149eb9e0925bb13995ec231123cefa9ce70edeef82dcd52332d", kill_on_drop: false }` [INFO] [stderr] Compiling sti v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/sync/spin_lock.rs:136:38 [INFO] [stdout] | [INFO] [stdout] 136 | if let Some(mut a) = a.try_lock() { [INFO] [stdout] | ----- ^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `a` calls a custom destructor [INFO] [stdout] | `a` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let mut b = b.lock(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `b` calls a custom destructor [INFO] [stdout] | `b` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | while b.lock().0 != *a { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/sync/spin_lock.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | / impl<'a, T> Drop for Guard<'a, T> { [INFO] [stdout] 108 | | #[inline] [INFO] [stdout] 109 | | fn drop(&mut self) { [INFO] [stdout] 110 | | self.lock.locked.store(false, Ordering::Release); [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `a` invokes this custom destructor [INFO] [stdout] --> src/sync/spin_lock.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | / impl<'a, T> Drop for Guard<'a, T> { [INFO] [stdout] 108 | | #[inline] [INFO] [stdout] 109 | | fn drop(&mut self) { [INFO] [stdout] 110 | | self.lock.locked.store(false, Ordering::Release); [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `b` invokes this custom destructor [INFO] [stdout] --> src/sync/spin_lock.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | / impl<'a, T> Drop for Guard<'a, T> { [INFO] [stdout] 108 | | #[inline] [INFO] [stdout] 109 | | fn drop(&mut self) { [INFO] [stdout] 110 | | self.lock.locked.store(false, Ordering::Release); [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/sync/spin_lock.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | / impl<'a, T> Drop for Guard<'a, T> { [INFO] [stdout] 108 | | #[inline] [INFO] [stdout] 109 | | fn drop(&mut self) { [INFO] [stdout] 110 | | self.lock.locked.store(false, Ordering::Release); [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sti` (lib test) due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "aeb4f77303dcd149eb9e0925bb13995ec231123cefa9ce70edeef82dcd52332d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aeb4f77303dcd149eb9e0925bb13995ec231123cefa9ce70edeef82dcd52332d", kill_on_drop: false }` [INFO] [stdout] aeb4f77303dcd149eb9e0925bb13995ec231123cefa9ce70edeef82dcd52332d