[INFO] fetching crate standing-relations 0.1.2... [INFO] building standing-relations-0.1.2 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate standing-relations 0.1.2 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate standing-relations 0.1.2 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate standing-relations 0.1.2 [INFO] finished tweaking crates.io crate standing-relations 0.1.2 [INFO] tweaked toml for crates.io crate standing-relations 0.1.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded similar-asserts v1.6.0 [INFO] [stderr] Downloaded goldenfile v1.7.3 [INFO] [stderr] Downloaded similar v2.6.0 [INFO] [stderr] Downloaded bstr v1.11.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 953c45068847b647b4e8bfe3a24908b50f7ba9b7730e0f8aa178b2254d83da1a [INFO] running `Command { std: "docker" "start" "-a" "953c45068847b647b4e8bfe3a24908b50f7ba9b7730e0f8aa178b2254d83da1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "953c45068847b647b4e8bfe3a24908b50f7ba9b7730e0f8aa178b2254d83da1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "953c45068847b647b4e8bfe3a24908b50f7ba9b7730e0f8aa178b2254d83da1a", kill_on_drop: false }` [INFO] [stdout] 953c45068847b647b4e8bfe3a24908b50f7ba9b7730e0f8aa178b2254d83da1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 519231b90e054a6bffb834b4e21420b0558b426c9ad1cf42a0bb95375765b61d [INFO] running `Command { std: "docker" "start" "-a" "519231b90e054a6bffb834b4e21420b0558b426c9ad1cf42a0bb95375765b61d", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling standing-relations v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/context/tracking.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | let mut info = &mut self.0[index.0]; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/feedback/op.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 100 | let m = self.output.get(context); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `m` calls a custom destructor [INFO] [stdout] | `m` will be dropped later as of Edition 2024 [INFO] [stdout] 101 | match m.receive() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `m` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/core/op/reduce.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 55 | 'keys: for k in changed_keys { [INFO] [stdout] | - ------------ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `k` calls a custom destructor [INFO] [stdout] | `k` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | if let Some(old_val) = out_map.remove(&k) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 62 | Some(m) => { [INFO] [stdout] 63 | let new_val = f(&k, m); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `new_val` calls a custom destructor [INFO] [stdout] | `new_val` will be dropped later as of Edition 2024 [INFO] [stdout] 64 | match out_map.insert_if_different(k.clone(), new_val.clone()) { [INFO] [stdout] | ------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/core/output.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 36 | let mut m = self.data.borrow_mut(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `m` calls a custom destructor [INFO] [stdout] | `m` will be dropped later as of Edition 2024 [INFO] [stdout] 37 | self.inner.borrow_mut().foreach(|(k, v)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `m` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `checked_foreach` is never used [INFO] [stdout] --> src/feedback/op/checked_foreach.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait CheckedForeach: Iterator { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] 2 | fn checked_foreach(self, f: impl FnMut(Self::Item)) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `standing-relations` (lib) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "519231b90e054a6bffb834b4e21420b0558b426c9ad1cf42a0bb95375765b61d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "519231b90e054a6bffb834b4e21420b0558b426c9ad1cf42a0bb95375765b61d", kill_on_drop: false }` [INFO] [stdout] 519231b90e054a6bffb834b4e21420b0558b426c9ad1cf42a0bb95375765b61d