[INFO] fetching crate ssv 0.1.0... [INFO] building ssv-0.1.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate ssv 0.1.0 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate ssv 0.1.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssv 0.1.0 [INFO] finished tweaking crates.io crate ssv 0.1.0 [INFO] tweaked toml for crates.io crate ssv 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7ad76d01f2aae57940622439bd1d6d4f5b342db95af2f3aeda63f7f72633ce6 [INFO] running `Command { std: "docker" "start" "-a" "f7ad76d01f2aae57940622439bd1d6d4f5b342db95af2f3aeda63f7f72633ce6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7ad76d01f2aae57940622439bd1d6d4f5b342db95af2f3aeda63f7f72633ce6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7ad76d01f2aae57940622439bd1d6d4f5b342db95af2f3aeda63f7f72633ce6", kill_on_drop: false }` [INFO] [stdout] f7ad76d01f2aae57940622439bd1d6d4f5b342db95af2f3aeda63f7f72633ce6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8edd37ad8d5f64e10b543f808373b86dfdb12e0a1e8c2222951c529a43a8f895 [INFO] running `Command { std: "docker" "start" "-a" "8edd37ad8d5f64e10b543f808373b86dfdb12e0a1e8c2222951c529a43a8f895", kill_on_drop: false }` [INFO] [stderr] Compiling ssv v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/engine/reader.rs:87:34 [INFO] [stdout] | [INFO] [stdout] 87 | while let Some(result) = self.tokenizer.next() { [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] 88 | match result { [INFO] [stdout] 89 | Ok(token) => match self.process(token.value, state) { [INFO] [stdout] | ----- -------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `token` calls a custom destructor [INFO] [stdout] | `token` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/engine/tokenizer.rs:323:19 [INFO] [stdout] | [INFO] [stdout] 323 | match self.process(element, state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 324 | Ok((next_state, token)) => { [INFO] [stdout] 325 | let token = self.include_current_token_position(token); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `token` calls a custom destructor [INFO] [stdout] | `token` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssv` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "8edd37ad8d5f64e10b543f808373b86dfdb12e0a1e8c2222951c529a43a8f895", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8edd37ad8d5f64e10b543f808373b86dfdb12e0a1e8c2222951c529a43a8f895", kill_on_drop: false }` [INFO] [stdout] 8edd37ad8d5f64e10b543f808373b86dfdb12e0a1e8c2222951c529a43a8f895