[INFO] fetching crate splay 0.1.8... [INFO] building splay-0.1.8 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate splay 0.1.8 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate splay 0.1.8 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate splay 0.1.8 [INFO] finished tweaking crates.io crate splay 0.1.8 [INFO] tweaked toml for crates.io crate splay 0.1.8 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding rand v0.3.23 (available: v0.8.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dfb940c5dcb4589e7b7c7f63e1bce9c6c3850c1465f1fab95b139bb046b559b2 [INFO] running `Command { std: "docker" "start" "-a" "dfb940c5dcb4589e7b7c7f63e1bce9c6c3850c1465f1fab95b139bb046b559b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dfb940c5dcb4589e7b7c7f63e1bce9c6c3850c1465f1fab95b139bb046b559b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dfb940c5dcb4589e7b7c7f63e1bce9c6c3850c1465f1fab95b139bb046b559b2", kill_on_drop: false }` [INFO] [stdout] dfb940c5dcb4589e7b7c7f63e1bce9c6c3850c1465f1fab95b139bb046b559b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f0a0ef111bedfe966aa2c009cbaf485d6f8bd9a3f9830f37d72917b6a19bc47 [INFO] running `Command { std: "docker" "start" "-a" "2f0a0ef111bedfe966aa2c009cbaf485d6f8bd9a3f9830f37d72917b6a19bc47", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling splay v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/map.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 47 | let mut left = match node.pop_left() { [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match node.pop_right() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/map.rs:310:19 [INFO] [stdout] | [INFO] [stdout] 305 | let mut cur = match self.cur.take() { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `cur` calls a custom destructor [INFO] [stdout] | `cur` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | match cur.pop_left() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 311 | Some(node) => { [INFO] [stdout] 312 | let mut node = node; [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | let node = *cur; [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `node` calls a custom destructor [INFO] [stdout] | `node` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/map.rs:344:19 [INFO] [stdout] | [INFO] [stdout] 339 | let mut cur = match self.cur.take() { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `cur` calls a custom destructor [INFO] [stdout] | `cur` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | match cur.pop_right() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 345 | Some(node) => { [INFO] [stdout] 346 | let mut node = node; [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | let node = *cur; [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `node` calls a custom destructor [INFO] [stdout] | `node` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `splay` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "2f0a0ef111bedfe966aa2c009cbaf485d6f8bd9a3f9830f37d72917b6a19bc47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f0a0ef111bedfe966aa2c009cbaf485d6f8bd9a3f9830f37d72917b6a19bc47", kill_on_drop: false }` [INFO] [stdout] 2f0a0ef111bedfe966aa2c009cbaf485d6f8bd9a3f9830f37d72917b6a19bc47