[INFO] fetching crate sdset 0.4.0... [INFO] building sdset-0.4.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate sdset 0.4.0 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate sdset 0.4.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sdset 0.4.0 [INFO] finished tweaking crates.io crate sdset 0.4.0 [INFO] tweaked toml for crates.io crate sdset 0.4.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding quickcheck v0.6.2 (available: v1.0.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quickcheck v0.6.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a10195784b88a32217004a992956043d01816c4932289457686803ccf9c9776c [INFO] running `Command { std: "docker" "start" "-a" "a10195784b88a32217004a992956043d01816c4932289457686803ccf9c9776c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a10195784b88a32217004a992956043d01816c4932289457686803ccf9c9776c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a10195784b88a32217004a992956043d01816c4932289457686803ccf9c9776c", kill_on_drop: false }` [INFO] [stdout] a10195784b88a32217004a992956043d01816c4932289457686803ccf9c9776c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f08aba846af99d8f3d65d14db917f603390021de07c5427aa3246565e2370d76 [INFO] running `Command { std: "docker" "start" "-a" "f08aba846af99d8f3d65d14db917f603390021de07c5427aa3246565e2370d76", kill_on_drop: false }` [INFO] [stderr] Compiling sdset v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/duo/difference_by_key.rs:79:19 [INFO] [stdout] | [INFO] [stdout] 76 | while let Some(first) = self.a.first().map(|x| (self.f)(x)) { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `first` calls a custom destructor [INFO] [stdout] | `first` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | match self.b.first().map(|x| (self.g)(x)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 80 | Some(min) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `min` calls a custom destructor [INFO] [stdout] | `min` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/duo/difference_by_key.rs:76:33 [INFO] [stdout] | [INFO] [stdout] 76 | while let Some(first) = self.a.first().map(|x| (self.f)(x)) { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `first` calls a custom destructor [INFO] [stdout] | `first` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Some(min) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `min` calls a custom destructor [INFO] [stdout] | `min` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/multi/difference_by_key.rs:79:33 [INFO] [stdout] | [INFO] [stdout] 79 | while let Some(first) = self.base.first().map(|x| (self.f)(x)) { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `first` calls a custom destructor [INFO] [stdout] | `first` will be dropped later as of Edition 2024 [INFO] [stdout] 80 | let mut minimum = None; [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `minimum` calls a custom destructor [INFO] [stdout] | `minimum` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | minimum = match (minimum, first) { [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Some(min) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `min` calls a custom destructor [INFO] [stdout] | `min` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sdset` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "f08aba846af99d8f3d65d14db917f603390021de07c5427aa3246565e2370d76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f08aba846af99d8f3d65d14db917f603390021de07c5427aa3246565e2370d76", kill_on_drop: false }` [INFO] [stdout] f08aba846af99d8f3d65d14db917f603390021de07c5427aa3246565e2370d76