[INFO] fetching crate rsmnl 0.1.0... [INFO] building rsmnl-0.1.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate rsmnl 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate rsmnl 0.1.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rsmnl 0.1.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rsmnl 0.1.0 [INFO] tweaked toml for crates.io crate rsmnl 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate crates.io crate rsmnl 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded errno v0.2.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b202dc86318ee4aad9c1f0f16fe49f33936b2b24580b8bb196831c60153b016e [INFO] running `Command { std: "docker" "start" "-a" "b202dc86318ee4aad9c1f0f16fe49f33936b2b24580b8bb196831c60153b016e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b202dc86318ee4aad9c1f0f16fe49f33936b2b24580b8bb196831c60153b016e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b202dc86318ee4aad9c1f0f16fe49f33936b2b24580b8bb196831c60153b016e", kill_on_drop: false }` [INFO] [stdout] b202dc86318ee4aad9c1f0f16fe49f33936b2b24580b8bb196831c60153b016e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e30b57795cc3e9bd69894993370152ccec55d736fb83fe414a6d28ad05da086c [INFO] running `Command { std: "docker" "start" "-a" "e30b57795cc3e9bd69894993370152ccec55d736fb83fe414a6d28ad05da086c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling errno v0.2.7 [INFO] [stderr] Compiling rsmnl v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `Command { std: "docker" "inspect" "e30b57795cc3e9bd69894993370152ccec55d736fb83fe414a6d28ad05da086c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e30b57795cc3e9bd69894993370152ccec55d736fb83fe414a6d28ad05da086c", kill_on_drop: false }` [INFO] [stdout] e30b57795cc3e9bd69894993370152ccec55d736fb83fe414a6d28ad05da086c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2782a435f080e9ea3f080f12cdb37352865c1385d67eb9b2d3f4c795f791f3a1 [INFO] running `Command { std: "docker" "start" "-a" "2782a435f080e9ea3f080f12cdb37352865c1385d67eb9b2d3f4c795f791f3a1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling mio v0.7.13 [INFO] [stderr] Compiling rsmnl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> examples/genl/genl-group-events.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 32 | match mnl::cb_run( [INFO] [stdout] | _______________^ [INFO] [stdout] 33 | | &buf[0..nrecv], [INFO] [stdout] 34 | | 0, [INFO] [stdout] 35 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 42 | | }), [INFO] [stdout] 43 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Err(errno) => return Err(format!("mnl_cb_run: {}", errno)), [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `errno` calls a custom destructor [INFO] [stdout] | `errno` will be dropped later as of Edition 2024 [INFO] [stdout] 47 | } [INFO] [stdout] 48 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `errno` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsmnl` (example "genl-group-events") due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/genl/genl-family-get.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> examples/genl/genl-family-get.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 151 | match mnl::cb_run(&buf[0..nrecv], seq, portid, Some(data_cb)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | Err(errno) => return Err(format!("mnl_cb_run: {}", errno)), [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `errno` calls a custom destructor [INFO] [stdout] | `errno` will be dropped later as of Edition 2024 [INFO] [stdout] 155 | } [INFO] [stdout] 156 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `errno` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsmnl` (example "genl-family-get") due to 1 previous error; 1 warning emitted [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/netfilter/nfct-daemon.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/netfilter/nf-queue.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/netfilter/nf-queue.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/netfilter/nf-queue.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/netfilter/nf-queue.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> examples/netfilter/nfct-create-batch.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | listener.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 142 | let _ = listener.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/netfilter/nf-log.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/netfilter/nf-log.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/netfilter/nf-log.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-route-add.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-addr-dump.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-addr-add.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-addr-add.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | let mut ifm = nlv.put_extra_header::().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> examples/rtnl/rtnl-addr-dump.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 101 | match mnl::cb_run(&buf[..nrecv], seq, portid, Some(data_cb)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Err(errno) => return Err(format!("mnl_cb_run: {}", errno)), [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `errno` calls a custom destructor [INFO] [stdout] | `errno` will be dropped later as of Edition 2024 [INFO] [stdout] 105 | } [INFO] [stdout] 106 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `errno` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-neigh-dump.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-neigh-dump.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | let mut rt = nlv.put_extra_header::().unwrap(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsmnl` (example "rtnl-addr-dump") due to 1 previous error; 1 warning emitted [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> examples/rtnl/rtnl-neigh-dump.rs:115:15 [INFO] [stdout] | [INFO] [stdout] 115 | match mnl::cb_run(&buf[0..nrecv], seq, portid, Some(data_cb)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Err(errno) => return Err(format!("mnl_cb_run: {}", errno)), [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `errno` calls a custom destructor [INFO] [stdout] | `errno` will be dropped later as of Edition 2024 [INFO] [stdout] 119 | } [INFO] [stdout] 120 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `errno` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-route-dump.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> examples/rtnl/rtnl-route-dump.rs:235:15 [INFO] [stdout] | [INFO] [stdout] 235 | match mnl::cb_run(&buf[0..nrecv], seq, portid, Some(data_cb)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | Err(errno) => return Err(format!("mnl_cb_run: {}", errno)), [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `errno` calls a custom destructor [INFO] [stdout] | `errno` will be dropped later as of Edition 2024 [INFO] [stdout] 239 | } [INFO] [stdout] 240 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `errno` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-link-dump3.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/rtnl/rtnl-link-dump2.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut nlh = nlv.put_header(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsmnl` (example "rtnl-neigh-dump") due to 1 previous error; 2 warnings emitted [INFO] [stderr] error: could not compile `rsmnl` (example "rtnl-route-dump") due to 1 previous error; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2782a435f080e9ea3f080f12cdb37352865c1385d67eb9b2d3f4c795f791f3a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2782a435f080e9ea3f080f12cdb37352865c1385d67eb9b2d3f4c795f791f3a1", kill_on_drop: false }` [INFO] [stdout] 2782a435f080e9ea3f080f12cdb37352865c1385d67eb9b2d3f4c795f791f3a1