[INFO] fetching crate rppal 0.22.1... [INFO] building rppal-0.22.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate rppal 0.22.1 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate rppal 0.22.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rppal 0.22.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rppal 0.22.1 [INFO] tweaked toml for crates.io crate rppal 0.22.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate crates.io crate rppal 0.22.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d11d6164c5eaef4089e4a7292da450500723c8bb9a9b599c2976bd0fc29e57a [INFO] running `Command { std: "docker" "start" "-a" "4d11d6164c5eaef4089e4a7292da450500723c8bb9a9b599c2976bd0fc29e57a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d11d6164c5eaef4089e4a7292da450500723c8bb9a9b599c2976bd0fc29e57a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d11d6164c5eaef4089e4a7292da450500723c8bb9a9b599c2976bd0fc29e57a", kill_on_drop: false }` [INFO] [stdout] 4d11d6164c5eaef4089e4a7292da450500723c8bb9a9b599c2976bd0fc29e57a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec6c9949cbf3a56d501ed480e22c0cf301a6501bbb8cd20d6d9d13f3e6e956b7 [INFO] running `Command { std: "docker" "start" "-a" "ec6c9949cbf3a56d501ed480e22c0cf301a6501bbb8cd20d6d9d13f3e6e956b7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling rppal v0.22.1 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/gpio.rs:418:34 [INFO] [stdout] | [INFO] [stdout] 407 | let mut weak_state = unsafe { [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | `weak_state` calls a custom destructor [INFO] [stdout] | `weak_state` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | if let Some(ref state) = weak_state.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/gpio/ioctl.rs:644:1 [INFO] [stdout] | [INFO] [stdout] 644 | / impl Drop for EventRequest { [INFO] [stdout] 645 | | fn drop(&mut self) { [INFO] [stdout] 646 | | self.close(); [INFO] [stdout] 647 | | } [INFO] [stdout] 648 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/gpio/epoll.rs:110:1 [INFO] [stdout] | [INFO] [stdout] 110 | / impl Drop for Epoll { [INFO] [stdout] 111 | | fn drop(&mut self) { [INFO] [stdout] 112 | | unsafe { [INFO] [stdout] 113 | | libc::close(self.fd); [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `weak_state` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rppal` (lib) due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "ec6c9949cbf3a56d501ed480e22c0cf301a6501bbb8cd20d6d9d13f3e6e956b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec6c9949cbf3a56d501ed480e22c0cf301a6501bbb8cd20d6d9d13f3e6e956b7", kill_on_drop: false }` [INFO] [stdout] ec6c9949cbf3a56d501ed480e22c0cf301a6501bbb8cd20d6d9d13f3e6e956b7