[INFO] fetching crate regex-syntax 0.8.5... [INFO] building regex-syntax-0.8.5 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate regex-syntax 0.8.5 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate regex-syntax 0.8.5 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate regex-syntax 0.8.5 [INFO] finished tweaking crates.io crate regex-syntax 0.8.5 [INFO] tweaked toml for crates.io crate regex-syntax 0.8.5 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db1d7c77a5d1ff5cad1900176350b00c92d803f9ce6466cbe2b6d2718b66d631 [INFO] running `Command { std: "docker" "start" "-a" "db1d7c77a5d1ff5cad1900176350b00c92d803f9ce6466cbe2b6d2718b66d631", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db1d7c77a5d1ff5cad1900176350b00c92d803f9ce6466cbe2b6d2718b66d631", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db1d7c77a5d1ff5cad1900176350b00c92d803f9ce6466cbe2b6d2718b66d631", kill_on_drop: false }` [INFO] [stdout] db1d7c77a5d1ff5cad1900176350b00c92d803f9ce6466cbe2b6d2718b66d631 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7837197c44b9bb514bd0c06c68b9c86294d3b62dda9df69632ca5ac417b60acb [INFO] running `Command { std: "docker" "start" "-a" "7837197c44b9bb514bd0c06c68b9c86294d3b62dda9df69632ca5ac417b60acb", kill_on_drop: false }` [INFO] [stderr] Compiling regex-syntax v0.8.5 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/ast/parse.rs:813:15 [INFO] [stdout] | [INFO] [stdout] 798 | let mut stack = self.parser().stack_group.borrow_mut(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `stack` calls a custom destructor [INFO] [stdout] | `stack` will be dropped later as of Edition 2024 [INFO] [stdout] 799 | let ast = match stack.pop() { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `ast` calls a custom destructor [INFO] [stdout] | `ast` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 813 | match stack.pop() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 828 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/ast/mod.rs:1634:1 [INFO] [stdout] | [INFO] [stdout] 1634 | / impl Drop for Ast { [INFO] [stdout] 1635 | | fn drop(&mut self) { [INFO] [stdout] 1636 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1685 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `stack` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `ast` invokes this custom destructor [INFO] [stdout] --> src/ast/mod.rs:1634:1 [INFO] [stdout] | [INFO] [stdout] 1634 | / impl Drop for Ast { [INFO] [stdout] 1635 | | fn drop(&mut self) { [INFO] [stdout] 1636 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1685 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/ast/parse.rs:877:15 [INFO] [stdout] | [INFO] [stdout] 876 | let mut stack = self.parser().stack_class.borrow_mut(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `stack` calls a custom destructor [INFO] [stdout] | `stack` will be dropped later as of Edition 2024 [INFO] [stdout] 877 | match stack.pop() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 910 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/ast/mod.rs:1689:1 [INFO] [stdout] | [INFO] [stdout] 1689 | / impl Drop for ClassSet { [INFO] [stdout] 1690 | | fn drop(&mut self) { [INFO] [stdout] 1691 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1745 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `stack` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/ast/mod.rs:1658:35 [INFO] [stdout] | [INFO] [stdout] 1658 | while let Some(mut ast) = stack.pop() { [INFO] [stdout] | ------- ^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `ast` calls a custom destructor [INFO] [stdout] | `ast` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1683 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/ast/mod.rs:1634:1 [INFO] [stdout] | [INFO] [stdout] 1634 | / impl Drop for Ast { [INFO] [stdout] 1635 | | fn drop(&mut self) { [INFO] [stdout] 1636 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1685 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `ast` invokes this custom destructor [INFO] [stdout] --> src/ast/mod.rs:1634:1 [INFO] [stdout] | [INFO] [stdout] 1634 | / impl Drop for Ast { [INFO] [stdout] 1635 | | fn drop(&mut self) { [INFO] [stdout] 1636 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1685 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/ast/mod.rs:1722:35 [INFO] [stdout] | [INFO] [stdout] 1722 | while let Some(mut set) = stack.pop() { [INFO] [stdout] | ------- ^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `set` calls a custom destructor [INFO] [stdout] | `set` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1743 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/ast/mod.rs:1689:1 [INFO] [stdout] | [INFO] [stdout] 1689 | / impl Drop for ClassSet { [INFO] [stdout] 1690 | | fn drop(&mut self) { [INFO] [stdout] 1691 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1745 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `set` invokes this custom destructor [INFO] [stdout] --> src/ast/mod.rs:1689:1 [INFO] [stdout] | [INFO] [stdout] 1689 | / impl Drop for ClassSet { [INFO] [stdout] 1690 | | fn drop(&mut self) { [INFO] [stdout] 1691 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1745 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/hir/translate.rs:451:40 [INFO] [stdout] | [INFO] [stdout] 451 | while let Some(expr) = self.pop_concat_expr() { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `expr` calls a custom destructor [INFO] [stdout] | `expr` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 455 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/hir/mod.rs:1913:1 [INFO] [stdout] | [INFO] [stdout] 1913 | / impl Drop for Hir { [INFO] [stdout] 1914 | | fn drop(&mut self) { [INFO] [stdout] 1915 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1953 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `expr` invokes this custom destructor [INFO] [stdout] --> src/hir/mod.rs:1913:1 [INFO] [stdout] | [INFO] [stdout] 1913 | / impl Drop for Hir { [INFO] [stdout] 1914 | | fn drop(&mut self) { [INFO] [stdout] 1915 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1953 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/hir/mod.rs:1932:36 [INFO] [stdout] | [INFO] [stdout] 1932 | while let Some(mut expr) = stack.pop() { [INFO] [stdout] | -------- ^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `expr` calls a custom destructor [INFO] [stdout] | `expr` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1951 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/hir/mod.rs:1913:1 [INFO] [stdout] | [INFO] [stdout] 1913 | / impl Drop for Hir { [INFO] [stdout] 1914 | | fn drop(&mut self) { [INFO] [stdout] 1915 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1953 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `expr` invokes this custom destructor [INFO] [stdout] --> src/hir/mod.rs:1913:1 [INFO] [stdout] | [INFO] [stdout] 1913 | / impl Drop for Hir { [INFO] [stdout] 1914 | | fn drop(&mut self) { [INFO] [stdout] 1915 | | use core::mem; [INFO] [stdout] ... | [INFO] [stdout] 1953 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `regex-syntax` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "7837197c44b9bb514bd0c06c68b9c86294d3b62dda9df69632ca5ac417b60acb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7837197c44b9bb514bd0c06c68b9c86294d3b62dda9df69632ca5ac417b60acb", kill_on_drop: false }` [INFO] [stdout] 7837197c44b9bb514bd0c06c68b9c86294d3b62dda9df69632ca5ac417b60acb