[INFO] fetching crate quake-util 0.3.2... [INFO] building quake-util-0.3.2 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate quake-util 0.3.2 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate quake-util 0.3.2 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate quake-util 0.3.2 [INFO] finished tweaking crates.io crate quake-util 0.3.2 [INFO] tweaked toml for crates.io crate quake-util 0.3.2 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate crates.io crate quake-util 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded benchmarking v0.4.12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a7fa7643168a2cf8705d4efba3fd607196015ad08d8e65ed2fad63e0653c830 [INFO] running `Command { std: "docker" "start" "-a" "2a7fa7643168a2cf8705d4efba3fd607196015ad08d8e65ed2fad63e0653c830", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a7fa7643168a2cf8705d4efba3fd607196015ad08d8e65ed2fad63e0653c830", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a7fa7643168a2cf8705d4efba3fd607196015ad08d8e65ed2fad63e0653c830", kill_on_drop: false }` [INFO] [stdout] 2a7fa7643168a2cf8705d4efba3fd607196015ad08d8e65ed2fad63e0653c830 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a5239f2fc2e3e2b6e0b707f881a570fa711b24b0d01206df5107a725fb60179 [INFO] running `Command { std: "docker" "start" "-a" "7a5239f2fc2e3e2b6e0b707f881a570fa711b24b0d01206df5107a725fb60179", kill_on_drop: false }` [INFO] [stderr] Compiling quake-util v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `Normalize` is never used [INFO] [stdout] --> src/qmap/parser.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | trait Normalize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `Command { std: "docker" "inspect" "7a5239f2fc2e3e2b6e0b707f881a570fa711b24b0d01206df5107a725fb60179", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a5239f2fc2e3e2b6e0b707f881a570fa711b24b0d01206df5107a725fb60179", kill_on_drop: false }` [INFO] [stdout] 7a5239f2fc2e3e2b6e0b707f881a570fa711b24b0d01206df5107a725fb60179 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dcbe1c3331a4147a4f2c25ff01e2747b5bc663c4acf4fa81d145929ac7e0196b [INFO] running `Command { std: "docker" "start" "-a" "dcbe1c3331a4147a4f2c25ff01e2747b5bc663c4acf4fa81d145929ac7e0196b", kill_on_drop: false }` [INFO] [stderr] Compiling simd-adler32 v0.3.7 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling benchmarking v0.4.12 [INFO] [stdout] warning: trait `Normalize` is never used [INFO] [stdout] --> src/qmap/parser.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | trait Normalize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling miniz_oxide v0.7.2 [INFO] [stderr] Compiling fdeflate v0.3.4 [INFO] [stderr] Compiling flate2 v1.0.28 [INFO] [stderr] Compiling png v0.17.11 [INFO] [stderr] Compiling quake-util v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> examples/bspstats.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 37 | for edict in qmap.entities.into_iter().map(|e| e.edict) { [INFO] [stdout] | ----- ------------------------------------------ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `edict` calls a custom destructor [INFO] [stdout] | `edict` will be dropped later as of Edition 2024 [INFO] [stdout] 38 | let map_name_cstr = if edict.get(&CString::new("classname").unwrap()) [INFO] [stdout] | ------------- ---------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | `map_name_cstr` calls a custom destructor [INFO] [stdout] | `map_name_cstr` will be dropped later as of Edition 2024 [INFO] [stdout] 39 | == Some(&CString::new("worldspawn").unwrap()) [INFO] [stdout] | ----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | .get(&CString::new("message").unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 43 | .map(Clone::clone) [INFO] [stdout] 44 | } else { [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 48 | if let Some(map_name_cstr) = map_name_cstr { [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `edict` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `map_name_cstr` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quake-util` (example "bspstats") due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `Normalize` is never used [INFO] [stdout] --> src/qmap/parser.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | trait Normalize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "dcbe1c3331a4147a4f2c25ff01e2747b5bc663c4acf4fa81d145929ac7e0196b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcbe1c3331a4147a4f2c25ff01e2747b5bc663c4acf4fa81d145929ac7e0196b", kill_on_drop: false }` [INFO] [stdout] dcbe1c3331a4147a4f2c25ff01e2747b5bc663c4acf4fa81d145929ac7e0196b