[INFO] fetching crate pzem004t 0.1.7... [INFO] building pzem004t-0.1.7 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate pzem004t 0.1.7 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate pzem004t 0.1.7 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pzem004t 0.1.7 [INFO] finished tweaking crates.io crate pzem004t 0.1.7 [INFO] tweaked toml for crates.io crate pzem004t 0.1.7 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v0.2.7 (available: v1.0.0) [INFO] [stderr] Adding nb v0.1.3 (available: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85403156e2a4e88d7608e236865e960135659aa0b5522e7f9817a5660d7860c1 [INFO] running `Command { std: "docker" "start" "-a" "85403156e2a4e88d7608e236865e960135659aa0b5522e7f9817a5660d7860c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85403156e2a4e88d7608e236865e960135659aa0b5522e7f9817a5660d7860c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85403156e2a4e88d7608e236865e960135659aa0b5522e7f9817a5660d7860c1", kill_on_drop: false }` [INFO] [stdout] 85403156e2a4e88d7608e236865e960135659aa0b5522e7f9817a5660d7860c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0faf2331dd9ac861d15b3121107cec9c88131c5cb5e373541fd4f1b97f2da037 [INFO] running `Command { std: "docker" "start" "-a" "0faf2331dd9ac861d15b3121107cec9c88131c5cb5e373541fd4f1b97f2da037", kill_on_drop: false }` [INFO] [stderr] Compiling nb v1.1.0 [INFO] [stderr] Compiling crc16 v0.4.0 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling nb v0.1.3 [INFO] [stderr] Compiling embedded-hal v0.2.7 [INFO] [stderr] Compiling pzem004t v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/io.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | block!(self.write(buf[i]))?; [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^-- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/io.rs:58:33 [INFO] [stdout] | [INFO] [stdout] 58 | buf[i] = block!(self.read())?; [INFO] [stdout] | -------^^^^^^^^^^^-- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 25]` does not permit being left uninitialized [INFO] [stdout] --> src/lib.rs:235:43 [INFO] [stdout] | [INFO] [stdout] 235 | let mut resp: [u8; 25] = unsafe { core::mem::MaybeUninit::uninit().assume_init() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 7]` does not permit being left uninitialized [INFO] [stdout] --> src/lib.rs:263:42 [INFO] [stdout] | [INFO] [stdout] 263 | let mut resp: [u8; 7] = unsafe { core::mem::MaybeUninit::uninit().assume_init() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 7]` does not permit being left uninitialized [INFO] [stdout] --> src/lib.rs:289:42 [INFO] [stdout] | [INFO] [stdout] 289 | let mut resp: [u8; 7] = unsafe { core::mem::MaybeUninit::uninit().assume_init() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 8]` does not permit being left uninitialized [INFO] [stdout] --> src/lib.rs:320:42 [INFO] [stdout] | [INFO] [stdout] 320 | let mut resp: [u8; 8] = unsafe { core::mem::MaybeUninit::uninit().assume_init() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 8]` does not permit being left uninitialized [INFO] [stdout] --> src/lib.rs:357:42 [INFO] [stdout] | [INFO] [stdout] 357 | let mut resp: [u8; 8] = unsafe { core::mem::MaybeUninit::uninit().assume_init() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 4]` does not permit being left uninitialized [INFO] [stdout] --> src/lib.rs:373:42 [INFO] [stdout] | [INFO] [stdout] 373 | let mut resp: [u8; 4] = unsafe { core::mem::MaybeUninit::uninit().assume_init() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pzem004t` (lib) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0faf2331dd9ac861d15b3121107cec9c88131c5cb5e373541fd4f1b97f2da037", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0faf2331dd9ac861d15b3121107cec9c88131c5cb5e373541fd4f1b97f2da037", kill_on_drop: false }` [INFO] [stdout] 0faf2331dd9ac861d15b3121107cec9c88131c5cb5e373541fd4f1b97f2da037