[INFO] fetching crate namaste 0.29.1... [INFO] building namaste-0.29.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate namaste 0.29.1 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate namaste 0.29.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate namaste 0.29.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate namaste 0.29.1 [INFO] tweaked toml for crates.io crate namaste 0.29.1 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate crates.io crate namaste 0.29.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dia-time v9.0.0 [INFO] [stderr] Downloaded cld v0.5.1 [INFO] [stderr] Downloaded dia-args v0.60.2 [INFO] [stderr] Downloaded zeros v16.1.3 [INFO] [stderr] Downloaded blackhole v0.20.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61d3cbf32af376706c82599d73ae321ced858bc4da6224947051896f444c188a [INFO] running `Command { std: "docker" "start" "-a" "61d3cbf32af376706c82599d73ae321ced858bc4da6224947051896f444c188a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61d3cbf32af376706c82599d73ae321ced858bc4da6224947051896f444c188a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61d3cbf32af376706c82599d73ae321ced858bc4da6224947051896f444c188a", kill_on_drop: false }` [INFO] [stdout] 61d3cbf32af376706c82599d73ae321ced858bc4da6224947051896f444c188a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f9037318edeee8b0c63c7890d8ae0f965c2527f65ac9c3452f281ce8a1f11f6 [INFO] running `Command { std: "docker" "start" "-a" "8f9037318edeee8b0c63c7890d8ae0f965c2527f65ac9c3452f281ce8a1f11f6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling namaste v0.29.1 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/root/rw_namaste/linux.rs:85:11 [INFO] [stdout] | [INFO] [stdout] 84 | let write = Namaste::make(&$self.write_id, UNCLONABLE)?; [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `write` calls a custom destructor [INFO] [stdout] | `write` will be dropped later as of Edition 2024 [INFO] [stdout] 85 | match connect_to(&$self.read_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | write!(self) [INFO] [stdout] | ------------ in this macro invocation [INFO] [stdout] 115 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `write` invokes this custom destructor [INFO] [stdout] --> src/linux.rs:87:1 [INFO] [stdout] | [INFO] [stdout] 87 | / impl Drop for Namaste { [INFO] [stdout] 88 | | [INFO] [stdout] 89 | | fn drop(&mut self) { [INFO] [stdout] 90 | | if let Either::Other(stop_flag) = &self.data { [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `namaste` (lib) due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "8f9037318edeee8b0c63c7890d8ae0f965c2527f65ac9c3452f281ce8a1f11f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f9037318edeee8b0c63c7890d8ae0f965c2527f65ac9c3452f281ce8a1f11f6", kill_on_drop: false }` [INFO] [stdout] 8f9037318edeee8b0c63c7890d8ae0f965c2527f65ac9c3452f281ce8a1f11f6