[INFO] fetching crate msgpackin 0.0.4... [INFO] building msgpackin-0.0.4 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate msgpackin 0.0.4 into /workspace/builds/worker-1-tc1/source [INFO] validating manifest of crates.io crate msgpackin 0.0.4 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate msgpackin 0.0.4 [INFO] finished tweaking crates.io crate msgpackin 0.0.4 [INFO] tweaked toml for crates.io crate msgpackin 0.0.4 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded msgpackin_core v0.0.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ab2f531d33e481fd579df5099d5cd1f3470db1fc12010bd5adcfda8d4a47bb1 [INFO] running `Command { std: "docker" "start" "-a" "4ab2f531d33e481fd579df5099d5cd1f3470db1fc12010bd5adcfda8d4a47bb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ab2f531d33e481fd579df5099d5cd1f3470db1fc12010bd5adcfda8d4a47bb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ab2f531d33e481fd579df5099d5cd1f3470db1fc12010bd5adcfda8d4a47bb1", kill_on_drop: false }` [INFO] [stdout] 4ab2f531d33e481fd579df5099d5cd1f3470db1fc12010bd5adcfda8d4a47bb1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb0d5d275526ef3eb16a6be39c308450c44e3d99e62e4a8db4a9b06dca978510 [INFO] running `Command { std: "docker" "start" "-a" "cb0d5d275526ef3eb16a6be39c308450c44e3d99e62e4a8db4a9b06dca978510", kill_on_drop: false }` [INFO] [stderr] Compiling msgpackin_core v0.0.4 [INFO] [stderr] Compiling msgpackin v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: unused import: `self::core::iter` [INFO] [stdout] --> src/lib.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | pub use self::core::iter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | #![deny(warnings)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = note: `#[deny(unused_imports)]` implied by `#[deny(warnings)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/value.rs:1029:59 [INFO] [stdout] | [INFO] [stdout] 1028 | let mut c = c.into(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `c` calls a custom destructor [INFO] [stdout] | `c` will be dropped later as of Edition 2024 [INFO] [stdout] 1029 | priv_encode_async(self, &mut enc, &mut c, config).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 1030 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `c` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: trait `Error` is never used [INFO] [stdout] --> src/lib.rs:185:15 [INFO] [stdout] | [INFO] [stdout] 185 | pub trait Error: fmt::Debug + fmt::Display { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(dead_code)]` implied by `#[deny(warnings)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `msgpackin` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "cb0d5d275526ef3eb16a6be39c308450c44e3d99e62e4a8db4a9b06dca978510", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb0d5d275526ef3eb16a6be39c308450c44e3d99e62e4a8db4a9b06dca978510", kill_on_drop: false }` [INFO] [stdout] cb0d5d275526ef3eb16a6be39c308450c44e3d99e62e4a8db4a9b06dca978510