[INFO] fetching crate mpmc-async 0.1.7... [INFO] building mpmc-async-0.1.7 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate mpmc-async 0.1.7 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate mpmc-async 0.1.7 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc1/source/rust-toolchain.toml [INFO] started tweaking crates.io crate mpmc-async 0.1.7 [INFO] finished tweaking crates.io crate mpmc-async 0.1.7 [INFO] tweaked toml for crates.io crate mpmc-async 0.1.7 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3fba8f78ade570fa9f8d3897c8152b9b66a4898fbec0eaa0711571523829bd9d [INFO] running `Command { std: "docker" "start" "-a" "3fba8f78ade570fa9f8d3897c8152b9b66a4898fbec0eaa0711571523829bd9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3fba8f78ade570fa9f8d3897c8152b9b66a4898fbec0eaa0711571523829bd9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fba8f78ade570fa9f8d3897c8152b9b66a4898fbec0eaa0711571523829bd9d", kill_on_drop: false }` [INFO] [stdout] 3fba8f78ade570fa9f8d3897c8152b9b66a4898fbec0eaa0711571523829bd9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a6c401a44cd5aced0d32e4d8c67f58b12ca64cf14c3849f3469ed2a2c3624dd [INFO] running `Command { std: "docker" "start" "-a" "9a6c401a44cd5aced0d32e4d8c67f58b12ca64cf14c3849f3469ed2a2c3624dd", kill_on_drop: false }` [INFO] [stderr] Compiling mpmc-async v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/state.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 98 | let mut opt = Some(value); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `opt` calls a custom destructor [INFO] [stdout] | `opt` will be dropped later as of Edition 2024 [INFO] [stdout] 99 | match self.inner_mut().try_send(&mut opt) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/state.rs:207:15 [INFO] [stdout] | [INFO] [stdout] 205 | let mut inner = self.inner_mut(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `inner` calls a custom destructor [INFO] [stdout] | `inner` will be dropped later as of Edition 2024 [INFO] [stdout] 206 | [INFO] [stdout] 207 | match inner.try_reserve(count) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/linked_list.rs:611:1 [INFO] [stdout] | [INFO] [stdout] 611 | / impl Drop for NodeRef { [INFO] [stdout] 612 | | fn drop(&mut self) { [INFO] [stdout] 613 | | maybe_drop_node(self.node_ptr); [INFO] [stdout] 614 | | } [INFO] [stdout] 615 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `inner` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/state.rs:326:15 [INFO] [stdout] | [INFO] [stdout] 324 | let mut inner = self.inner_mut(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `inner` calls a custom destructor [INFO] [stdout] | `inner` will be dropped later as of Edition 2024 [INFO] [stdout] 325 | [INFO] [stdout] 326 | match inner.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `inner` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mpmc-async` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "9a6c401a44cd5aced0d32e4d8c67f58b12ca64cf14c3849f3469ed2a2c3624dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a6c401a44cd5aced0d32e4d8c67f58b12ca64cf14c3849f3469ed2a2c3624dd", kill_on_drop: false }` [INFO] [stdout] 9a6c401a44cd5aced0d32e4d8c67f58b12ca64cf14c3849f3469ed2a2c3624dd