[INFO] fetching crate libxivdat 0.2.0... [INFO] building libxivdat-0.2.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate libxivdat 0.2.0 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate libxivdat 0.2.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libxivdat 0.2.0 [INFO] finished tweaking crates.io crate libxivdat 0.2.0 [INFO] tweaked toml for crates.io crate libxivdat 0.2.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 07eead4d396885353cdb3fc706b9e9ab9a1e297f6d7b41ee595331621131c66c [INFO] running `Command { std: "docker" "start" "-a" "07eead4d396885353cdb3fc706b9e9ab9a1e297f6d7b41ee595331621131c66c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "07eead4d396885353cdb3fc706b9e9ab9a1e297f6d7b41ee595331621131c66c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07eead4d396885353cdb3fc706b9e9ab9a1e297f6d7b41ee595331621131c66c", kill_on_drop: false }` [INFO] [stdout] 07eead4d396885353cdb3fc706b9e9ab9a1e297f6d7b41ee595331621131c66c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 509d1e39d86b6fb7b1e023a02bb0bd07ae78b528c96d7592e89d78ddd808ce23 [INFO] running `Command { std: "docker" "start" "-a" "509d1e39d86b6fb7b1e023a02bb0bd07ae78b528c96d7592e89d78ddd808ce23", kill_on_drop: false }` [INFO] [stderr] Compiling libxivdat v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.17s [INFO] running `Command { std: "docker" "inspect" "509d1e39d86b6fb7b1e023a02bb0bd07ae78b528c96d7592e89d78ddd808ce23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "509d1e39d86b6fb7b1e023a02bb0bd07ae78b528c96d7592e89d78ddd808ce23", kill_on_drop: false }` [INFO] [stdout] 509d1e39d86b6fb7b1e023a02bb0bd07ae78b528c96d7592e89d78ddd808ce23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c255ad83ebb4b942c692ae58f8a8c0b9306fc261ba58eb4609936e7d33036183 [INFO] running `Command { std: "docker" "start" "-a" "c255ad83ebb4b942c692ae58f8a8c0b9306fc261ba58eb4609936e7d33036183", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.42 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling once_cell v1.20.2 [INFO] [stderr] Compiling tempfile v3.14.0 [INFO] [stderr] Compiling libxivdat v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/dat_file.rs:944:15 [INFO] [stdout] | [INFO] [stdout] 939 | let tmp_dir = match tempdir() { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `tmp_dir` calls a custom destructor [INFO] [stdout] | `tmp_dir` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 944 | match DATFile::create(&tmp_path, DATType::Macro) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 960 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `tmp_dir` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tempfile-3.14.0/src/dir/mod.rs:479:1 [INFO] [stdout] | [INFO] [stdout] 479 | impl Drop for TempDir { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/dat_file.rs:970:15 [INFO] [stdout] | [INFO] [stdout] 964 | let tmp_dir = match tempdir() { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `tmp_dir` calls a custom destructor [INFO] [stdout] | `tmp_dir` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 970 | match DATFile::create_with_content(&tmp_path, DATType::Macro, content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 994 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `tmp_dir` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tempfile-3.14.0/src/dir/mod.rs:479:1 [INFO] [stdout] | [INFO] [stdout] 479 | impl Drop for TempDir { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/dat_file.rs:1003:15 [INFO] [stdout] | [INFO] [stdout] 998 | let tmp_dir = match tempdir() { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `tmp_dir` calls a custom destructor [INFO] [stdout] | `tmp_dir` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1003 | match DATFile::create_unsafe(&tmp_path, DATType::Macro, 256, 512, 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1013 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `tmp_dir` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tempfile-3.14.0/src/dir/mod.rs:479:1 [INFO] [stdout] | [INFO] [stdout] 479 | impl Drop for TempDir { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libxivdat` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "c255ad83ebb4b942c692ae58f8a8c0b9306fc261ba58eb4609936e7d33036183", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c255ad83ebb4b942c692ae58f8a8c0b9306fc261ba58eb4609936e7d33036183", kill_on_drop: false }` [INFO] [stdout] c255ad83ebb4b942c692ae58f8a8c0b9306fc261ba58eb4609936e7d33036183