[INFO] fetching crate lemon-mint 0.1.4... [INFO] building lemon-mint-0.1.4 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate lemon-mint 0.1.4 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate lemon-mint 0.1.4 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lemon-mint 0.1.4 [INFO] finished tweaking crates.io crate lemon-mint 0.1.4 [INFO] tweaked toml for crates.io crate lemon-mint 0.1.4 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3eee10810685a339fa4cae074e356ac1b223ccf1144abb8fc92f13a04033dd59 [INFO] running `Command { std: "docker" "start" "-a" "3eee10810685a339fa4cae074e356ac1b223ccf1144abb8fc92f13a04033dd59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3eee10810685a339fa4cae074e356ac1b223ccf1144abb8fc92f13a04033dd59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3eee10810685a339fa4cae074e356ac1b223ccf1144abb8fc92f13a04033dd59", kill_on_drop: false }` [INFO] [stdout] 3eee10810685a339fa4cae074e356ac1b223ccf1144abb8fc92f13a04033dd59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8917f4dcf8f81a8b951a10c575bffbc7fb8b334a75b7d0d00371637772f02dc1 [INFO] running `Command { std: "docker" "start" "-a" "8917f4dcf8f81a8b951a10c575bffbc7fb8b334a75b7d0d00371637772f02dc1", kill_on_drop: false }` [INFO] [stderr] Compiling lemon-mint v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:980:24 [INFO] [stdout] | [INFO] [stdout] 979 | { let mut y = found.basis[i].borrow_mut(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `y` calls a custom destructor [INFO] [stdout] | `y` will be dropped later as of Edition 2024 [INFO] [stdout] 980 | if let Ok(mut x) = x.try_borrow_mut() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 996 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `y` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1568:42 [INFO] [stdout] | [INFO] [stdout] 1567 | { if action.borrow().typ == ActionType::Reduce [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 1568 | { if let StateOrRule::Rule(n_rule) = action.borrow().x [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1571 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1607:48 [INFO] [stdout] | [INFO] [stdout] 1599 | { if action.borrow().typ == ActionType::Reduce [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1606 | { if ap2.borrow().typ == ActionType::Reduce [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 1607 | { if let StateOrRule::Rule(n_rule_2) = ap2.borrow().x [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1612 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 1631 | { let mut action = action.borrow_mut(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `action` calls a custom destructor [INFO] [stdout] | `action` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1651 | { let action = action.borrow(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `action` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1600:42 [INFO] [stdout] | [INFO] [stdout] 1599 | { if action.borrow().typ == ActionType::Reduce [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 1600 | { if let StateOrRule::Rule(n_rule) = action.borrow().x [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1606 | { if ap2.borrow().typ == ActionType::Reduce [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1620 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 1631 | { let mut action = action.borrow_mut(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `action` calls a custom destructor [INFO] [stdout] | `action` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1651 | { let action = action.borrow(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `action` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1814:49 [INFO] [stdout] | [INFO] [stdout] 1814 | { if let StateOrRule::State(ref mut state) = action.borrow_mut().x [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1817 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 1818 | for configuration in stp.configurations.iter() [INFO] [stdout] 1819 | { let mut configuration = configuration.borrow_mut(); [INFO] [stdout] | ----------------- [INFO] [stdout] | | [INFO] [stdout] | `configuration` calls a custom destructor [INFO] [stdout] | `configuration` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `configuration` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `with_fallback`, `n_nonterminals`, and `tables_size` are never read [INFO] [stdout] --> src/lib.rs:2831:2 [INFO] [stdout] | [INFO] [stdout] 2808 | pub struct LemonMint [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 2831 | with_fallback: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2842 | n_nonterminals: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 2843 | tables_size: usize, // Total table size of all tables in bytes [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LemonMint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1359:7 [INFO] [stdout] | [INFO] [stdout] 1359 | mem::replace(&mut symbols.array[rhs.index].firstset, set); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1359 | let _ = mem::replace(&mut symbols.array[rhs.index].firstset, set); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lemon-mint` (lib) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8917f4dcf8f81a8b951a10c575bffbc7fb8b334a75b7d0d00371637772f02dc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8917f4dcf8f81a8b951a10c575bffbc7fb8b334a75b7d0d00371637772f02dc1", kill_on_drop: false }` [INFO] [stdout] 8917f4dcf8f81a8b951a10c575bffbc7fb8b334a75b7d0d00371637772f02dc1