[INFO] fetching crate just_linked 0.1.0... [INFO] building just_linked-0.1.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate just_linked 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate just_linked 0.1.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate just_linked 0.1.0 [INFO] finished tweaking crates.io crate just_linked 0.1.0 [INFO] tweaked toml for crates.io crate just_linked 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded autocfg v1.4.0 [INFO] [stderr] Downloaded slab v0.4.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b33752c4350a79cb8e977c5ee9e8c027b43b3927fb9069914a9a698e204a6512 [INFO] running `Command { std: "docker" "start" "-a" "b33752c4350a79cb8e977c5ee9e8c027b43b3927fb9069914a9a698e204a6512", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b33752c4350a79cb8e977c5ee9e8c027b43b3927fb9069914a9a698e204a6512", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b33752c4350a79cb8e977c5ee9e8c027b43b3927fb9069914a9a698e204a6512", kill_on_drop: false }` [INFO] [stdout] b33752c4350a79cb8e977c5ee9e8c027b43b3927fb9069914a9a698e204a6512 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 163a2828ff2646eb27d021167ad5ccfb5a143f7f6c89d173383d1365a9a1ba9a [INFO] running `Command { std: "docker" "start" "-a" "163a2828ff2646eb27d021167ad5ccfb5a143f7f6c89d173383d1365a9a1ba9a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling just_linked v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 149 | if let Some(mut next) = current_next_ref { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:389:39 [INFO] [stdout] | [INFO] [stdout] 389 | while let Some(mut entries) = self.entries.take() { [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `entries` calls a custom destructor [INFO] [stdout] | `entries` will be dropped later as of Edition 2024 [INFO] [stdout] 390 | let datum = entries.data.take(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `datum` calls a custom destructor [INFO] [stdout] | `datum` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `just_linked` (lib) due to 1 previous error; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "163a2828ff2646eb27d021167ad5ccfb5a143f7f6c89d173383d1365a9a1ba9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "163a2828ff2646eb27d021167ad5ccfb5a143f7f6c89d173383d1365a9a1ba9a", kill_on_drop: false }` [INFO] [stdout] 163a2828ff2646eb27d021167ad5ccfb5a143f7f6c89d173383d1365a9a1ba9a