[INFO] fetching crate install-framework-core 1.0.0... [INFO] building install-framework-core-1.0.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate install-framework-core 1.0.0 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate install-framework-core 1.0.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate install-framework-core 1.0.0 [INFO] finished tweaking crates.io crate install-framework-core 1.0.0 [INFO] tweaked toml for crates.io crate install-framework-core 1.0.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding dirs v3.0.2 (available: v5.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f68ac64c2745c29c7815a1536b2669f13c4e919b5dc15911eb54f5c8c0fd3224 [INFO] running `Command { std: "docker" "start" "-a" "f68ac64c2745c29c7815a1536b2669f13c4e919b5dc15911eb54f5c8c0fd3224", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f68ac64c2745c29c7815a1536b2669f13c4e919b5dc15911eb54f5c8c0fd3224", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f68ac64c2745c29c7815a1536b2669f13c4e919b5dc15911eb54f5c8c0fd3224", kill_on_drop: false }` [INFO] [stdout] f68ac64c2745c29c7815a1536b2669f13c4e919b5dc15911eb54f5c8c0fd3224 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76868b5a52a878a6683303dcbef5431bbcfe4f7b149608d68d6022521d9a95b8 [INFO] running `Command { std: "docker" "start" "-a" "76868b5a52a878a6683303dcbef5431bbcfe4f7b149608d68d6022521d9a95b8", kill_on_drop: false }` [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Compiling dirs-sys v0.3.7 [INFO] [stderr] Compiling dirs v3.0.2 [INFO] [stderr] Compiling install-framework-core v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/builder.rs:45:51 [INFO] [stdout] | [INFO] [stdout] 43 | impl <'a> InstallerBuilder<'a> [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 44 | { [INFO] [stdout] 45 | pub fn new(install: &'a mut dyn Installer) -> InstallerBuilder [INFO] [stdout] | ^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/command.rs:71:40 [INFO] [stdout] | [INFO] [stdout] 71 | while let Some((resid, cmd)) = self.queue.pop_front() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 72 | { [INFO] [stdout] 73 | interpreter.execute(resid, cmd)?; [INFO] [stdout] | -------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 74 | interpreter.progress(cur, max)?; [INFO] [stdout] | ------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 75 | cur += 1; [INFO] [stdout] 76 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `install-framework-core` (lib) due to 1 previous error; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "76868b5a52a878a6683303dcbef5431bbcfe4f7b149608d68d6022521d9a95b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76868b5a52a878a6683303dcbef5431bbcfe4f7b149608d68d6022521d9a95b8", kill_on_drop: false }` [INFO] [stdout] 76868b5a52a878a6683303dcbef5431bbcfe4f7b149608d68d6022521d9a95b8