[INFO] fetching crate hexchat-plugin 0.2.14... [INFO] building hexchat-plugin-0.2.14 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate hexchat-plugin 0.2.14 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate hexchat-plugin 0.2.14 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hexchat-plugin 0.2.14 [INFO] finished tweaking crates.io crate hexchat-plugin 0.2.14 [INFO] tweaked toml for crates.io crate hexchat-plugin 0.2.14 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1221a9425f1eeda85303e0aa2d772acda7369ee3e6a47d768b3821d6f2f1a309 [INFO] running `Command { std: "docker" "start" "-a" "1221a9425f1eeda85303e0aa2d772acda7369ee3e6a47d768b3821d6f2f1a309", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1221a9425f1eeda85303e0aa2d772acda7369ee3e6a47d768b3821d6f2f1a309", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1221a9425f1eeda85303e0aa2d772acda7369ee3e6a47d768b3821d6f2f1a309", kill_on_drop: false }` [INFO] [stdout] 1221a9425f1eeda85303e0aa2d772acda7369ee3e6a47d768b3821d6f2f1a309 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f031ec7392cae394ccd0256afbb0384c9681128dde728b6827ec4a81af4105dd [INFO] running `Command { std: "docker" "start" "-a" "f031ec7392cae394ccd0256afbb0384c9681128dde728b6827ec4a81af4105dd", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling hexchat-plugin v0.2.14 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `filename` [INFO] [stdout] --> src/lib.rs:1447:9 [INFO] [stdout] | [INFO] [stdout] 1447 | let filename = if !(*plugin_name).is_null() { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filename` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:908:19 [INFO] [stdout] | [INFO] [stdout] 903 | let f: Rc = rc_clone_from_raw(ud as *const TimerHookUd); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `f` calls a custom destructor [INFO] [stdout] | `f` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 908 | match catch_unwind(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 909 | | (f.0)(&mut PluginHandle::new(f.1, f.2)) [INFO] [stdout] 910 | | }) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |______________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 943 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `f` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `closure` is never read [INFO] [stdout] --> src/lib.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 357 | pub struct Context { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 358 | ctx: RcWeak<*const internals::HexchatContext>, // may be null [INFO] [stdout] 359 | closure: Rc>>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Context` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hexchat-plugin` (lib) due to 1 previous error; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f031ec7392cae394ccd0256afbb0384c9681128dde728b6827ec4a81af4105dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f031ec7392cae394ccd0256afbb0384c9681128dde728b6827ec4a81af4105dd", kill_on_drop: false }` [INFO] [stdout] f031ec7392cae394ccd0256afbb0384c9681128dde728b6827ec4a81af4105dd