[INFO] fetching crate h10 0.6.18... [INFO] building h10-0.6.18 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate h10 0.6.18 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate h10 0.6.18 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate h10 0.6.18 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate h10 0.6.18 [INFO] tweaked toml for crates.io crate h10 0.6.18 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate crates.io crate h10 0.6.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded html-rs v0.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f96d3596b418abffe6bd46dab2cc76b5f5ec96fef804c7ccd7f6b3f6e59f01d [INFO] running `Command { std: "docker" "start" "-a" "1f96d3596b418abffe6bd46dab2cc76b5f5ec96fef804c7ccd7f6b3f6e59f01d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f96d3596b418abffe6bd46dab2cc76b5f5ec96fef804c7ccd7f6b3f6e59f01d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f96d3596b418abffe6bd46dab2cc76b5f5ec96fef804c7ccd7f6b3f6e59f01d", kill_on_drop: false }` [INFO] [stdout] 1f96d3596b418abffe6bd46dab2cc76b5f5ec96fef804c7ccd7f6b3f6e59f01d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b37b09f47a168528a13bc1571b4f339550f4248587f76008df8fa1b79be98c38 [INFO] running `Command { std: "docker" "start" "-a" "b37b09f47a168528a13bc1571b4f339550f4248587f76008df8fa1b79be98c38", kill_on_drop: false }` [INFO] [stderr] Compiling h10 v0.6.18 (/opt/rustwide/workdir) [INFO] [stderr] Compiling html-rs v0.3.0 [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-A box_pointers` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-A box_pointers` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/client.rs:66:15 [INFO] [stdout] | [INFO] [stdout] 33 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `rx` calls a custom destructor [INFO] [stdout] | `rx` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | match handle.join() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `rx` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mpmc/mod.rs:1346:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `len` is never used [INFO] [stdout] --> src/constants.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 18 | impl AsciiWhiteSpace { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub const fn len() -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `h10` (lib) due to 1 previous error; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b37b09f47a168528a13bc1571b4f339550f4248587f76008df8fa1b79be98c38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b37b09f47a168528a13bc1571b4f339550f4248587f76008df8fa1b79be98c38", kill_on_drop: false }` [INFO] [stdout] b37b09f47a168528a13bc1571b4f339550f4248587f76008df8fa1b79be98c38